867354 - Only solicit Google Play feedback when the build came from the Play store

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Alex Keybl [:akeybl]]

Only solicit Google Play feedback when the distribution ID isn't 'yandex'. This will prevent confusion for people who don't have Google Play.

We may want to make this change for all non-standard distribution IDs.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

We could either add code to the app to look at the distribution, or we could ship a preferences.json that disables the feedback from showing.

Adding code to the app might break for "campaign tracking" which would install from Play Store, but use a distribution id.

Let's consider the preferences.json approach.

Comment 2

[Kevin Brosnan [Ex-Mozilla]]

Anyone with a Google account can review Firefox. I get the incongruity of the situation. Is there a reason we don't want these reviews?

Comment 3

[:Margaret Leibovic]

So do we want to prevent showing about:feedback altogether for these distributions, or have an alternate version of about:feedback, perhaps one that directs positive feedback to input.mozilla.org instead? If we do want an alternate about:feedback, we'll need some strings for that.

Not showing about:feedback would definitely be a quicker solution that we could uplift if necessary. However, if we do go with the preferences.json approach we'll need to move around the logic used to show about:feedback, since right now we do all that in java. Perhaps instead of calling loadUrlInTab, we could send a message to gecko saying we want to solicit feedback, then gecko can use that pref do decide whether or not to do that.

(In reply to Kevin Brosnan [:kbrosnan] from comment #2)
> Anyone with a Google account can review Firefox. I get the incongruity of
> the situation. Is there a reason we don't want these reviews?

I think it seems odd to ask for a google play store review if the user downloaded the app through a different store.

Comment 5

[:Margaret Leibovic]

Updating the summary to make this bug address the more general case.

In bug 802207, rnewman brought up the fact that we're prompting for feedback on nightly/aurora, which also don't come from the play store. For this case, we can use channel-specific build defines to avoid prompting for feedback.

Comment 6

[:Margaret Leibovic]

Thinking about this more, instead of doing special things for when we want to *not* ask for feedback, is there any way for us to know a build came from the play store, and use that to decide whether or not to point to user at the play store?

Comment 7

[Aaron Train [:aaronmt]]

Is this worth tracking?

Comment 8

[:Margaret Leibovic]

(In reply to Aaron Train [:aaronmt] from comment #7)
> Is this worth tracking?

I think so, especially if we think we'll have more non-play store distributions in the future.

Comment 9

[:Margaret Leibovic]

Attachment: Don't prompt for feedback in distribution builds

This is the uplift-able solution to not prompt for feedback in distribution builds.

I was wondering if we know what the overhead is for loading one of these subscripts, and whether or not it would be worth just sticking this in browser.js instead.

If you want to test this, commenting out the |if (shouldShowFeedbackPage)| makes it easier.

Comment 10

[:Margaret Leibovic]

Attachment: (Part 2) Only prompt for feedback on Beta and Release builds

I wrote this patch to address the issue in bug 802207, but thinking about this more, maybe we should just ignore this issue until we make an alternate about:feedback that sends positive feedback to input, since it's useful for Nightly/Aurora users to give us feedback.

Comment 11

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 756699 [details] [diff] [review]
Don't prompt for feedback in distribution builds

I think this is a good use of the lazy-loading system.

Comment 12

[:Margaret Leibovic]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7f70a88cba03

Comment 13

[:Margaret Leibovic]

Comment on attachment 756707 [details] [diff] [review]
(Part 2) Only prompt for feedback on Beta and Release builds

I'll fix this Nightly/Aurora issue in bug 878173.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7f70a88cba03

Comment 15

[Richard Newman [:rnewman]]

Margaret: can we do a better job of this via Bug 1220773?

Comment 16

[:Margaret Leibovic]

(In reply to Richard Newman [:rnewman] from comment #15)
> Margaret: can we do a better job of this via Bug 1220773?

Perhaps. We are working on moving about:feedback to a hosted web page (bug 1225676), but we'll still have client code to decide when to automatically open this page. However, would be nice if we could pass this install info as a parameter on that URL, and then the webpage could decide whether to solicit a review of just ask for feedback (something like bug 878173).

I'll file a bug.