Closed Bug 868737 Opened 10 years ago Closed 10 years ago

Allow loading different calendar processing backends

Categories

(Calendar :: Internal Components, defect)

Product:
Calendar
Component:
Internal Components
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: Fallen, Assigned: Fallen)

References

Details

Attachments

(1 file, 2 obsolete files)

Fix - v3
14.00 KB, patch
mmecca
: review+
Details | Diff | Splinter Review 
In preparation for ical.js I'd like to make it possible to load more than one backend. This way libical is loaded by default, but via pref another library could be loaded.

This patch doesn't do more than add the infrastructure, it doesn't add any more backends than the default libical.
Attached patch Fix - v1 (obsolete) — — Splinter Review 

        Attachment #745521 -
        Flags: review?(matthew.mecca)
Blocks: jsical

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Fix - v2 (obsolete)
        — 
          — Splinter Review
      

    


  
Update to take account for bug 868815

        Attachment #745521 -
        Attachment is obsolete: true

        Attachment #745521 -
        Flags: review?(matthew.mecca)

        Attachment #745633 -
        Flags: review?(matthew.mecca)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Fix - v3
        — 
          — Splinter Review
      

    


  
Update to correctly load service on startup.

        Attachment #745633 -
        Attachment is obsolete: true

        Attachment #745633 -
        Flags: review?(matthew.mecca)

        Attachment #746358 -
        Flags: review?(matthew.mecca)

        Attachment #746358 -
        Flags: review?(matthew.mecca) → review+

    
    

    
  
Pushed to comm-central changeset c948fbc5b33c
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.5

    
    

    
  
https://tbpl.mozilla.org/?tree=Thunderbird-Trunk Builds are broken:

> The error occurred while processing the following file:
>    /builds/slave/tb-c-cen-lx-000000000000000000/build/calendar/base/backend/libical/moz.build
> The underlying problem is a Python syntax error on line 6:
>     MODULE = calbase

    
    

    
  
Bustage fix in https://hg.mozilla.org/comm-central/rev/ca1f6fcd7bd8

There might also be a clobber needed, lets see.

          You need to log in
          before you can comment on or make changes to this bug.