868882 - [socorro-crashstats] gfxContext::gfxContext not showing up in /report/list

Status: VERIFIED FIXED

(Socorro :: Webapp, task)

Description

[Robert Helmer [:rhelmer]]

I was checking to see if bug 716298 was reproducible in the django app, but /report/list can't find that signature:

https://crash-stats-django.mozilla.org/report/list?signature=gfxContext%3A%3AgfxContext

I see it in search results, so there must be something wrong with /report/list:

https://crash-stats-django.mozilla.org/query/?product=Firefox&version=ALL%3AALL&range_value=1&range_unit=weeks&date=05%2F06%2F2013+01%3A00%3A00&query_search=signature&query_type=contains&query=https%3A%2F%2Fcrash-stats-django.mozilla.org%2Freport%2Flist%3Fsignature%3DgfxContext%253A%253AgfxContext&reason=&release_channels=&build_id=&process_type=any&hang_type=any

Comment 1

[Peter Bengtsson [:peterbe]]

Nothing comes up on the search results.

Comment 2

[Robert Helmer [:rhelmer]]

(In reply to Peter Bengtsson [:peterbe] from comment #1)
> Nothing comes up on the search results.

Sorry I done goofed the URL somehow, try this (or just type the signature into the search box in the upper-left of every screen):

https://crash-stats-django.allizom.org/query/?query_type=simple&query=gfxContext%3A%3AgfxContext

Comment 3

[Robert Helmer [:rhelmer]]

Hm actually that comes up with a slightly different signature, which also exhibits the same problem:

https://crash-stats-django.allizom.org/report/list?signature=gfxContext%3A%3AgfxContext%28gfxASurface*%29&product=Firefox&query_type=contains&range_unit=weeks&process_type=any&hang_type=any&date=2013-05-06+17%3A00%3A00&range_value=1

Comment 4

[Robert Helmer [:rhelmer]]

I suspect this was caused by me in bug 848497, just ran into another manifestation of this... looks like 'ALL' is being explicitly passed to middleware, and socorro/external/postgresql/base.py is adding (r.product='ALL' AND r.version='ALL') to queries.

It looks like the right thing to do here is *not* pass product/version parameters to the mware service in question (reports I think)

Comment 5

[Jannis Leidel [:jezdez]]

From what I was able to understand till now is that there seems to be an inconsistency between the "middleware" and the Django app of what "ALL" means.

I guess we just need to decide if we want to express "selecting all versions of all products" with an empty value or "ALL". Since this is a filter interface with other optional fields for a big data set I think it's more correct to assume that passing no version value means "all".

Comment 6

[[DEACTIVATED] Adrian Gaudebert]

In the middleware, if you want a parameter to be equivalent to "ALL", you need to either skip it or make it empty. It didn't make much sense from an API point of view to accept those "ALL:ALL" values.

Comment 7

[Robert Helmer [:rhelmer]]

The (very confusing!) subtext here is that apparently at some point, the old kohana/php webapp supported showing multiple product/versions *at the same time* on the /report/list page, which is why the version parameter accepts product:version pairs (which is what ALL:ALL represents in this instance).

This apparently was never used, and the django code only supports this as much as is needed for old URLs to still work.

Comment 8

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/bbf5b8c30201cbf972cdea5c77f9a0525b082e1d
bug 868882 - don't force the versions parameter for the signature urls service.

https://github.com/mozilla/socorro/commit/d2d3efbb1bde066ac5c0e062f12f70b3c1c99444
Merge pull request #1254 from jezdez/bug868882-report-list-all

bug 868882 - don't force the versions parameter for the signature urls service.

Comment 9

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro-crashstats

https://github.com/mozilla/socorro-crashstats/commit/6ff5d24efc22bd7d75dfc8e2a0f930581b5fcb7b
bug 868882 - don't pass the version to the middleware if it's "ALL:ALL"

https://github.com/mozilla/socorro-crashstats/commit/cdb6be0416f9a3227fd6171734807fa46f2c9343
Merge pull request #346 from jezdez/bug868882-report-list-all

bug 868882 - don't pass the version to the middleware if it's "ALL:ALL"

Comment 10

[Matt Brandt [:mbrandt]]

Bumping to QA verified on stage - automation is passing.

Following the comments; comment 3 and comment 4:

https://crash-stats-django.allizom.org/query/?query_type=simple&query=gfxContext%3A%3AgfxContext

Searching for gfxContext::gfxContext(gfxASurface*) returns the expected results:

https://crash-stats-django.allizom.org/report/list?signature=gfxContext%3A%3AgfxContext%28gfxASurface*%29&product=Firefox&query_type=contains&range_unit=weeks&process_type=any&hang_type=any&date=2013-05-06+17%3A00%3A00&range_value=1