870057 - [MMS][Composer] Input field in bottom bar is not working as expected.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect, P1)

Description

[Dan Heberden]

Implement (currently page 53 on v8 wireframes) styling of input box with dynamic height to allow user to drag down the message (hiding the keyboard) and allowing review of the previous parts of the conversation while composing. 

This should also fix any current CSS bugs/issues with the composition window, size, and reaction to variable length content and limits.

Comment 1

[Dan Heberden]

Notes from #840069  

Composer input:
	+ Black & blinking text (Issue 1 attachment)
	+ 'setInputHeight' is not working as expected
	+ Layout is broken, and is breaking the App layout as well (not only the composer) (Issue 2 attachment)
- Composer, recipients container:
	+ Height has a 'pull-down' effect while typing. CSS is not working as expected. (Issue 3 attachment)
	+ Header is pushed up, so the layout of the app is broken
- Counter

Comment 2

[Dietrich Ayala (:dietrich)]

The last part of the Counter note from bug 840069 was:

+ Counter style completely broken (Issue 4 attachment)
+ maxSegmentsInfo is not working at all (it was a Tef+

Comment 3

[Dietrich Ayala (:dietrich)]

Blocks a blocker.

Comment 4

[Borja Salguero [:borjasalguero]]

As here there are more a lot of different things to fix, Im gonna split this in several bugs for having small & surgical patches. Stay tuned!

Comment 5

[Borja Salguero [:borjasalguero]]

Attachment: Black text issue

Comment 6

[Borja Salguero [:borjasalguero]]

Attachment: Layout broken

Comment 7

[greg]

Can you give steps to reproduce the black text issue. The layout issue seems to be a dup of https://bugzilla.mozilla.org/show_bug.cgi?id=870628

Comment 8

[Borja Salguero [:borjasalguero]]

STR:
- Go to input field
- Type 'mmmmmmmmm'
- Tap on 'ENTER' until reaching the header
- One more 'ENTER' until getting overflow
You will see a weird blinking text as in the attachment.

Comment 9

[John Hu [:johnhu][:johu][:醬糊小弟]]

Borja Salguero:

which version do you use?? 

I can't reproduce the "blinking text" in gaia-master.

Comment 10

[Borja Salguero [:borjasalguero]]

Hi John,
We were using gaia-master with B2G18.

Comment 11

[:gerard-majax]

I can't reproduce it either with current gaia master (1a9c162)/gecko b2g18 (a79f866) on Nexus S, neither on Keon with the same gecko b2g18 and gaia v1-train (08074c4) or gaia master (6f1813f).

Do you still experience it ?

Comment 12

[greg]

Borja can you provide exact hardware and software details? Nobody has been able to make this happen, but we really need to nail it down.

Comment 13

[Borja Salguero [:borjasalguero]]

It was tested during the work-week in Portland. Currently the issue here is the input height, that is not working as expected. I'm gonna update with a snapshot.
Today's BUILD, Gaia master.

Comment 14

[Borja Salguero [:borjasalguero]]

Attachment: setInputHeight is not working as expected

Comment 15

[:gerard-majax]

Comment on attachment 751010 [details]
setInputHeight is not working as expected

And what should be the expected behavior ?

Comment 16

[greg]

It's not clear to me what the status of the "blinking text" issue is. Borja, could you clarify the status of the different issues in this bug, and/or create separate bugs so their statuses can be tracked independently.

Comment 17

[greg]

Still hoping :borjasalguero or :danheberden can look at this and break this into separate bugs for each issue and clarify the status of the various sub-issues.

Comment 18

[Borja Salguero [:borjasalguero]]

Hi Greg,
As I commented in https://bugzilla.mozilla.org/show_bug.cgi?id=870057#c13 the issue here is the 'setInputHeight' method. The height of the input should reach the bottom border of the recipients layer. This is the issue to fix in this bug.

Comment 19

[Kai-Chih Hu [:khu]]

Steve, is it something you can help here? Thanks.

Comment 20

[greg]

:borjasalguero In that case, am I correct in assuming that every other problem mentioned in this bug is no longer an issue? Thanks in advance

Comment 21

[Steve Chung [:steveck]]

(In reply to khu from comment #19)
> Steve, is it something you can help here? Thanks.

I can take this on, but I need some confirmation:

Hi Borja, based on your description and attached image, the main purpose in this bug is to adjust the input to fill up all the area under the recipients layer (like https://www.dropbox.com/sh/8jkb0osnvfda96e/TkcQuTbhHj#f:01.SMS.MMS_0008_Compose_textMMS_txt.png) instead of leaving the gray margin between the recipients and input?

Comment 22

[Borja Salguero [:borjasalguero]]

Yep. It's like in the following image:
https://www.dropbox.com/sh/8jkb0osnvfda96e/TkcQuTbhHj#f:01.SMS.MMS_0006_Compose_Longmessage.png

Thanks Steve!

Comment 23

[Steve Chung [:steveck]]

Attachment: Patch for adjusting max input height

Comment 24

[Borja Salguero [:borjasalguero]]

Comment on attachment 752578 [details]
Patch for adjusting max input height

The code looks good for me. Im gonna request Ismael review due this code is tied to his patch! ;)

Comment 25

[Borja Salguero [:borjasalguero]]

Comment on attachment 752578 [details]
Patch for adjusting max input height

Thanks Steve!

Comment 26

[Steve Chung [:steveck]]

Land in master: 3b9de15f436e60d5b92837cba166d3484efff0ea

Comment 27

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 3b9de15f436e60d5b92837cba166d3484efff0ea to:
v1-train: a9245c4de36f6d84ab860ea60b87470048bbbca7

Comment 28

[mdaniloff]

Verified fixed on: 

Build ID: 20130806071254
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/a2a9b89ef5ee
Gaia: 4c1a20570e20f64782ba170c14604395c48f7381
Platform Version: 18.1

No blinking text appears in the attachment, functions as intended