870063 - Make context menu use PromptService asynchronously

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

Content context menu as implemented in browser.js

Comment 1

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 755409 [details] [diff] [review]
patch

Prompt.jsm landed, so lets use it instead.

Comment 3

[Wesley Johnston (:wesj)]

Attachment: Patch

This depends on the patch in bug 877467.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 756677 [details] [diff] [review]
Patch

>diff --git a/mobile/android/chrome/content/browser.js b/mobile/android/chrome/content/browser.js

>+      var prompt = new Promt({

var? OMG!

Comment 5

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4fd2ae88da98

Comment 6

[mjh563]

new Promt ?

Comment 7

[Wesley Johnston (:wesj)]

doh. thanks
https://hg.mozilla.org/integration/mozilla-inbound/rev/3a1e8e7ac07e

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Backed out for robocop-2 failures.
https://hg.mozilla.org/integration/mozilla-inbound/rev/b11bffd58de9

https://tbpl.mozilla.org/php/getParsedLog.php?id=23725149&tree=Mozilla-Inbound

Comment 9

[Wesley Johnston (:wesj)]

Attachment: Patch

Apparently I was testing some sort of secret-not-this-patch patch. This works locally. Running on try:

https://tbpl.mozilla.org/?tree=Try&rev=fc640fa2a79a

Comment 10

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/30302320b7e4

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/30302320b7e4