870344 - Theme images are not displayed in Theme Edit listing page

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect, P2)

Description

[Cristian Boldan]

Steps to reproduce:
1. Load Developer hub https://addons-dev.allizom.org/en-US/developers
2. Submit a new theme
3. After submission is finished, click the Edit Listing link

Expected results:
There are no design or layout issues in the Theme edit listing page.

Actual results:
Theme previews and images are not displayed.

Notes/Issues:
Verified on FF20 (Win 7). Issue is not reproducing in production.
Screencast for this issue http://screencast.com/t/dGUt1kVDpY

Comment 1

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/zamboni/commit/ff9b42d

Comment 2

[Victor Carciu]

Issue is still reproducible : http://screencast.com/t/YkJN4WnmpNK

Comment 3

[Christopher Van Wiemeersch [:cvan]]

Jason, ideas why the celery queue is getting backed up again? How can we identify issues like these in the problem - and/or how can we avoid the queue getting full? Is there anything in the code we can do differently too?

Comment 4

[Victor Carciu]

I have an update to this bug : now the images are displayed in edit listing, but the preview section is empty : http://screencast.com/t/woCxUqKsti

Comment 5

[Iulian Timis]

All the images from Edit listing page are now missing http://screencast.com/t/Y98gfsxP8yV

Comment 6

[Kevin Ngo [:ngoke]]

If I make the theme image-saving code not be Celery tasks (and thus synchronous), the images show up fine immediately. Though as it is now, the images are not saving. Are there Celery logs to see if it's backed up on -dev?

Comment 7

[Kevin Ngo [:ngoke]]

Celery seems okay: https://bugzilla.mozilla.org/show_bug.cgi?id=851881#c13

Theme preview images on edit page fix: https://github.com/mozilla/zamboni/commit/d58c6c88c04035b2b47706efc88088801fb0d897

Comment 8

[Iulian Timis]

Issue is still reproducing in https://addons-dev.allizom.org/en-US/developers/ on FF21 (Win 7)
Please see screencast http://screencast.com/t/OH8o9ATGT7

Comment 9

[Kevin Ngo [:ngoke]]

It's intermittent depending if Celery is backed up. At this time of day, it works for me. Should not be problem on prod.

Comment 10

[Victor Carciu]

And if we see it again in -dev, should we reopen the bug?

Comment 11

[Iulian Timis]

I can consistently reproduce this issue in https://addons-dev.allizom.org/en-US/developers/ on FF23 (Win 7).
Please see screencast http://screencast.com/t/4DPNCKf2La

Comment 12

[Iulian Timis]

Issue is also reproducing in production https://addons.mozilla.org/en-US/developers/ on FF23 (Win 7).

Comment 13

[Kevin Ngo [:ngoke]]

Celery issue cleared up on prod, -dev might still be slow on this.

If it happens again, I'd leave a comment here saying there might be a Celery issue again.

Comment 15

[Iulian Timis]

Verified as fixed inhttps://addons-dev.allizom.org/en-US/developers/ and https://addons.mozilla.org/en-US/developers/ on FF23 (Win 7).
Postfix screencast http://screencast.com/t/tjNJURH8L
Closing bug.

Comment 16

[Iulian Timis]

Theme images are missing again from Theme Edit Listing page on AMO-dev, probably a Celery issue.

Comment 17

[Kevin Ngo [:ngoke]]

Celery working fine now.

Comment 18

[Madalin Cotetiu]

Icon, header footer and preview image are not displayed.
Issue is reproducing in AMO-dev and AMO-olympia on FF27 (Win 7)
Please see screencast for this issue: http://screencast.com/t/QJW5ZzT9e

Comment 19

[Kevin Ngo [:ngoke]]

Was probably a Celery hiccup again. WFM on -dev/-olympia-dev.

Comment 20

[Madalin Cotetiu]

This issue can now be reproduced on -stage. (It works for me too on -dev and -olympia-dev)
Please see the screencast: http://screencast.com/t/5iubkgdG9
Reopening.

Comment 21

[Kevin Ngo [:ngoke]]

Has this reproduced on prod?

Comment 22

[Amy Tsay [:amyt]]

I don't have a theme older than 2013, so I'm not able to test.

Comment 23

[Madalin Cotetiu]

(In reply to Kevin Ngo [:ngoke] from comment #21)
> Has this reproduced on prod?

No, it didn't. When i reopened the bug I could only reproduce it on stage.
At this moment it doesn't reproduce anymore. (Works fine on dev, stage and production)

Comment 24

[Kevin Ngo [:ngoke]]

Thanks Cotetiu.

Comment 25

[Madalin Cotetiu]

Cant reproduce this issue anymore. screencast: http://screencast.com/t/vHb2yDFRM
Closing.