870664 - OAuth2 Error recovery flow from utility tray (notification)

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Description

[James Lal [:lightsofapollo]]

+++ This bug was initially created as a clone of Bug #867748 +++

Splitting bugs up to ease reviews (this on really depends on the logic that will land in 867748)

Comment 1

[James Lal [:lightsofapollo]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/9693

Pointer to Github pull-request

Comment 2

[James Lal [:lightsofapollo]]

Comment on attachment 748379 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/9693

Testing now- mostly refactoring and a hook into the new error handling logic

Comment 4

[Kevin Grandon :kgrandon]

Comment on attachment 748379 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/9693

Nice! I gave the code a review, and it looks good. I'm going to run out today, but  will be testing it this weekend.

Comment 5

[James Lal [:lightsofapollo]]

in v1.0.1: https://github.com/mozilla-b2g/gaia/commit/88f67d4ae48de05096b0679004f79f274bd155a9

Comment 6

[James Lal [:lightsofapollo]]

in master (earlier in the day forgot to mark this as fixed) https://github.com/mozilla-b2g/gaia/commit/88f67d4ae48de05096b0679004f79f274bd155a9

Comment 7

[James Lal [:lightsofapollo]]

in v1-train: fb079c3f4d5efbeb2150fa5dd613492867a3cf24

Comment 8

[Jason Smith [:jsmith]]

Marking verified to indicate that there has been an informal test pass done on this feature. Note that there's more testing to be done here in a more formal analysis, but I'm marking verified to indicate that this has been looked at.