Closed
Bug 890647
Opened 11 years ago
Closed 10 years ago
[email] unfork value_selector.css, participate in migration of the BB to shared from system app
Categories
(Firefox OS Graveyard :: Gaia::E-Mail, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.0 S4 (20june)
People
(Reporter: asuth, Assigned: jrburke)
References
Details
(Whiteboard: [LibGLA,TD85074,WW,B])
Attachments
(1 file)
Bug 870747 is about moving the (effectively) canonical value_selector.css into shared. Right now e-mail's value_selector.css is dangerously over-specific to the screen height of our decides in rem it appears, for example. At least, bug 890486 is about our folder list getting visually truncated by the buttom at the bottom of the value list and the proposed patch is changing a hard-coded 37rem to a hard-coded 36rem.
I'm going to land that fix since a more thorough cleanup is probably not going to be accepted for uplift to v1.1, but we should to this one soon.
Assignee | ||
Comment 2•11 years ago
|
||
While scanning through the files for the 2.0 visual refresh, I noticed email's value selector stuff is not quite the same as the shared 2.0 one, at least the button style. I'll take this as ticket to do under the context of the 2.0 redesign, but I see it more as a bug fix -- just moving to the shared one. So may not get to it until end of this sprint or even in the first bug fix sprint.
Not sure if it will work out yet, if our use will fit in that model (may still have some custom styling/behavior around unselectable folders for example), but if so, I will move the email code over. Otherwise, clean up the styles.
And make sure to remove any images in the email area if the shared ones are used instead.
Assignee: nobody → jrburke
Target Milestone: --- → 2.0 S3 (6june)
Assignee | ||
Updated•11 years ago
|
Target Milestone: 2.0 S3 (6june) → 2.0 S4 (20june)
Assignee | ||
Comment 3•10 years ago
|
||
Move to the shared value_selector styles.
Attachment #8441821 -
Flags: review?(m)
Updated•10 years ago
|
Attachment #8441821 -
Flags: review?(m) → review+
Assignee | ||
Comment 4•10 years ago
|
||
Merged in master:
https://github.com/mozilla-b2g/gaia/commit/b889fdf33a15440eaab9253ab845543126956a7f
From pull request:
https://github.com/mozilla-b2g/gaia/pull/20646
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment 5•10 years ago
|
||
Hi, Looks this fix is not available in v2.0
Please check
Flags: needinfo?(jrburke)
Whiteboard: [LibGLA,TD85074,WW,B]
Assignee | ||
Comment 6•10 years ago
|
||
That is correct, v2.0 was branched on June 9 and this landed on June 18. As this was not a critical blocker fix, more of just a refactoring, 2.0? was not requested.
Flags: needinfo?(jrburke)
You need to log in
before you can comment on or make changes to this bug.
Description
•