Closed Bug 872243 Opened 8 years ago Closed 8 years ago

Change - Remove the "rainbow" gradients from the start screen

Categories

(Firefox for Metro Graveyard :: Theme, defect, P1)

All
Windows 8.1

Tracking

(Not tracked)

VERIFIED FIXED
Firefox 24

People

(Reporter: mbrubeck, Assigned: mbrubeck)

References

Details

(Whiteboard: feature=change c=firefox_start u=metro_firefox_user p=1 status=verified)

Attachments

(1 file)

Attached patch patchSplinter Review
Horlander wants us to switch to a flat background.
Attachment #749501 - Flags: review?
Attachment #749501 - Flags: review? → review?(fyan)
Hey Matt, can you provide a point estimate and a bug ID (story) I can relate this change to?  Also, is this change for the current iteration?
Blocks: metrov1defect&change
No longer blocks: 747789
Whiteboard: feature=change c=tbd u=tbd p=0
(In reply to Marco Mucci [:MarcoM] from comment #1)
> Hey Matt, can you provide a point estimate and a bug ID (story) I can relate
> this change to?  Also, is this change for the current iteration?

Point estimate: 1

There's no story directly related to this, because the original feature was implemented before we started writing or tracking stories.  It's related to epic bug 747789.  If we need a story for tracking purposes, then we could bug 794028 which is probably the closest existing one.
Thanks Matt.  I've made the changes and added it to IT#7.
Blocks: 747789, metrov1it7
No longer blocks: metrov1defect&change
Priority: -- → P1
QA Contact: jbecerra
Whiteboard: feature=change c=tbd u=tbd p=0 → feature=change c=firefox_start u=metro_firefox_user p=1
Comment on attachment 749501 [details] [diff] [review]
patch

Review of attachment 749501 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with comment addressed.

::: browser/metro/theme/platform.css
@@ +703,1 @@
>    background-repeat: no-repeat, no-repeat, no-repeat, no-repeat, no-repeat, repeat;

This should be replaced with:
background-repeat: no-repeat;
Attachment #749501 - Flags: review?(fyan) → review+
https://hg.mozilla.org/mozilla-central/rev/3256f8d91250
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 24
For testing and verification.
Flags: needinfo?(jbecerra)
Tested on 2013-05-22 using latest nightly built from http://hg.mozilla.org/mozilla-central/rev/c21ef3664c67

The start page now has a flat background. It no longer looks like the attachments in bug 747789.
Status: RESOLVED → VERIFIED
Flags: needinfo?(jbecerra)
Whiteboard: feature=change c=firefox_start u=metro_firefox_user p=1 → feature=change c=firefox_start u=metro_firefox_user p=1 status=verified
Blocks: 794028
No longer blocks: 747789
Blocks: 831923
No longer blocks: 794028
User Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0
Build ID: 20130819030205
Built from http://hg.mozilla.org/mozilla-central/rev/c8c9bd74cc40

WFM
Tested on windows 8 using latest nightly for iteration-12. The start page now has a flat background. It no longer looks like the attachments in bug 747789.
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.