831923 - Story - Use the Firefox Start Top Sites tile group in full screen view

Status: VERIFIED FIXED

(Tracking Graveyard :: Metro Operations, defect, P2)

Description

[Asa Dotzler [:asa]]

Attachment: UC-50 Use the Awesome screen Top Sites tile group

Comment 1

[Marco Mucci [:MarcoM]]

Hi Asa,

Can you remove 848155 and convert it into it's own story as Ally recommended or does it need to stay to truly complete the story as described?

Comment 2

[Allison Naaktgeboren :ally]

As per the email ont eh metro mailing list, I would like to call this 'done' with a defect story, and a new feature in bug 848155

Comment 3

[Asa Dotzler [:asa]]

(In reply to Marco Mucci [:MarcoM] from comment #1)
> Hi Asa,
> 
> Can you remove 848155 and convert it into it's own story as Ally recommended
> or does it need to stay to truly complete the story as described?

I don't think that's really a story. Maybe we close this story and treat 848155 as a defect or change?

Comment 4

[Marco Mucci [:MarcoM]]

Thanks Asa.  OK, we can treat 848155 as a separate Change Story.

Comment 5

[juan becerra [:juanb]]

Tested on 2013-03-15 using Nightly built from http://hg.mozilla.org/mozilla-central/rev/0f7261e288f2
- (defect?) Tested with a new profile opening more than 9 sites. After restart and opening a new tab, I see the Top Sites group with 8 tiles. I can tap of any of them to open the intended site. Filed bug 851576.
- In snapped view the top sites link does not work, so I added 835999 to the list of bugs this depends on.

The story says that with a new profile a user should see 9 blank tiles. This is not the case. It the Top Sites area is empty, and that seems right but I would like the story to be revised to account for this.

Comment 6

[Marco Mucci [:MarcoM]]

From Juan's Testing:

Tested on 2013-03-15 using Nightly built from http://hg.mozilla.org/mozilla-central/rev/0f7261e288f2
- Tested with a new profile opening more than 9 sites. After browser restart and opening a new tab, I see the Top Sites group with 8 tiles.

Steps:
1. Install Firefox anew
2. Open Firefox for Metro and open more than 9 sites
3. Close the browser and reopen it
4. Open a new tab.

Expected: Top Sites list should have 9 tiles

Actual: Top Sites list has 8 tiles

Comment 7

[Allison Naaktgeboren :ally]

(In reply to Marco Mucci [:MarcoM] from comment #6)
> Expected: Top Sites list should have 9 tiles
> 
> Actual: Top Sites list has 8 tiles

This is not a bug, this was a change as requested by Yuan, blessed by Asa, and filed as a defect, bug 848999(though if one wishes to split hairs, it is a change story because when the first topsites code landed in october, the directive was 9). 

This was discussed at the monday meeting.

Comment 8

[Allison Naaktgeboren :ally]

(In reply to juan becerra [:juanb] from comment #5)
> - In snapped view the top sites link does not work, so I added 835999 to the
> list of bugs this depends on.

Not part of this story, that is part of story 831894. In general, the snapped actions are separate from the full screen stories, so please bear that in mind when testing.

Comment 9

[Marco Mucci [:MarcoM]]

Thanks Ally.  Bug 848999 wasn't linked to 831923.  I've added that dependency.

Comment 10

[juan becerra [:juanb]]

I'll mark this as verified, per comments.

QA note: Story should reflect 8 vs. 9 tiles and snapped view behavior is a separate story.

Comment 11

[Brian R. Bondy [:bbondy]]

Tested as per Comment 5 but noticed that the thumbnails do not always show up. Posted bug 875924 for that.

Comment 12

[Brian R. Bondy [:bbondy]]

Tested with:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-05-24-05-05-55-mozilla-central/firefox-24.0a1.en-US.win32.installer.exe

Comment 13

[Samvedana (:Samvedana)]

User Agent: Mozilla/5.0 (Windows NT 6.2; Win64; x64; rv:25.0) Gecko/20130707 Firefox/25.0
Build ID: 20130707031138

WFM for iteration-9
Tested on Windows 8.1 preview using latest nightly build from ftp://ftp.mozilla.org/pub/firefox/nightly/2013/07/2013-07-07-03-11-38-mozilla-central/
I used same steps given in user story.
I am getting expected result.