872711 - Warning: Error in parsing value for 'border-bottom-left-radius'. Declaration dropped.

Status: RESOLVED FIXED

(Firefox Graveyard :: SocialAPI, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

Timestamp: 5/15/2013 4:02:27 PM
Warning: Error in parsing value for 'border-bottom-left-radius'.  Declaration dropped.
Source File: chrome://browser/skin/browser.css
Line: 1370, Column: 29
Source Code:
  border-bottom-left-radius: none;


In the CSS:
.social-share-frame {
  background: linear-gradient(to bottom, #f0f4f7, #fafbfc);
  width: 330px;
  height: 150px;
  border-top-left-radius: none;
  border-bottom-left-radius: none;
  border-top-right-radius: inherit;
  border-bottom-right-radius: inherit;
  /* we resize our panels dynamically, make it look nice */
  transition: height 100ms ease-out, width 100ms ease-out;
}

border-top-left-radius and border-top-right-radius need a length unit, so 0 is probably what you want here.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Hi Alex, thanks for offering to work on this bug!

To find the places that need this fixed, you can look at the following search results:

http://mxr.mozilla.org/mozilla-central/search?string=border-top-left-radius:+none;

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch

Comment 3

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 757796 [details] [diff] [review]
Patch

I only tested on osx, but looks good.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Thanks!

https://hg.mozilla.org/integration/mozilla-inbound/rev/a8e61d04f786

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/a8e61d04f786