Closed
Bug 873505
Opened 11 years ago
Closed 11 years ago
Set frame's animation time based on desired time, not actual time
Categories
(Core :: Graphics: ImageLib, defect)
Tracking
()
RESOLVED
FIXED
mozilla24
People
(Reporter: joe, Assigned: joe)
References
Details
Attachments
(1 file)
|
1.46 KB,
patch
|
seth
:
review+
|
Details | Diff | Splinter Review |
Our current image animation code uses the refresh driver's time as the current animation time, but we should really use the expected time (so we'll skip frames if we slip) instead. This is important to ensure that animations can be synchronized. https://tbpl.mozilla.org/?tree=Try&rev=fcf0389df19d
Attachment #751062 -
Flags: review?(seth)
|
||
Comment 1•11 years ago
|
||
Comment on attachment 751062 [details] [diff] [review] set animation time based on frame's timeout Review of attachment 751062 [details] [diff] [review]: ----------------------------------------------------------------- Looks good!
Attachment #751062 -
Flags: review?(seth) → review+
|
Assignee | |
Comment 2•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/9ac8495cf585
|
||
Comment 3•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/9ac8495cf585
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in
before you can comment on or make changes to this bug.
Description
•