876332 - Animated PNG does not work properly in certain demo

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Alice0775 White]

Build Identifier:
http://hg.mozilla.org/mozilla-central/rev/0fed3377c839
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20130526 Firefox/24.0 ID:20130526031046

Steps to Reproduce:
1. Open http://people.mozilla.com/~dolske/apng/demo.html
2. Click "Show Demo" button of "Demo 2: Blending modes"
3. Wait for a minutes

Alternative Steps to Reproduce:
1. Open http://people.mozilla.com/~dolske/apng/demo-2-over+background.png
2. Wait for a minutes

Actual Results:
APNG image does not play.
After session restore, APNG image is animated one cycle and then stops forever.

Expected results:
APNG image should be animated forever.


Regression window(m-c)
Good:
http://hg.mozilla.org/mozilla-central/rev/00b264c7cced
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20130522 Firefox/24.0 ID:20130522092949
Bad:
http://hg.mozilla.org/mozilla-central/rev/8eebe35aae63
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20130523 Firefox/24.0 ID:20130523044333
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=00b264c7cced&tochange=8eebe35aae63

Regression window(m-i)
Good:
http://hg.mozilla.org/integration/mozilla-inbound/rev/2a4461b9480b
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20130522 Firefox/24.0 ID:20130522221332
Bad:
http://hg.mozilla.org/integration/mozilla-inbound/rev/aaa399729ff4
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20130522 Firefox/24.0 ID:20130522221631
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=2a4461b9480b&tochange=aaa399729ff4

Suspected: Bug 867758

Comment 1

[Alice0775 White]

Also about:robots tab fabicon is also affected.
(@mayankleoboy1 reported in http://forums.mozillazine.org/viewtopic.php?p=12884069#p12884069)

Comment 2

[Alice0775 White]

In local build
Last God: b0d4c7e61aed
First Bad: 9ac8495cf585
Regressed by
9ac8495cf585	Joe Drew — Bug 873505 - Set the animation frame's start time based on when we *wanted* to start, not when we actually did. r=seth

Comment 3

[Joe Drew (not getting mail)]

Attachment: set currentAnimationFrameTime correctly

This fixes this bug. We were setting the currentAnimationFrameTime based on the previous frame's time plus the next frame's timeout, which is nonsense but works a lot of the time because most animations do not have different delays per frame.

I have absolutely no idea how to test this automatically.

Comment 5

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 755039 [details] [diff] [review]
set currentAnimationFrameTime correctly

Review of attachment 755039 [details] [diff] [review]:
-----------------------------------------------------------------

Include the commit message in the patch.

Comment 6

[Joe Drew (not getting mail)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5f71e27bab63

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5f71e27bab63

Comment 9

[Petruta Horea [:phorea], PTO until 8/22/25]

Verified fixed on Fx 24 beta 9, buildID 20130905180733.
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Firefox/24.0