Closed
Bug 875585
Opened 11 years ago
Closed 11 years ago
[meta] test_Range-surroundContents is very OOMy
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
WORKSFORME
People
(Reporter: mccr8, Unassigned)
References
()
Details
(Keywords: memory-leak, meta)
As you can see, there are a lot of active intermittent oranges caused by this test (or maybe set of tests). These are just the ones I found with a bit of searching.
I'm not sure what the way to fix this is. Can we add forced GCs in between the tests in this directory, or additional time to let things get collected?
Updated•11 years ago
|
Flags: needinfo?(ayg)
Reporter | ||
Updated•11 years ago
|
Comment 1•11 years ago
|
||
What am I being asked for info on? These tests should just be chopped down in size (upstream) -- they don't really need to test *so* many permutations. This would greatly reduce runtime too. See bug 859087. I could do this when I next have free time (mid-July).
Flags: needinfo?(ayg)
Comment 2•11 years ago
|
||
Thanks Aryeh, just wanted your input as test author.
Reporter | ||
Comment 3•11 years ago
|
||
This test is causing 7% of Windows M2 runs to blow out their log. philor is working around this by disabling some OOM log messages the CC is spamming.
Blocks: 876159
Reporter | ||
Comment 4•11 years ago
|
||
A medium term fix I'm working on will add the warnings back, but only once instead of a million times, but this test really needs to be fixed in some manner.
Comment 5•11 years ago
|
||
As a short term fix, after it failed by shoving an OOM assertion into another test's count of unexpected assertions, I disabled it on Windows in https://hg.mozilla.org/mozilla-central/rev/a81bece350a1, leaving Ms2ger to deal with the problem of only being able to disable a test on a platform by editing a DO NOT EDIT generated file.
Comment 6•11 years ago
|
||
(In reply to Phil Ringnalda (:philor) from comment #5)
> As a short term fix, after it failed by shoving an OOM assertion into
> another test's count of unexpected assertions, I disabled it on Windows in
> https://hg.mozilla.org/mozilla-central/rev/a81bece350a1, leaving Ms2ger to
> deal with the problem of only being able to disable a test on a platform by
> editing a DO NOT EDIT generated file.
Flags: needinfo?(Ms2ger)
Comment 7•11 years ago
|
||
Gave it the old heave-ho on aurora too in https://hg.mozilla.org/releases/mozilla-aurora/rev/edbdb962f5fe, since disabling a test is a clear a=test-only and deleting a couple of warnings is not.
Reporter | ||
Comment 8•11 years ago
|
||
Looks like test_Range-set has started failing about once a day due to OOM, in bug 894030.
Updated•11 years ago
|
Flags: needinfo?(Ms2ger)
Reporter | ||
Comment 9•11 years ago
|
||
Fixed by bug 933072. Hooray for roc!
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → WORKSFORME
Assignee | ||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•