877283 - [socorro-crashstats] Remove ADMIN email now that we have ErrorMill

Status: RESOLVED INVALID

(Infrastructure & Operations Graveyard :: WebOps: Other, task)

Description

[Peter Bengtsson [:peterbe]]

We now have ErrorMill working for socorro-crashstats stage (https://crash-stats-django.allizom.org) and prod (https://crash-stats-django.mozilla.org/)

So, can you please remove the socorro email address from the settings/local.py on those two sites.

Comment 1

[Peter Bengtsson [:peterbe]]

:jezdez, should we edit the logging settings or should we edit the ADMINS list?

Comment 2

[Jannis Leidel [:jezdez]]

(In reply to Peter Bengtsson [:peterbe] from comment #1)
> :jezdez, should we edit the logging settings or should we edit the ADMINS
> list?

The AdminEmailHandler uses django.core.mail.mail_admins to send out the emails, which uses the setting. To keep surprises from happening I would only remove the logging handler but keep the ADMINS setting in case we want to use that mail_admins function in the future.

Comment 3

[Chris Turra [:cturra]]

i agree with :jezdez. how would you like us to update the settings/local.py file to reflect this?

Comment 4

[Peter Bengtsson [:peterbe]]

:cturra I think need to fix this in code. 
...after lunch :)

Comment 5

[Chris Turra [:cturra]]

:peterbe - if that's the case, should we close this bug as r/invalid?

Comment 6

[Chris Turra [:cturra]]

closing this off as r/invalid since it will be solved in code versus a config change.