878005 - [b2g-bluetooth] Should reply "ERROR" when receiving invalid memory location of "ATD>nnn" command

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Gina Yeh [:gyeh] [:ginayeh]]

Although we haven't supported memory dialing in Firefox OS yet, we still have to reply "ERROR" when receiving invalid memory location in "ATD>nnn" command for BT certification.

Comment 1

[Eric Chou [:ericchou] [:echou]]

Attachment: patch 1: v1: send system message 'ATD>' to Gaia instead of sending 'BLDN' when receive 'ATD>' from headset

* Send system message 'ATD>' to Gaia instead of sending 'BLDN' when receive 'ATD>' from headset

Comment 2

[Eric Chou [:ericchou] [:echou]]

Nominate as tef+ since we need this (and bug 878006 as well, Dialer app support) for BT certification. It's almost the last blocker. Thank you.

Comment 3

[Joe Cheng [:jcheng] (please needinfo)]

triage: tef+ to resolve BT cert blocker

Comment 4

[Gina Yeh [:gyeh] [:ginayeh]]

Comment on attachment 756469 [details] [diff] [review]
patch 1: v1: send system message 'ATD>' to Gaia instead of sending 'BLDN' when receive 'ATD>' from headset

Review of attachment 756469 [details] [diff] [review]:
-----------------------------------------------------------------

I have no critical problem with that. Only a naming issue as commented.

::: dom/bluetooth/BluetoothHfpManager.cpp
@@ +894,1 @@
>      mBLDNProcessed = false;

We might want to rename the data member.

Comment 5

[Joe Cheng [:jcheng] (please needinfo)]

batch update on tef+ milestones. partner to make a final on 6/3 Asia time. TEF+ needs to be resolved by 6/3 to be in the final build. thanks

Comment 6

[Eric Chou [:ericchou] [:echou]]

Attachment: patch 1: final: send system message 'ATD>' to Gaia instead of sending 'BLDN' when receive 'ATD>' from headset, r=gyeh

* name of the member variable is modified.

Comment 7

[Eric Chou [:ericchou] [:echou]]

Attachment: patch 1: final: for b2g18

* b2g18-specific patch

Comment 8

[Eric Chou [:ericchou] [:echou]]

Attachment: patch 1: final: for v1.0.1

* v1.0.1-specific patch

Comment 9

[Eric Chou [:ericchou] [:echou]]

https://hg.mozilla.org/projects/birch/rev/4b53a4d649ff

Comment 10

[Eric Chou [:ericchou] [:echou]]

https://hg.mozilla.org/mozilla-central/rev/11ffadbeaa65

Comment 11

[Eric Chou [:ericchou] [:echou]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/3f274ad25d7e
https://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/aefb60f1ca66

Comment 12

[Eric Chou [:ericchou] [:echou]]

https://hg.mozilla.org/releases/mozilla-b2g18_v1_1_0_hd/rev/deeed7221fbd

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4b53a4d649ff