Closed Bug 878005 Opened 7 years ago Closed 7 years ago

[b2g-bluetooth] Should reply "ERROR" when receiving invalid memory location of "ATD>nnn" command

Categories

(Firefox OS Graveyard :: Bluetooth, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(blocking-b2g:tef+, firefox22 wontfix, firefox23 wontfix, firefox24 fixed, b2g18 fixed, b2g18-v1.0.0 wontfix, b2g18-v1.0.1 fixed, b2g-v1.1hd fixed)

RESOLVED FIXED
1.0.1 IOT3 (3jun)
blocking-b2g tef+
Tracking Status
firefox22 --- wontfix
firefox23 --- wontfix
firefox24 --- fixed
b2g18 --- fixed
b2g18-v1.0.0 --- wontfix
b2g18-v1.0.1 --- fixed
b2g-v1.1hd --- fixed

People

(Reporter: gyeh, Assigned: echou)

References

Details

(Whiteboard: [fixed-in-birch][status: landed])

Attachments

(3 files, 1 obsolete file)

Although we haven't supported memory dialing in Firefox OS yet, we still have to reply "ERROR" when receiving invalid memory location in "ATD>nnn" command for BT certification.
blocking-b2g: --- → tef?
Assignee: nobody → echou
Blocks: 878006
* Send system message 'ATD>' to Gaia instead of sending 'BLDN' when receive 'ATD>' from headset
Attachment #756469 - Flags: review?(gyeh)
Nominate as tef+ since we need this (and bug 878006 as well, Dialer app support) for BT certification. It's almost the last blocker. Thank you.
triage: tef+ to resolve BT cert blocker
blocking-b2g: tef? → tef+
Comment on attachment 756469 [details] [diff] [review]
patch 1: v1: send system message 'ATD>' to Gaia instead of sending 'BLDN' when receive 'ATD>' from headset

Review of attachment 756469 [details] [diff] [review]:
-----------------------------------------------------------------

I have no critical problem with that. Only a naming issue as commented.

::: dom/bluetooth/BluetoothHfpManager.cpp
@@ +894,1 @@
>      mBLDNProcessed = false;

We might want to rename the data member.
Attachment #756469 - Flags: review?(gyeh) → review+
batch update on tef+ milestones. partner to make a final on 6/3 Asia time. TEF+ needs to be resolved by 6/3 to be in the final build. thanks
Target Milestone: --- → 1.0.1 IOT3 (3jun)
* b2g18-specific patch
* v1.0.1-specific patch
Whiteboard: [fixed-in-birch] → [fixed-in-birch][status: uplift needed]
Flags: needinfo?(ryanvm)
https://hg.mozilla.org/mozilla-central/rev/11ffadbeaa65
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-birch][status: uplift needed] → [fixed-in-birch][status: landed, uplift needed]
Flags: needinfo?(ryanvm)
You need to log in before you can comment on or make changes to this bug.