878006 - [Dialer] Should check call index of Bluetooth ATD command

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Gina Yeh [:gyeh] [:ginayeh]]

When there's a memory dialing request from Bluetooth headset, we will check call history in Dialer App, and then dial a new call according to the order of call history.

Two examples here.

1. There are 3 numbers in call history, and we receive a memory dialing request from Bluetooth headset, such as "ATD>2". Then, we should get the second call number from call history and make a new call.

2. There are 3 numbers in call history, and we receive a memory dialing request like "ATD>10". Then, ignore the message and no outgoing call is made.

Comment 1

[Eric Chou [:ericchou] [:echou]]

Nominate as tef+ since we need this (and bug 878005 as well, Gecko support) for BT certification. It's almost the last blocker. Thank you.

Comment 2

[Joe Cheng [:jcheng] (please needinfo)]

triage: tef+ to resolve BT cert blocker

Comment 3

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10131

Pointer to Github pull-request

Comment 4

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 756495 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10131

Hi Etienne,

This simple patch adds support to dialer for handling call index of BT ATD command.

Please help review this with Bug 877070.
Thanks.

Comment 5

[Joe Cheng [:jcheng] (please needinfo)]

batch update on tef+ milestones. partner to make a final on 6/3 Asia time. TEF+ needs to be resolved by 6/3 to be in the final build. thanks

Comment 6

[Etienne Segonzac (:etienne)]

Comment on attachment 756495 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10131

r=me

Please squash before landing.

Thanks!

Comment 7

[Etienne Segonzac (:etienne)]

Comment on attachment 756495 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10131

I'm very sorry, I got confused with bug 877070 (both were in the PR)

Please rebase this patch against the new one and ask for review again, thanks!

Comment 8

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 756495 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10131

Hi Etienne,

The pull request has been updated.
Please note that this special action is for BT certification, and not used in general cases, that is why I did not add unit tests for it to get this done ASAP. Please let me know if you think it is still needed.

Thank you very much.

--
Really sorry to make you confused.
The original pull request includes both patches because they are highly related and the previous one was reviewed at that time.

Comment 9

[Etienne Segonzac (:etienne)]

Comment on attachment 756495 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10131

r=me with the nits on github addressed.

We'll definitely need unit tests for this but I'm willing to wait until the master version of the patch :)

We'll need a follow up bug for this (the master/v1-train) version too.

Thanks for all the bluetooth work!

Comment 10

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Merged to Gaia master,
https://github.com/mozilla-b2g/gaia/commit/9ba891c880e588a8f3f8ca30bb932ecae68023a9

Etienne,
Thanks for the review.

--
Follow-up bug: Bug 878389 for v1-train/master.

Comment 11

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

(In reply to Rudy Lu [:rudyl] from comment #10)
> Merged to Gaia master,

s/master/v1.0.1/

> https://github.com/mozilla-b2g/gaia/commit/
> 9ba891c880e588a8f3f8ca30bb932ecae68023a9
> 
> Etienne,
> Thanks for the review.
> 
> --
> Follow-up bug: Bug 878389 for v1-train/master.

Thanks for Eric's reminding.
:)