878389 - [Dialer] Should check call index of Bluetooth ATD command, on Gaia v1-train, master

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

+++ This bug was initially created as a clone of Bug #878006 +++

This is filed to track the following support to be done on Gaia v1-train/master.

--
When there's a memory dialing request from Bluetooth headset, we will check call history in Dialer App, and then dial a new call according to the order of call history.

Two examples here.

1. There are 3 numbers in call history, and we receive a memory dialing request from Bluetooth headset, such as "ATD>2". Then, we should get the second call number from call history and make a new call.

2. There are 3 numbers in call history, and we receive a memory dialing request like "ATD>10". Then, ignore the message and no outgoing call is made.

Comment 1

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

I think we will have to handle this before v1.1 get to the BT certification.
So nominated this.

Comment 2

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10240

Pointer to Github pull-request

Comment 3

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 759069 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10240

Hi Etienne,

This is the fix for both Bug 878389 and Bug 878184, which are the follow-ups for what we did for BT redial in v1.0.1.

Please help take a look.
Thanks.

Comment 4

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

I also helped Rudy to verify the problem on central. It seems working fine.

Comment 5

[Etienne Segonzac (:etienne)]

Comment on attachment 759069 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10240

My comments are on github.
Please flag for review again when those are addressed.

In the meantime, Fernando, your feedback would be greatly appreciated :)

Comment 6

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 759069 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10240

Hi Etienne,

Thanks for the review.
Your comments has been addressed in a separate commit.
Will do squash them if the patch gets r+.

Comment 7

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 759069 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10240

Thanks Rudy!

I've just added a few comments in the PR.

Comment 8

[Etienne Segonzac (:etienne)]

Comment on attachment 759069 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10240

r=me with Fernando's comments fixed!

(feel free to ask Fernando for a final r? if the changes are significant enough).

Thanks!

Comment 9

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 759069 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10240

Hi Fernando,

Thanks for taking a look at my patch.
I've refined the pull request to address your comments (as the 3rd commit).

Please help check it again?

As I said, will do squash after it's all good.
Thanks.

Comment 10

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 759069 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10240

Thanks Rudy! Looks good.

Comment 11

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Gaia master:
https://github.com/mozilla-b2g/gaia/commit/6126d368e1ed379ca2c34bc3ae510bc859473d2e

--
Dear Etienne, Fernando,
Thanks for the review.

Comment 12

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Gaia v1-train,
6627a1eca826b8fe320d2c221a430d22d77682c6

Comment 13

[John Ford [:jhford] CET/CEST Berlin Time]

1.1hd: 6627a1eca826b8fe320d2c221a430d22d77682c6