Drop support for -moz-prefixes from cursor: zoom-in | zoom-out | grab | grabbing

NEW
Unassigned

Status

()

Core
CSS Parsing and Computation
4 years ago
4 months ago

People

(Reporter: j.j., Unassigned, NeedInfo)

Tracking

(Blocks: 1 bug, {addon-compat, dev-doc-needed, site-compat})

Trunk
addon-compat, dev-doc-needed, site-compat
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
Bug 772153 added support for unprefixed cursor: zoom-in | zoom-out (Fx24).
Support for -moz-prefixes should be dropped after
<inset-arbitrary-number-here> releases.
(Reporter)

Updated

4 years ago
Blocks: 772153
No longer depends on: 772153

Updated

4 years ago
Blocks: 880672
Summary: Drop support for -moz-prefixes from cursor: zoom-in | zoom-out → Drop support for -moz-prefixes from cursor: zoom-in | zoom-out | grab | grabbing

Updated

4 years ago
Keywords: dev-doc-needed, site-compat

Comment 1

3 years ago
Unprefixed grab | grabbing are implemented in Bug 880672 (Firefox 27).

Besides, shouldn't bugs 772153 and 880672 be blocking this issue rather than is blocked by this?

Lastly, most web authors supply a fallback image or unprefixed zoom-in | zoom-out | grab | grabbing as a value for the cursor, so I think "<inset-arbitrary-number-here>" does not need to be a big number.
Posted the site compatibility doc: https://www.fxsitecompat.com/en-US/docs/2015/prefixed-cursor-types-will-be-removed/

Comment 3

8 months ago
I note that there are still active themes/addons on DXR which only use the -moz variant of these properties, some of which are still kept up-to-date. Is it worth removing the prefixed variants regardless, given the time it has been since the unprefixed versions (and deprecation notice) were issued?
(Reporter)

Comment 4

8 months ago
(In reply to Thomas Wisniewski from comment #3)

> Is it worth removing the prefixed variants

Yes!
https://hsivonen.fi/vendor-prefixes/

Blink woudn't drop any -webkit-prefix if they asked that question

Comment 5

8 months ago
Of course :)

But is it worth removing them *now*?

Comment 6

5 months ago
Created attachment 8814260 [details] [diff] [review]
879119-remove_support_for_moz-prefixed_cursor_values.diff

In the interests of moving this forward, here's a patch that removes the moz-prefixed cursors.

Try seems fine with it (discounting the scary-looking unrelated oranges there): https://treeherder.mozilla.org/#/jobs?repo=try&revision=b514efbfde11f7a22cd6d32ed793ddf3f3694178

I can also file an intent to unship on dev.platform, since I think that's standard procedure for any such removals?
Attachment #8814260 - Flags: review?(cam)
(In reply to Thomas Wisniewski from comment #6)
> I can also file an intent to unship on dev.platform, since I think that's
> standard procedure for any such removals?

Yes, I think that would be a great idea.  Is there a way you can determine the number of users of the addons that mention these cursor property values?  Searching for moz-zoom-in on DXR, it looks like nearly all uses are just setting that property, and so any breakage would be limited to the cursor not looking right, which is pretty minimal.  If you can determine that any of the addons have a lot of users, you could contact the authors to prompt them to update.
Comment on attachment 8814260 [details] [diff] [review]
879119-remove_support_for_moz-prefixed_cursor_values.diff

Review of attachment 8814260 [details] [diff] [review]:
-----------------------------------------------------------------

r=me though I'd probably wait until after you give a week or so after sending the intent email to see if you get any pushback.

::: layout/style/nsCSSProps.cpp
@@ +1269,5 @@
>    { eCSSKeyword_grab, NS_STYLE_CURSOR_GRAB },
>    { eCSSKeyword_grabbing, NS_STYLE_CURSOR_GRABBING },
>    { eCSSKeyword_zoom_in, NS_STYLE_CURSOR_ZOOM_IN },
>    { eCSSKeyword_zoom_out, NS_STYLE_CURSOR_ZOOM_OUT },
>    // -moz- prefixed vendor specific

You can remove this comment.
Attachment #8814260 - Flags: review?(cam) → review+

Comment 9

5 months ago
Intent to unship has been sent: https://groups.google.com/forum/#!topic/mozilla.dev.platform/JhnttZThqts

I'll try to study DXR soon to see who to outreach.

Comment 10

4 months ago
I haven't received any feedback on the intent to unship yet, so I'll try to do some DXR-hunting soon so we can land this removal.

Comment 11

4 months ago
Alright, here's a list of addons I found on DXR which use -moz-zoom-(in|out) or -moz-grab(bing), but not the standard version:

https://addons.mozilla.org/en-US/firefox/addon/a-bit-better-rtm/
https://addons.mozilla.org/en-US/firefox/addon/adnauseam/
https://addons.mozilla.org/en-US/firefox/addon/animatedtabs/
https://addons.mozilla.org/en-US/firefox/addon/antigameorigin-v6/
https://addons.mozilla.org/en-US/firefox/addon/better-hkgolden/
https://addons.mozilla.org/en-US/firefox/addon/browse-images/
https://addons.mozilla.org/en-US/firefox/addon/browserdeals-preisvergleich/
https://addons.mozilla.org/en-US/firefox/addon/clip-reference/
https://addons.mozilla.org/en-US/firefox/addon/complete-youtube-saver/
https://addons.mozilla.org/en-US/firefox/addon/cookies-manager-plus/
https://addons.mozilla.org/en-US/firefox/addon/dictionary-tooltip/
https://addons.mozilla.org/en-US/firefox/addon/drag-select-link-text/
https://addons.mozilla.org/en-US/firefox/addon/easyscreenshot/
https://addons.mozilla.org/en-US/firefox/addon/elegant-scrollbar-cursors/
https://addons.mozilla.org/en-US/firefox/addon/frf-helpers/
https://addons.mozilla.org/en-US/firefox/addon/funpin/
https://addons.mozilla.org/en-US/firefox/addon/geolocater/
https://addons.mozilla.org/en-US/firefox/addon/grab-and-drag/
https://addons.mozilla.org/en-US/firefox/addon/graphical-timeline/
https://addons.mozilla.org/en-US/firefox/addon/imagetools/
https://addons.mozilla.org/en-US/firefox/addon/interclue/
https://addons.mozilla.org/en-US/firefox/addon/lightbeam/
https://addons.mozilla.org/en-US/firefox/addon/location-guard/
https://addons.mozilla.org/en-US/firefox/addon/manga-reader/
https://addons.mozilla.org/en-US/firefox/addon/mfull/
https://addons.mozilla.org/en-US/firefox/addon/mkiosk/
https://addons.mozilla.org/en-US/firefox/addon/old-default-image-style/
https://addons.mozilla.org/en-US/firefox/addon/outwit-images/
https://addons.mozilla.org/en-US/firefox/addon/pajoohyar/
https://addons.mozilla.org/en-US/firefox/addon/pencil-prototyping/
https://addons.mozilla.org/en-US/firefox/addon/pixelzoomer/
https://addons.mozilla.org/en-US/firefox/addon/previewr/
https://addons.mozilla.org/en-US/firefox/addon/quick-viewers/
https://addons.mozilla.org/en-US/firefox/addon/serptrends-seo-extension/
https://addons.mozilla.org/en-US/firefox/addon/showcase/
https://addons.mozilla.org/en-US/firefox/addon/speed-dial/
https://addons.mozilla.org/en-US/firefox/addon/stylish-custom/
https://addons.mozilla.org/en-US/firefox/addon/synchronicity/
https://addons.mozilla.org/en-US/firefox/addon/tab-catalog/
https://addons.mozilla.org/en-US/firefox/addon/TitleBarTweaker/
https://addons.mozilla.org/en-US/firefox/addon/wiifox/
https://addons.mozilla.org/en-US/firefox/addon/yodiz-grab/
https://addons.mozilla.org/en-US/mobile/addon/classic-grey-theme/
https://addons.mozilla.org/en-US/seamonkey/addon/blue-essence-seamonkey-theme/
https://addons.mozilla.org/en-US/seamonkey/addon/gnomerunnerfd-revived
https://addons.mozilla.org/en-US/thunderbird/addon/display-contact-photo/
https://addons.mozilla.org/en-US/thunderbird/addon/gantt-view/
https://addons.mozilla.org/en-US/thunderbird/addon/quickfolders-tabbed-folders/
https://addons.mozilla.org/en-US/thunderbird/addon/threadvis/
https://addons.mozilla.org/en-US/thunderbird/addon/srb-lightning/
https://dxr.mozilla.org/addons/source/addons/10284
https://dxr.mozilla.org/addons/source/addons/425158
https://dxr.mozilla.org/addons/source/addons/593132
https://dxr.mozilla.org/addons/source/addons/626202
https://dxr.mozilla.org/addons/source/addons/648466
https://dxr.mozilla.org/addons/source/addons/658314
https://dxr.mozilla.org/addons/source/addons/683446
https://dxr.mozilla.org/addons/source/addons/687782
https://dxr.mozilla.org/addons/source/addons/712774
https://dxr.mozilla.org/addons/source/addons/731689
https://dxr.mozilla.org/addons/source/addons/740949
https://dxr.mozilla.org/addons/source/addons/747619
https://dxr.mozilla.org/addons/source/addons/747775
https://dxr.mozilla.org/addons/source/addons/751348
https://dxr.mozilla.org/addons/source/addons/754868
http://pali.sirimangalo.org/
http://tools.seobook.com/firefox/seo-for-firefox.html
http://www.kwiclick.com/support.html
http://www.pagetweak.com/
https://support.twenga-solutions.com/hc/en-gb
https://www.zotero.org/download/

Also, Firebug will have to decide which versions they want to update (if any).

The defunct CoolPreviews addon seems to still have quite a few users as well, with quite a few variants and clones in DXR that don't seem to be on AMO. I'm not sure whether we can reach out to all of those users, but I could do another DXR search for those addons if we'd like to try.

There were also a few Chrome extensions that multiple users seem to have "Foxified", which we might want to reach out to as well:
- Plus for Trello
- OCRNow for FENXT
- Black Menu for Google

I can try to whittle this list down to just the most popular addons, but I'm not sure what the best course of action is for this sort of thing. Is there anyone on the addons team I should speak with about this, heycam?
Flags: needinfo?(cam)

Updated

4 months ago
Keywords: addon-compat
You need to log in before you can comment on or make changes to this bug.