879350 - Disable Android Beam and wallpaper support on Firefox 23

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

Product decided to push back the "add new permissions" release to Fx24, so we need to disable the android beam and wallpaper support in Fx 23.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch for aurora

This patch is for aurora (Fx23) only.

Comment 2

[:Margaret Leibovic]

Comment on attachment 758024 [details] [diff] [review]
Patch for aurora

Review of attachment 758024 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/confvars.sh
@@ +19,5 @@
>  # Enable getUserMedia
>  MOZ_MEDIA_NAVIGATOR=1
>  
>  # Enable SET_WALLPAPER permission
> +MOZ_ANDROID_WALLPAPER=0

This doesn't work. It needs to be MOZ_ANDROID_WALLPAPER= (empty). See bug 844935 comment 21. Also, I think we need to make sure to disable tests when landing this.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Thanks for catching those problems, margaret. I've pushed a new version to try with the corrected confvars and test hacked to see if it's good: https://tbpl.mozilla.org/?tree=Try&rev=b334b7a561c2

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch for aurora v2

Try build at https://tbpl.mozilla.org/?tree=Try&rev=b334b7a561c2 is clean, and installing that build on my N4 and looking at the permissions shows that it doesn't have wallpaper or NFC permissions.

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 758596 [details] [diff] [review]
Patch for aurora v2

[Approval Request Comment]
Bug caused by (feature/regressing bug #): product decision
User impact if declined: When 23 goes to beta automatic updates will be disabled because of new permissions. And then it will happen again when 24 goes to beta
Testing completed (on m-c, etc.): locally
Risk to taking this patch (and alternatives if risky): low risk, mobile only
String or IDL/UUID changes made by this patch: none

Comment 6

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 758596 [details] [diff] [review]
Patch for aurora v2

Please update status to 'disabled' once this lands

Comment 7

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/releases/mozilla-aurora/rev/be1ac1f1d04f