Closed Bug 879369 Opened 11 years ago Closed 11 years ago

NFC permission in android manifest should set android:required=false

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
All
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 24

People

(Reporter: kats, Assigned: kats)

References

Details

Attachments

(1 file)

Patch
1.25 KB, patch
blassey
: review+
Details | Diff | Splinter Review 
Looks like android:required on a uses-feature element in the manifest defaults to true, so currently the play store limits us to NFC-enabled devices.
tracking-fennec: --- → ?
Attached patch Patch — — Splinter Review 

        Attachment #758051 -
        Flags: review?(blassey.bugs)

        Attachment #758051 -
        Flags: review?(blassey.bugs) → review+

    
    

    
  
https://hg.mozilla.org/integration/mozilla-inbound/rev/c3dc266f985e

This shouldn't need uplifting to aurora because of bug 879350. However if that changes to a wontfix then this will need uplifting.

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/c3dc266f985e
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 24
tracking-fennec: ? → ---
Product: Firefox for Android → Firefox for Android Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: