879879 - Deploy performance toolkit and mozprofilerprobe.mof

Status: RESOLVED FIXED

(Infrastructure & Operations :: RelOps: General, task)

Description

[Armen [:armenzg]]

It seems that we missed this when setting the win7 machines up.
I assume it is mea culpa. The xperf job is only running on a handful of branches and we probably missed it when testing on Cedar.
We disabled on the rev3 machines and it took a while to notice.


Would you please be able to deploy this to one of the Win7 machines? I will then test it to make sure it fixes the issue. These are the same steps we followed for the rev3 minis:
* Install http://www.microsoft.com/en-us/download/details.aspx?id=3138
* Install C:\Program Files\Microsoft SDKs\Windows\v7.1\Redist\Windows\wpt_x86.msi

If you want I can follow these steps manually on one of the machines.
I assume it should work the same way.

The original work was done on bug 640829 and here are the mdn instructions:
https://developer.mozilla.org/en-US/docs/Performance/Profiling_with_Xperf?redirectlocale=en-US&redirectslug=Profiling_with_Xperf
#############
For all versions, the tools are part of the latest Windows 7 SDK (SDK Version 7.1).  Use the web installer to install at least the "Win32 Development Tools".  Once the SDK installed, execute either wpt_x86.msi or wpt_x64.msi in the Redist/Windows Performance Toolkit folder of the SDK's install location (typically Program Files/Microsoft SDKs/Windows/v7.1/Redist/Windows Performance Toolkit) to actually install the Windows Performance Toolkit tools.
It might already be installed by the windows SDK. Check if C:\Program Files\Microsoft Windows Performance Toolkit already exists.
For 64-bit Windows 7 or Vista, you'll need to do a registry tweak and then restart to enable stack walking:

REG ADD "HKLM\System\CurrentControlSet\Control\Session Manager\Memory Management" -v DisablePagingExecutive -d 0x1 -t REG_DWORD -f
#############


https://wiki.mozilla.org/ReferencePlatforms/Test/Win7#Xperf

Comment 1

[Q]

Xperf is now installing on all the win 7 ix slave machines with the correct 7.1 sdk version. This should be checked and verified on the releng side tomorrow morning to make sure pathing etc is correct..

Comment 2

[Ed Morley [:emorley]]

https://tbpl.mozilla.org/php/getParsedLog.php?id=23852409&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=23852128&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=23851124&tree=Mozilla-Inbound

Comment 3

[Armen [:armenzg]]

Hi Q, this did a part of it.
For some reason, the instructions were broken into two parts and I've forgotten one more thing to deploy.

From bug 778856 and https://wiki.mozilla.org/ReferencePlatforms/Test/Win7#Xperf_and_mozprofilerprobe.mof

* ssh as cltbld and download mozprofilerprobe.mof:
 wget http://hg.mozilla.org/mozilla-central/raw-file/360ab7771e27/toolkit/components/startup/mozprofilerprobe.mof
* VNC, use "Run as Administrator" to start a command prompt and run the following:
 mofcomp c:\Users\cltbld\mozprofilerprobe.mof

Comment 4

[Q]

On it!

Comment 5

[Q]

File and command going out now.

Comment 6

[Phil Ringnalda (:philor)]

Not sure whether I'm impatient, that didn't work, or there's something else missing, but every xperf run is still failing in what looks to me like the same way.

Comment 7

[Q]

what is the appropriate way to test if the mof file compile is correct?

Comment 8

[Joel Maher ( :jmaher ) (UTC -8)]

there is no way to verify this other than running xperf and firefox to get the command.   I believe this is something that needs to be done manually, at least that is what I remember from last time.

Comment 9

[Armen [:armenzg]]

https://tbpl.mozilla.org/php/getParsedLog.php?id=23900099&tree=Mozilla-Inbound&full=1#error0

I see this in the logs:
> c:/Program Files/Microsoft Windows Performance Toolkit/xperf: error: NT Kernel Logger: The instance name passed was not recognized as valid by a WMI data provider. (0x1069).
> c:/Program Files/Microsoft Windows Performance Toolkit/xperf: error: talos_ses: The instance name passed was not recognized as valid by a WMI data provider. (0x1069).
> c:/Program Files/Microsoft Windows Performance Toolkit/xperf: error: test.etl: The specified path is invalid. (0xa1).
> c:/Program Files/Microsoft Windows Performance Toolkit/xperf: error: test.etl: The specified path is invalid. (0x800700a1).
> etlparser: in readfile: test.etl.csv

and many of these:
> No results collected for: ...

Comment 10

[Armen [:armenzg]]

We don't run cltbld as Administrator (bug 881771).
The work of this bug (deploying what we thought we needed) is completed. We can follow up the next issue there.

Comment 11

[Chris Cooper [:coop] (he/him)]

Do we still need to verify that this deployment is working? I think https://bugzilla.mozilla.org/show_bug.cgi?id=880273#c3 is still blocked on this but want to make sure.

Comment 12

[Q]

From everything I gather xperf tests running after the file deployments in this bug and the permission changes in  bug 881771.

Comment 13

[Joel Maher ( :jmaher ) (UTC -8)]

xperf tests have been working, thanks for following up on this bug.