880087 - [socorro-crashstats] BadStatusCodeError: 500 in middleware

Status: VERIFIED FIXED

(Socorro Graveyard :: Middleware, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

BadStatusCodeError: 500: on: http://socorro-mware-stage-zlb.webapp.phx1.mozilla.com/bpapi/signaturesummary/report_type/distinct_install/signature/EMPTY%3A%20no%20crashing%20thread%20identified%3B%20corrupt%20dump/start_date/2013-06-03T00%3A38%3A10/end_date/2013-06-06T00%3A38%3A10/

when hitting https://crash-stats-django.allizom.org/signature_summary/json_data?range_value=3&range_unit=days&signature=EMPTY%3A+no+crashing+thread+identified%3B+corrupt+dump&date=2013-06-06

Stacktrace (most recent call last):

  File "django/core/handlers/base.py", line 111, in get_response
    response = callback(request, *callback_args, **callback_kwargs)
  File "crashstats/crashstats/utils.py", line 39, in wrapper
    response = f(request, *args, **kw)
  File "crashstats/crashstats/views.py", line 1557, in signature_summary
    end_date=end_date,
  File "crashstats/crashstats/models.py", line 234, in get
    return self.fetch(url % params, expect_json=expect_json)
  File "crashstats/crashstats/models.py", line 139, in fetch
    raise BadStatusCodeError('%s: on: %s' % (resp.status_code, url))

Comment 1

[[DEACTIVATED] Adrian Gaudebert]

Brandon, was this introduced with bug 838251?

Comment 2

[Brandon Savage [:brandon]]

This works for me on stage.

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

This is an individual report, and likely to change, given on the exception; check out https://errormill.mozilla.org/webtools/socorro-crashstats-stage/ for the full list of these 500 (and other HTTP status-code errors).

Comment 4

[Laura Thomson :laura]

Blocks the switch to PHP - rhelmer can you take a look?

Comment 5

[Robert Helmer [:rhelmer]]

This looks very similar to bug 880087 - running it locally:

RequiredParameterError at /signature_summary/json_data: versions

If you modify the URL in comment 0 to add a "version" param (the view takes it as "version" for backwards-compat, and sends it to the model/mware as "versions") you can see that it works:

https://crash-stats-django.allizom.org/signature_summary/json_data?range_value=3&range_unit=days&signature=EMPTY%3A+no+crashing+thread+identified%3B+corrupt+dump&date=2013-06-06&version=ALL:ALL

Comment 7

[Robert Helmer [:rhelmer]]

I compared the behavior of the old site, and it turns out /report/list should support being called with no version parameter. In this case both should assume this means "ALL".

r? https://github.com/mozilla/socorro-crashstats/pull/392

Comment 8

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro-crashstats

https://github.com/mozilla/socorro-crashstats/commit/557b24fcd39b80ba400e17727c83be7011ad7762
fixes bug 880087 - versions should be optional for /report/list and signature summary

https://github.com/mozilla/socorro-crashstats/commit/c2d7809c4880d42b03eb6dcc2392000dc4312e81
Merge pull request #392 from rhelmer/bug880087-query-report-list-missing-version-param

fixes bug 880087 - versions should be optional for /report/list and sign...

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://crash-stats-django.allizom.org/signature_summary/json_data?range_value=3&range_unit=days&signature=EMPTY%3A+no+crashing+thread+identified%3B+corrupt+dump&date=2013-06-06.

Will also test around.

Comment 10

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Post-fix screenshot