880265 - Remove AudioBufferSourceNode.gain

Status: RESOLVED FIXED

(Core :: Web Audio, defect)

Description

[(no longer active)]

This is probably just a matter of reverting bug 871201.

Comment 1

[Sankha Narayan Guria [:sankha]]

Attachment: patch

Comment 2

[(no longer active)]

Comment on attachment 759226 [details] [diff] [review]
patch

Review of attachment 759226 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great!  r=me with the below comments fixed.

::: content/media/webaudio/AudioBufferSourceNode.cpp
@@ +85,2 @@
>      default:
> +      NS_ERROR("Bad GainNodeEngine TimelineParameter");

Please revert this line.

::: content/media/webaudio/test/Makefile.in
@@ -54,5 @@
>    test_currentTime.html \
>    test_delayNode.html \
>    test_delayNodeSmallMaxDelay.html \
>    test_delayNodeWithGain.html \
> -  test_delayNodeWithGainAlternate.html \

You forgot to hg rm this file.

Comment 3

[Sankha Narayan Guria [:sankha]]

Attachment: final patch

Comment 4

[(no longer active)]

Comment on attachment 759885 [details] [diff] [review]
final patch

Review of attachment 759885 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/media/webaudio/AudioBufferSourceNode.cpp
@@ +85,2 @@
>      default:
> +      NS_ERROR("Bad TimelineParameter");

I meant that this line shouldn't change, but I'll fix it when landing.

Comment 5

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7569629f5b3d

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/7569629f5b3d