Closed Bug 880265 Opened 7 years ago Closed 7 years ago

Remove AudioBufferSourceNode.gain

Categories

(Core :: Web Audio, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla24

People

(Reporter: ehsan, Assigned: sankha)

References

Details

Attachments

(1 file, 1 obsolete file)

This is probably just a matter of reverting bug 871201.
Assignee: ehsan → sankha93
Attached patch patch (obsolete) — Splinter Review
Attachment #759226 - Flags: review?(ehsan)
Comment on attachment 759226 [details] [diff] [review]
patch

Review of attachment 759226 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great!  r=me with the below comments fixed.

::: content/media/webaudio/AudioBufferSourceNode.cpp
@@ +85,2 @@
>      default:
> +      NS_ERROR("Bad GainNodeEngine TimelineParameter");

Please revert this line.

::: content/media/webaudio/test/Makefile.in
@@ -54,5 @@
>    test_currentTime.html \
>    test_delayNode.html \
>    test_delayNodeSmallMaxDelay.html \
>    test_delayNodeWithGain.html \
> -  test_delayNodeWithGainAlternate.html \

You forgot to hg rm this file.
Attachment #759226 - Flags: review?(ehsan) → review+
Attached patch final patchSplinter Review
Attachment #759226 - Attachment is obsolete: true
Attachment #759885 - Flags: review?(ehsan)
Comment on attachment 759885 [details] [diff] [review]
final patch

Review of attachment 759885 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/media/webaudio/AudioBufferSourceNode.cpp
@@ +85,2 @@
>      default:
> +      NS_ERROR("Bad TimelineParameter");

I meant that this line shouldn't change, but I'll fix it when landing.
Attachment #759885 - Flags: review?(ehsan) → review+
https://hg.mozilla.org/mozilla-central/rev/7569629f5b3d
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.