880327 - [leo-pre-iot-br] SIM contacts not imported (app locked)

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[David Palomino [:dpalomino]]

Attachment: logcat

Device: leo
buildid: 20130529095707 (brazilian variant)

With a SIM contact from Vivo (with 248 contacts), importing contacts from SIM card is locked in 9/248. 

We don't have details about the 9th and 10th contacts yet. We'll try to get those. 

Adding logs. 

Nominating for leo?

Thanks, 
David

Comment 1

[David Palomino [:dpalomino]]

Attachment: radio logs

Comment 2

[Gregor Wagner [:gwagner]]

E/GeckoConsole(  147): [JavaScript Error: "aContact.properties.tel[(intermediate value)].value is undefined" {file: "resource://gre/modules/ContactDB.jsm" line: 460}]

Hm I thought we already fixed this.
Reuben?

Comment 3

[Gregor Wagner [:gwagner]]

Should be a dup of bug 870148.

Comment 4

[Reuben Morais [:reuben]]

(In reply to Gregor Wagner [:gwagner] from comment #2)
> E/GeckoConsole(  147): [JavaScript Error:
> "aContact.properties.tel[(intermediate value)].value is undefined" {file:
> "resource://gre/modules/ContactDB.jsm" line: 460}]
> 
> Hm I thought we already fixed this.
> Reuben?

Yep. Bug 870148 landed in b2g18 on 2013-05-22, so it should be included:

(Ryan VanderMeulen [:RyanVM] from comment #12)
> https://hg.mozilla.org/releases/mozilla-b2g18/rev/0684deeae204
> https://hg.mozilla.org/releases/mozilla-b2g18/rev/a5c3ba754674
> 
> The second patch required a little tweaking to apply, FWIW.

You'll notice that the tweaking actually only landed part of the patch (I <3 b2g18).

I landed a followup fixing that, but the line number in the logs is what surprises me, that should never fail:

459            if (field == "tel" && aContact.properties[field][i].value) {
460              let number = aContact.properties.tel[i].value.toString();

Comment 5

[Reuben Morais [:reuben]]

needinfo? on David for the contacts' details.

Comment 6

[David Palomino [:dpalomino]]

Hi!

I'm afraid there is no SIM card reader here :(

Can we get this info from the logs?

Thanks!
David

Comment 7

[Reuben Morais [:reuben]]

Attachment: Enable debugging

Well, yes, with a custom Gecko build. Please reproduce with this patch and attach the logs.

Comment 8

[Lukas Blakk [:lsblakk] use ?needinfo]

Blocks user's ability to import contact from SIM card, blocker for v1.1

Comment 9

[David Palomino [:dpalomino]]

Hi, 

In this case, the build is generated by the vendor, and it's not so easy to apply the patch. 

@jinyoong, can I ask for your help here? Is it possible to generate a build for getting this info? 

Thks!
David

Comment 10

[Reuben Morais [:reuben]]

David, is that person CC'ed in this bug?

Comment 11

[Alex Keybl [:akeybl]]

Please set this back to nominate if we've only had one repro case.

Comment 12

[jongsoo.oh]

The patch is included in latest leo version?
Please check it.

Comment 13

[David Palomino [:dpalomino]]

Hi, 

Repro rate was 100%, I think we should study this further. It's a blocking issue for the carrier. 

SIM card is in Sao Paulo, and we have no access to it as we're based in Madrid. I'd ask to vendor colleagues to repeat the test as they have some people working in Sao Paulo. 

Thanks, 
David

Comment 14

[Gregor Wagner [:gwagner]]

I guess the best way forward here is to add the option to enable the debug output from the settings app.

Comment 15

[Wayne Chang [:wchang]]

Jongsoo, can you check if the bug has been reproduced on a software with the debug enabling patch and provide some debug logs?

Comment 16

[Leo]

This bug cann't reproduce in the latest leo device version.

Comment 17

[bhavana bajaj [:bajaj]]

Given this is not reproducible anymore per comment# 16, removing it from the blocking list.

Comment 18

[Leo]

This issue does not reproduce in the latest version.

Comment 19

[David Palomino [:dpalomino]]

Thanks, good news. Have you checked with the same SIM card described originally? Take into account that this was not reproducible with all sim cards.

Comment 20

[Gregor Wagner [:gwagner]]

Close the bug based on comment 18.

Comment 21

[David Palomino [:dpalomino]]

Hi, 

Can you please confirm if test has been done with the SIM card where was originally reproduced by CPQD?

ni: leo

thks!

Comment 22

[Leo]

(In reply to David Palomino [:dpv] from comment #21)
> Hi, 

Can you please confirm if test has been done with the SIM card where
> was originally reproduced by CPQD?

ni: leo

thks!

Hi,

This issue is no longer reproducible on V08o with originally reproduced sim card.
thanks