883318 - HP hosts always stop HP utilities

Status: RESOLVED FIXED

(Infrastructure & Operations :: RelOps: General, task)

Description

[Dustin J. Mitchell [:dustin] (he/him)]

We decided a while back that we don't want these utilities running on HP's, since they tend to crash the system (thanks, HP!).  However, on every puppet run, puppet tries to stop them again.

Why's it doing this?  How do we make it stop?

[[e-mail] ~]# puppet agent --test
Info: Retrieving plugin
Info: Loading facts in /var/lib/puppet/lib/facter/vmwaretools_version.rb
Info: Loading facts in /var/lib/puppet/lib/facter/root_home.rb
Info: Loading facts in /var/lib/puppet/lib/facter/num_masters.rb
Info: Loading facts in /var/lib/puppet/lib/facter/pe_version.rb
Info: Loading facts in /var/lib/puppet/lib/facter/puppet_vardir.rb
Info: Loading facts in /var/lib/puppet/lib/facter/facter_dot_d.rb
Info: Caching catalog for relabs02.build.mtv1.mozilla.com
Info: Applying configuration version '6ff0ee22590b'
Notice: /Stage[main]/Hardware/Service[hp-asrd]/ensure: ensure changed 'running' to 'stopped'
Notice: /Stage[main]/Hardware/Service[hp-health]/ensure: ensure changed 'running' to 'stopped'
Notice: Finished catalog run in 6.27 seconds
[[e-mail] ~]#

You can use relabs02 to test this out.  I'll help out in irc with the other details of writing and testing a puppetagain patch.

Comment 1

[Justin Wood (:Callek)]

[[e-mail] tmp-puppet]# cat /etc/cron.d/hp-health
# /etc/cron.d/hp-health: crontab entries for the hp-health package

SHELL=/bin/sh
PATH=/usr/local/sbin:/usr/local/bin:/sbin:/bin:/usr/sbin:/usr/bin

*/5 * * * *    root   /opt/hp/hp-health/bin/check-for-restart-requests


=====

by skimming that script it sounds like that is [a] the culprit.

Comment 2

[Jake Watkins [:dividehex]]

This module is also incompatible with ubuntu.  I vote it gets ripped out altogether.

err: Could not retrieve catalog from remote server: Error 400 on SERVER: cannot install on Ubuntu at /etc/puppet/environments/test/modules/packages/manifests/hp_health.pp:19 on node relabs07.build.mtv1.mozilla.com

Comment 3

[Dustin J. Mitchell [:dustin] (he/him)]

make it so :)

Comment 4

[Dustin J. Mitchell [:dustin] (he/him)]

The cron script isn't a problem, but it's worth putting an ensure => absent in there at least temporarily will help clean up the existing systems (seamonkey, relabs, and the HP builders in scl1) back into a consistent state.  It'd be fine to put that in the node defs for those hosts, since it's temporary.

Comment 5

[Jake Watkins [:dividehex]]

Attachment: Set hp-health to ensure => absent

This was tested on relabs08(centos).  We can probably remove it all together in a week or so.

Comment 6

[Justin Wood (:Callek)]

Comment on attachment 766970 [details] [diff] [review]
Set hp-health to ensure => absent

Review of attachment 766970 [details] [diff] [review]:
-----------------------------------------------------------------

Since its only temporary this is ok. In a perfect world I'd personally prefer removing hp_health.pp and instead tweaking the init.pp here to do the absent. Since having a packages::* that *removes* a package rather than adds it feels strange.

That said, please point to this bug in each of those "removed soon" comments.

Comment 7

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 766970 [details] [diff] [review]
Set hp-health to ensure => absent

Review of attachment 766970 [details] [diff] [review]:
-----------------------------------------------------------------

I don't see a "smooth" way to ensure a package is absent, which is part of why I wanted to just delete these manifests and pretend it wasn't a problem.  But this looks fine.

Comment 8

[Jake Watkins [:dividehex]]

Comment on attachment 766970 [details] [diff] [review]
Set hp-health to ensure => absent

landed.

I'll remove it completely by the end of the week

Comment 9

[Jake Watkins [:dividehex]]

Attachment: Removes hp-health from manifests completely

Let schedule this to land on Tuesday 7/2 (if r+ by then)

[[e-mail] test]$ hg status
M modules/hardware/manifests/init.pp
R modules/packages/manifests/hp_health.pp

Comment 10

[Jake Watkins [:dividehex]]

Comment on attachment 768451 [details] [diff] [review]
Removes hp-health from manifests completely

landed