Closed
Bug 883843
Opened 13 years ago
Closed 13 years ago
[webvtt] Remove extraneous QI implementation line for HTMLTrackElement
Categories
(Core :: Audio/Video, defect)
Core
Audio/Video
Tracking
()
RESOLVED
FIXED
mozilla24
People
(Reporter: reyre, Assigned: reyre)
References
Details
Attachments
(1 file, 1 obsolete file)
|
961 bytes,
patch
|
Details | Diff | Splinter Review |
When fixing the QI implementation for HTMLTrackElement in bug 882817 we accidentally added an unnecessary line to it. See bug 882817 comment 5.
| Assignee | ||
Updated•13 years ago
|
| Assignee | ||
Updated•13 years ago
|
Assignee: nobody → rick.eyre
QA Contact: rick.eyre
| Assignee | ||
Comment 1•13 years ago
|
||
Attachment #763600 -
Flags: review?(peterv)
Updated•13 years ago
|
Attachment #763600 -
Flags: review?(peterv) → review+
| Assignee | ||
Comment 2•13 years ago
|
||
Just updated the commit message to reflect Peter's r+
Carrying forward r=peterv
Attachment #763600 -
Attachment is obsolete: true
| Assignee | ||
Comment 3•13 years ago
|
||
| Assignee | ||
Comment 4•13 years ago
|
||
Please note we're expecting a failure for mochitest 2 on android because of bug 884884. That code isn't actually in m-c yet, but only in the try server as I pushed it there earlier.
Push looks green other then that so I'm going to mark for checkin now.
Keywords: checkin-needed
Comment 5•13 years ago
|
||
Flags: in-testsuite-
Keywords: checkin-needed
Comment 6•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in
before you can comment on or make changes to this bug.
Description
•