The default bug view has changed. See this FAQ.

[webvtt] Remove extraneous QI implementation line for HTMLTrackElement

RESOLVED FIXED in mozilla24

Status

()

Core
Audio/Video
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: reyre, Assigned: reyre)

Tracking

(Blocks: 1 bug)

Trunk
mozilla24
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

4 years ago
When fixing the QI implementation for HTMLTrackElement in bug 882817 we accidentally added an unnecessary line to it. See bug 882817 comment 5.
(Assignee)

Updated

4 years ago
Blocks: 629350
Status: NEW → ASSIGNED
QA Contact: rick.eyre
(Assignee)

Updated

4 years ago
Assignee: nobody → rick.eyre
QA Contact: rick.eyre
(Assignee)

Comment 1

4 years ago
Created attachment 763600 [details] [diff] [review]
v1: Remove extraneous QI line from HTMLTrackElement
Attachment #763600 - Flags: review?(peterv)
Attachment #763600 - Flags: review?(peterv) → review+
(Assignee)

Comment 2

4 years ago
Created attachment 764717 [details] [diff] [review]
v1: Remove extraneous QI line from HTMLTrackElement r=peterv

Just updated the commit message to reflect Peter's r+

Carrying forward r=peterv
Attachment #763600 - Attachment is obsolete: true
(Assignee)

Comment 3

4 years ago
Try push: https://tbpl.mozilla.org/?tree=Try&rev=0e3f9a6a0100
(Assignee)

Comment 4

4 years ago
Please note we're expecting a failure for mochitest 2 on android because of bug 884884. That code isn't actually in m-c yet, but only in the try server as I pushed it there earlier.

Push looks green other then that so I'm going to mark for checkin now.
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/5446d7cc7ea0
Flags: in-testsuite-
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/5446d7cc7ea0
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.