883933 - Enable "Other regions" checkbox for paid apps

Status: VERIFIED FIXED

(Marketplace Graveyard :: Developer Pages, defect, P2)

Description

[krupa raj[:krupa]]

steps to reproduce:
1. Load https://marketplace-dev.allizom.org/developers/app/test-app-boar39/payments/
2. Notice that for paid apps, the "Other regions" checkbox is disabled by default

expected behavior:
"Other regions" is enabled for paid apps and when we have new regions which support the app's pricetier, we automatically have those regions selected.



observed behavior:
"other regions" is disabled by default which i think was by design. We need to revisit that decision now

Comment 1

[Stuart Colville [:muffinresearch]]

Removing the worldwide checkbox from being disabled should be easy enough, at the same time will check that exclusions do the right thing in the case of new regions.

Comment 2

[Stuart Colville [:muffinresearch]]

Fwiw: notifying the developer on changes to tiers is covered explicitly by bug 882798 "What happens when tiers change"

Comment 3

[Stuart Colville [:muffinresearch]]

r? https://github.com/mozilla/zamboni/pull/868

Comment 4

[Stuart Colville [:muffinresearch]]

I've put https://github.com/mozilla/zamboni/pull/868 on hold for now so we can work out what's needed wrt to splitting out other from worldwide as they are currently intertwined.

Comment 5

[Stuart Colville [:muffinresearch]]

So we need to decide on what we're doing with splitting out worldwide and other concepts as they're currently tied together and it sounds like (from the discussion on irc) that we need to make them separate.

So what we need to work out is what are the steps to dealing with splitting out the two concepts.

Open questions are:

 * What does worldwide mean to free apps
 * What does worldwide as a region mean for paid apps? Is it relevant for paid apps?
 * What would we need to do to migrate from the combined worldwide other to a separate exlusion for worldwide and other.

Should we have a discussion about this? Or can we work this out in the bug?

CC'ing cvan as he knows about the notification piece to this which would be affected should this change.

Comment 6

[Stuart Colville [:muffinresearch]]

Ok after a call we've decided on storing the flag for "enable other regions" separately to the worldwide id for paid apps.

This will mean that it's not going to inadvertently expose apps in worldwide regions if they shouldn't be and it's a nicer separation of logic.

This will be split out into two branches. I'll add the model bits first which will unblock bug 896034 and then I'll deal with the form separately.

Comment 7

[Stuart Colville [:muffinresearch]]

https://github.com/mozilla/zamboni/commit/8147463a793daa8735bc46df9bf36d39ab590353

Comment 8

[krupa raj[:krupa]]

we now have a "Enable new regions" checkbox which is independent of the pricetier