884957 - Need updated postgresql92-json_enhancements RPM

Status: RESOLVED FIXED

(Infrastructure & Operations Graveyard :: WebOps: Other, task)

Description

[Selena Deckelmann :selenamarie :selena]

There is a bug in the released json_enhancements module that causes any searches of Socorro JSON containing unicode characters to fail.

Latest code is at: https://bitbucket.org/qooleot/json_enhancements

Can we get the RPM updated with current master at commit 9596b5ac9d50a98ab6ab00f51a92afd37d9f44ea?

Comment 1

[Eric Zounes [:zounese]]

(In reply to Selena Deckelmann :selenamarie :selena from comment #0)
> There is a bug in the released json_enhancements module that causes any
> searches of Socorro JSON containing unicode characters to fail.
> 
> Latest code is at: https://bitbucket.org/qooleot/json_enhancements
> 
> Can we get the RPM updated with current master at commit
> 9596b5ac9d50a98ab6ab00f51a92afd37d9f44ea?

Hey there,

I'm the new WebOps intern, and this will be my first bug. So, please bear with me. I'm going through the rpm build process now. Thanks! :) 

-zounese

Comment 2

[Selena Deckelmann :selenamarie :selena]

(In reply to Eric Zounes :[zounese] from comment #1)
> (In reply to Selena Deckelmann :selenamarie :selena from comment #0)
> > There is a bug in the released json_enhancements module that causes any
> > searches of Socorro JSON containing unicode characters to fail.
> > 
> > Latest code is at: https://bitbucket.org/qooleot/json_enhancements
> > 
> > Can we get the RPM updated with current master at commit
> > 9596b5ac9d50a98ab6ab00f51a92afd37d9f44ea?
> 
> Hey there,
> 
> I'm the new WebOps intern, and this will be my first bug. So, please bear
> with me. I'm going through the rpm build process now. Thanks! :) 
> 
> -zounese

Cool!  Thanks a bunch.  If it's any help, there's https://bugzilla.mozilla.org/show_bug.cgi?id=880744#c5 and a reference to fpm: https://github.com/jordansissel/fpm

-selena

Comment 3

[Selena Deckelmann :selenamarie :selena]

Let me know if there's anything I can help with today!  I'm happy to explain anything to get this going. We've got a release blocked on this ticket.

Comment 4

[Selena Deckelmann :selenamarie :selena]

Also! A new release was cut for http://www.pgxn.org/dist/json_enhancements/ -- which should make the package creation significantly easier!

Comment 5

[Selena Deckelmann :selenamarie :selena]

This issue is blocking a goal and a release, so I'm upping the importance per Laura.

Comment 6

[Selena Deckelmann :selenamarie :selena]

So, I see a new package is available for json_enhancements, but it looks like v1.0.0 was installed: 

breakpad:5432# select * from pg_extension where extname ~ 'json';
      extname      | extowner | extnamespace | extrelocatable | extversion | extconfig | extcondition 
-------------------+----------+--------------+----------------+------------+-----------+--------------
 json_enhancements |       10 |         2200 | t              | 1.0.0      |           | 
(1 row)
[[e-mail]1 extension]$ ls -la json* 
-rw-r--r-- 1 root root 3838 Jun  7 17:07 json_enhancements--1.0.0.sql
-rw-r--r-- 1 root root  190 Jun  7 17:07 json_enhancements.control

I don't see the 1.0.1 stuff!

-rwxr-xr-x 1 root root 208726 Jun  7 17:07 json_enhancements.so

Comment 7

[Selena Deckelmann :selenamarie :selena]

Ah! Maybe the new version just isn't available yet? 

[[e-mail]1 extension]$ rpm -qa postgresql92-json_enhancements
postgresql92-json_enhancements-1.0-1.x86_64

[[e-mail]1 extension]$ rpm -qi postgresql92-json_enhancements-1.0-1.x86_64
Name        : postgresql92-json_enhancements  Relocations: /usr/pgsql-9.2 
Version     : 1.0                               Vendor: [e-mail]
Release     : 1                             Build Date: Fri 07 Jun 2013 05:07:33 PM PDT
Install Date: Tue 11 Jun 2013 01:37:34 PM PDT      Build Host: jenkins-services1.dmz.phx1.mozilla.com
Group       : default                       Source RPM: postgresql92-json_enhancements-1.0-1.src.rpm
Size        : 212754                           License: unknown
Signature   : (none)
Packager    : <[e-mail]>
URL         : http://example.com/no-uri-given
Summary     : no description given
Description :
no description given


[[e-mail]1 ~]# yum install postgresql92-json_enhancements
Loaded plugins: downloadonly, rhnplugin, security
This system is receiving updates from RHN Classic or RHN Satellite.
Setting up Install Process
Package postgresql92-json_enhancements-1.0-1.x86_64 already installed and latest version
Nothing to do

Comment 8

[Eric Zounes [:zounese]]

(In reply to Selena Deckelmann :selenamarie :selena from comment #7)
> Ah! Maybe the new version just isn't available yet? 
> 
> [[e-mail]1 extension]$ rpm -qa
> postgresql92-json_enhancements
> postgresql92-json_enhancements-1.0-1.x86_64
> 
> [[e-mail]1 extension]$ rpm -qi
> postgresql92-json_enhancements-1.0-1.x86_64
> Name        : postgresql92-json_enhancements  Relocations: /usr/pgsql-9.2 
> Version     : 1.0                               Vendor:
> [e-mail]
> Release     : 1                             Build Date: Fri 07 Jun 2013
> 05:07:33 PM PDT
> Install Date: Tue 11 Jun 2013 01:37:34 PM PDT      Build Host:
> jenkins-services1.dmz.phx1.mozilla.com
> Group       : default                       Source RPM:
> postgresql92-json_enhancements-1.0-1.src.rpm
> Size        : 212754                           License: unknown
> Signature   : (none)
> Packager    : <[e-mail]>
> URL         : http://example.com/no-uri-given
> Summary     : no description given
> Description :
> no description given
> 
> 
> [[e-mail]1 ~]# yum install postgresql92-json_enhancements
> Loaded plugins: downloadonly, rhnplugin, security
> This system is receiving updates from RHN Classic or RHN Satellite.
> Setting up Install Process
> Package postgresql92-json_enhancements-1.0-1.x86_64 already installed and
> latest version
> Nothing to do

Sorry to keep you waiting. The rpm is up in our repo now. Here's the output from yum info:

Installed Packages
Name        : postgresql92-json_enhancements
Arch        : x86_64
Version     : 1.0.2
Release     : 1
Size        : 210 k
Repo        : installed
From repo   : mozilla
Summary     : no description given
URL         : http://example.com/no-uri-given
License     : unknown
Description : no description given

If there are any issues with it, feel free to ping me. It was a tricky build. :) 

-zounese

Comment 9

[Selena Deckelmann :selenamarie :selena]

Thanks!

Unfortunately, we have a problem: 

breakpad:5432# create extension json_enhancements; 
ERROR:  could not open extension control file "/usr/pgsql-9.2/share/extension/json_enhancements.control": No such file or directory
Time: 9.304 ms

Are we maybe missing the files that would have been installed in /usr/pgsql-9.2/share/extension ? 

[[e-mail]1 extension]$ ls -ltr /usr/pgsql-9.2/share/extension/json*
-rw-r----- 1 root root  170 Jun 24 16:59 /usr/pgsql-9.2/share/extension/json_enhancements_no_hstore.control
-rw-r----- 1 root root 3838 Jun 24 16:59 /usr/pgsql-9.2/share/extension/json_enhancements--1.0.0.sql

It looks like you built this without hstore. But need the "with hstore" version.

Comment 10

[Selena Deckelmann :selenamarie :selena]

Also -- these files are read by the 'postgres' user, who also runs the 'postgres' process. So, these files in /usr/pgsql-9.2/share/extension should all be globally readable.

Comment 11

[Selena Deckelmann :selenamarie :selena]

And -- just a confirmation, with the .control file, and the permissions changes, I was able to get things going:

[[e-mail]1 ~]# cat /usr/pgsql-9.2/share/extension/json_enhancements.control 
# json_enhancements extension
comment = 'Backport of pg 9.3 json enhancements'
default_version = '1.0.0'
module_pathname = '$libdir/json_enhancements'
relocatable = true
requires = 'hstore'

Comment 12

[Eric Zounes [:zounese]]

Sorry about that. I went ahead and fixed the rpm. I added the hstore control file and the proper permissions. 

-zounese

Comment 13

[Selena Deckelmann :selenamarie :selena]

(In reply to Eric Zounes :[zounese] from comment #12)
> Sorry about that. I went ahead and fixed the rpm. I added the hstore control
> file and the proper permissions. 
> 
> -zounese

Hrm.

breakpad:5432# create extension json_enhancements ; 
ERROR:  could not open extension control file "/usr/pgsql-9.2/share/extension/json_enhancements.control": No such file or directory
Time: 10.055 ms


How is the json_enhancements_with_hstore.control being created? Did you create that manually or did it come from the package?

Comment 14

[Eric Zounes [:zounese]]

It came with the source. I was using the old working rpm as a reference.
The source contains three json files. I assumed it should have been packaged using the"json_enhancements_with_hstore.json" file. Should all json control files be included?

-zounese

Comment 15

[Selena Deckelmann :selenamarie :selena]

(In reply to Eric Zounes :[zounese] from comment #14)
> It came with the source. I was using the old working rpm as a reference.
> The source contains three json files. I assumed it should have been packaged
> using the"json_enhancements_with_hstore.json" file. Should all json control
> files be included?

Yes, we should include all three. I'm unsure why my installation doesn't create the other two, so let's just have them all just in case.

Sorry for the tediousness of this request!  I really appreciate your help.

Comment 16

[Eric Zounes [:zounese]]

I think I see the problem. It does generate a new control file. Initially there was a control file and for some reason the make file spits them out in the build directory. It was my fault for missing the time stamp on it. Apologies, again.  I made another attempt. This time I added the control file which was generated from the Makefile.

-zounese

Comment 17

[Eric Zounes [:zounese]]

Oh, yes. If this doesn't work, I'll add all three. However, the others weren't generated by make. And np. Thanks for being patient with me. 

-zounese

Comment 18

[Selena Deckelmann :selenamarie :selena]

Yay! 

To reinstall:

yum --enablerepo=mozilla clean metadata
yum install postgresql92-json_enhancements

And then: 

psql breakpad -c "drop extension json_enhancements"
psql breakpad -c "create extension json_enhancements"

And the test to verify it is working: 
psql breakpad -c "select backfill_tcbs('2013-06-20')"

Which now succeeds!

Tested on socorro1.dev and socorro1.stage databases.

many thanks!!