Closed Bug 885079 Opened 7 years ago Closed 7 years ago

[ca] Search engine setup for Firefox Mobile for Catalan

Categories

(Mozilla Localizations :: ca / Catalan, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: gueroJeff, Assigned: egamonal)

References

()

Details

(Keywords: productization)

Attachments

(2 files, 5 obsolete files)

We want to ship Firefox Mobile with a good list of search engines for Catalan.

We're going to work towards this in three phases. First, the localization team and the l10n drivers will look at the market for the language and come up with a good set of search providers. Eduard, we'll need your input on this, the guidelines for making recommendations are on <https://wiki.mozilla.org/L10n:Mobile/Productization>.

For en-US, we currently use this set, to which we can fall back in the case of lacking localized alternatives:

> Google (mobile version), Amazon, Twitter, Wikipedia (slightly different to desktop, 32x32 icon)

Once we decide to use a particular search engine (and we test it on a mobile device), l10n drivers will contact the owner and ask for permission, and for specifics like proper search flags. Eduard, we'll likely need your help to at least get the contact information.

For search engines that we already ship with on desktop and that you would like to include in mobile as well, the permission is not needed. Consider using a mobile version of the engine if one is available. Also, please make yourself familiar with instructions regarding the <Description/> element at <https://wiki.mozilla.org/L10n:Integrated_Search_Instructions>.

Once we have a specification on what the search engines for Catalan should look like, Milos and the localization team will work on an implementation on that. Milos will create and attach patches for the desired changes and get them reviewed. After a successful review, Milos will land them. Eduard, if you're interested, you could create the patches, too. You'd ask Milos for review on those before landing.

Please don't commit any modifications in browser/searchplugins to the hg repository without a patch reviewed by Milos, Stas, Axel or someone else appointed by the l10n drivers. The data here is sensitive to users and our search partners, thus the extra care here.

The Catalan team and Milos will be driving this bug to completion.
It should be noted that we're aiming for Firefox 24. That being the case, we have until August 6th to get this into Aurora.
As a side note: ca currently has a google.xml in mobile/searchplugins
http://hg.mozilla.org/releases/l10n/mozilla-aurora/ca/file/bcd329e0fd19/mobile/searchplugins

Such file should not exist in the locale folder. If you put "google" in list.txt, the en-US version of this plugin will be automatically picked.
Attached patch search plugins patch (obsolete) — Splinter Review
Hi,
We decided that we'll be using almost the same set of search engines as in desktop. This patch removes Huubs (not relevant any longer), adds DIEC2 (mobile version of the dictionary already available in desktop). It also removes the file for Google in the locale folder, as Francesco pointed.
Attachment #772322 - Flags: review?(milos)
Comment on attachment 772322 [details] [diff] [review]
search plugins patch

Review of attachment 772322 [details] [diff] [review]:
-----------------------------------------------------------------

I'll let Milos check the searchplugins.

::: mobile/searchplugins/list.txt
@@ +1,4 @@
>  google
>  twitter
>  wikipedia-ca
> +diec

Your .xml file is called diec2.xml, not diec.xml, this will cause the build to fail.
I suggest you fix this by renaming diec2.xml -> diec.xml
Attachment #772322 - Flags: review?(milos) → review-
Attached patch new version of the patch (obsolete) — Splinter Review
The name of the dictionary is actually "diec2". renamed "diec" in the list to "diec2" but not the filename.
Attachment #772322 - Attachment is obsolete: true
Attachment #773547 - Flags: review?(milos)
Attachment #773547 - Flags: review?(francesco.lodolo)
Comment on attachment 773547 [details] [diff] [review]
new version of the patch

Review of attachment 773547 [details] [diff] [review]:
-----------------------------------------------------------------

Patch looks good to me, I'll let Milos review it ;-)
Attachment #773547 - Flags: review?(francesco.lodolo) → feedback+
Comment on attachment 773547 [details] [diff] [review]
new version of the patch

Review of attachment 773547 [details] [diff] [review]:
-----------------------------------------------------------------

hah, I got it the first time around! sorry, inside joke.

We'll need a new icon for diec2, thus r-.

::: mobile/searchplugins/diec2.xml
@@ +4,5 @@
> +<SearchPlugin xmlns="http://www.mozilla.org/2006/browser/search/">
> +<ShortName>DIEC2</ShortName>
> +<Description>Diccionari de l'Institut d'Estudis Catalans</Description>
> +<InputEncoding>ISO-8859-1</InputEncoding>
> +<Image width="16" height="16">data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABAAAAAQCAMAAAFfKj%2FFAAAACXBIWXMAAAsTAAALEwEAmpwYAAAKTWlDQ1BQaG90b3Nob3AgSUNDIHByb2ZpbGUAAHjanVN3WJP3Fj7f92UPVkLY8LGXbIEAIiOsCMgQWaIQkgBhhBASQMWFiApWFBURnEhVxILVCkidiOKgKLhnQYqIWotVXDjuH9yntX167%2B3t%2B9f7vOec5%2FzOec8PgBESJpHmomoAOVKFPDrYH49PSMTJvYACFUjgBCAQ5svCZwXFAADwA3l4fnSwP%2FwBr28AAgBw1S4kEsfh%2F4O6UCZXACCRAOAiEucLAZBSAMguVMgUAMgYALBTs2QKAJQAAGx5fEIiAKoNAOz0ST4FANipk9wXANiiHKkIAI0BAJkoRyQCQLsAYFWBUiwCwMIAoKxAIi4EwK4BgFm2MkcCgL0FAHaOWJAPQGAAgJlCLMwAIDgCAEMeE80DIEwDoDDSv%2BCpX3CFuEgBAMDLlc2XS9IzFLiV0Bp38vDg4iHiwmyxQmEXKRBmCeQinJebIxNI5wNMzgwAABr50cH%2BOD%2BQ5%2Bbk4eZm52zv9MWi%2FmvwbyI%2BIfHf%2FryMAgQAEE7P79pf5eXWA3DHAbB1v2upWwDaVgBo3%2FldM9sJoFoK0Hr5i3k4%2FEAenqFQyDwdHAoLC%2B0lYqG9MOOLPv8z4W%2Fgi372%2FEAe%2Ftt68ABxmkCZrcCjg%2F1xYW52rlKO58sEQjFu9%2Bcj%2FseFf%2F2OKdHiNLFcLBWK8ViJuFAiTcd5uVKRRCHJleIS6X8y8R%2BW%2FQmTdw0ArIZPwE62B7XLbMB%2B7gECiw5Y0nYAQH7zLYwaC5EAEGc0Mnn3AACTv%2FmPQCsBAM2XpOMAALzoGFyolBdMxggAAESggSqwQQcMwRSswA6cwR28wBcCYQZEQAwkwDwQQgbkgBwKoRiWQRlUwDrYBLWwAxqgEZrhELTBMTgN5%2BASXIHrcBcGYBiewhi8hgkEQcgIE2EhOogRYo7YIs4IF5mOBCJhSDSSgKQg6YgUUSLFyHKkAqlCapFdSCPyLXIUOY1cQPqQ28ggMor8irxHMZSBslED1AJ1QLmoHxqKxqBz0XQ0D12AlqJr0Rq0Hj2AtqKn0UvodXQAfYqOY4DRMQ5mjNlhXIyHRWCJWBomxxZj5Vg1Vo81Yx1YN3YVG8CeYe8IJAKLgBPsCF6EEMJsgpCQR1hMWEOoJewjtBK6CFcJg4Qxwicik6hPtCV6EvnEeGI6sZBYRqwm7iEeIZ4lXicOE1%2BTSCQOyZLkTgohJZAySQtJa0jbSC2kU6Q%2B0hBpnEwm65Btyd7kCLKArCCXkbeQD5BPkvvJw%2BS3FDrFiOJMCaIkUqSUEko1ZT%2FlBKWfMkKZoKpRzame1AiqiDqfWkltoHZQL1OHqRM0dZolzZsWQ8ukLaPV0JppZ2n3aC%2FpdLoJ3YMeRZfQl9Jr6Afp5%2BmD9HcMDYYNg8dIYigZaxl7GacYtxkvmUymBdOXmchUMNcyG5lnmA%2BYb1VYKvYqfBWRyhKVOpVWlX6V56pUVXNVP9V5qgtUq1UPq15WfaZGVbNQ46kJ1Bar1akdVbupNq7OUndSj1DPUV%2Bjvl%2F9gvpjDbKGhUaghkijVGO3xhmNIRbGMmXxWELWclYD6yxrmE1iW7L57Ex2Bfsbdi97TFNDc6pmrGaRZp3mcc0BDsax4PA52ZxKziHODc57LQMtPy2x1mqtZq1%2BrTfaetq%2B2mLtcu0W7eva73VwnUCdLJ31Om0693UJuja6UbqFutt1z%2Bo%2B02PreekJ9cr1Dund0Uf1bfSj9Rfq79bv0R83MDQINpAZbDE4Y%2FDMkGPoa5hpuNHwhOGoEctoupHEaKPRSaMnuCbuh2fjNXgXPmasbxxirDTeZdxrPGFiaTLbpMSkxeS%2BKc2Ua5pmutG003TMzMgs3KzYrMnsjjnVnGueYb7ZvNv8jYWlRZzFSos2i8eW2pZ8ywWWTZb3rJhWPlZ5VvVW16xJ1lzrLOtt1ldsUBtXmwybOpvLtqitm63Edptt3xTiFI8p0in1U27aMez87ArsmuwG7Tn2YfYl9m32zx3MHBId1jt0O3xydHXMdmxwvOuk4TTDqcSpw%2BlXZxtnoXOd8zUXpkuQyxKXdpcXU22niqdun3rLleUa7rrStdP1o5u7m9yt2W3U3cw9xX2r%2B00umxvJXcM970H08PdY4nHM452nm6fC85DnL152Xlle%2B70eT7OcJp7WMG3I28Rb4L3Le2A6Pj1l%2Bs7pAz7GPgKfep%2BHvqa%2BIt89viN%2B1n6Zfgf8nvs7%2Bsv9j%2Fi%2F4XnyFvFOBWABwQHlAb2BGoGzA2sDHwSZBKUHNQWNBbsGLww%2BFUIMCQ1ZH3KTb8AX8hv5YzPcZyya0RXKCJ0VWhv6MMwmTB7WEY6GzwjfEH5vpvlM6cy2CIjgR2yIuB9pGZkX%2BX0UKSoyqi7qUbRTdHF09yzWrORZ%2B2e9jvGPqYy5O9tqtnJ2Z6xqbFJsY%2BybuIC4qriBeIf4RfGXEnQTJAntieTE2MQ9ieNzAudsmjOc5JpUlnRjruXcorkX5unOy553PFk1WZB8OIWYEpeyP%2BWDIEJQLxhP5aduTR0T8oSbhU9FvqKNolGxt7hKPJLmnVaV9jjdO31D%2BmiGT0Z1xjMJT1IreZEZkrkj801WRNberM%2FZcdktOZSclJyjUg1plrQr1zC3KLdPZisrkw3keeZtyhuTh8r35CP5c%2FPbFWyFTNGjtFKuUA4WTC%2BoK3hbGFt4uEi9SFrUM99m%2Fur5IwuCFny9kLBQuLCz2Lh4WfHgIr9FuxYji1MXdy4xXVK6ZHhp8NJ9y2jLspb9UOJYUlXyannc8o5Sg9KlpUMrglc0lamUycturvRauWMVYZVkVe9ql9VbVn8qF5VfrHCsqK74sEa45uJXTl%2FVfPV5bdra3kq3yu3rSOuk626s91m%2Fr0q9akHV0IbwDa0b8Y3lG19tSt50oXpq9Y7NtM3KzQM1YTXtW8y2rNvyoTaj9nqdf13LVv2tq7e%2B2Sba1r%2Fdd3vzDoMdFTve75TsvLUreFdrvUV99W7S7oLdjxpiG7q%2F5n7duEd3T8Wej3ulewf2Re%2FranRvbNyvv7%2ByCW1SNo0eSDpw5ZuAb9qb7Zp3tXBaKg7CQeXBJ9%2BmfHvjUOihzsPcw83fmX%2B39QjrSHkr0jq%2Fdawto22gPaG97%2BiMo50dXh1Hvrf%2Ffu8x42N1xzWPV56gnSg98fnkgpPjp2Snnp1OPz3Umdx590z8mWtdUV29Z0PPnj8XdO5Mt1%2F3yfPe549d8Lxw9CL3Ytslt0utPa49R35w%2FeFIr1tv62X3y%2B1XPK509E3rO9Hv03%2F6asDVc9f41y5dn3m978bsG7duJt0cuCW69fh29u0XdwruTNxdeo94r%2Fy%2B2v3qB%2FoP6n%2B0%2FrFlwG3g%2BGDAYM%2FDWQ%2FvDgmHnv6U%2F9OH4dJHzEfVI0YjjY%2BdHx8bDRq98mTOk%2BGnsqcTz8p%2BVv9563Or59%2F94vtLz1j82PAL%2BYvPv655qfNy76uprzrHI8cfvM55PfGm%2FK3O233vuO%2B638e9H5ko%2FED%2BUPPR%2BmPHp9BP9z7nfP78L%2FeE8%2Fsl0p8zAAAABGdBTUEAALGOfPtRkwAAACBjSFJNAAB6JQAAgIMAAPn%2FAACA6QAAdTAAAOpgAAA6mAAAF2%2BSX8VGAAADAFBMVEX%2F%2F%2F%2F%2F%2F8z%2F%2F5n%2F%2F2b%2F%2FzP%2F%2FwD%2FzP%2F%2FzMz%2FzJn%2FzGb%2FzDP%2FzAD%2Fmf%2F%2Fmcz%2FmZn%2FmWb%2FmTP%2FmQD%2FZv%2F%2FZsz%2FZpn%2FZmb%2FZjP%2FZgD%2FM%2F%2F%2FM8z%2FM5n%2FM2b%2FMzP%2FMwD%2FAP%2F%2FAMz%2FAJn%2FAGb%2FADP%2FAADM%2F%2F%2FM%2F8zM%2F5nM%2F2bM%2FzPM%2FwDMzP%2FMzMzMzJnMzGbMzDPMzADMmf%2FMmczMmZnMmWbMmTPMmQDMZv%2FMZszMZpnMZmbMZjPMZgDMM%2F%2FMM8zMM5nMM2bMMzPMMwDMAP%2FMAMzMAJnMAGbMADPMAACZ%2F%2F%2BZ%2F8yZ%2F5mZ%2F2aZ%2FzOZ%2FwCZzP%2BZzMyZzJmZzGaZzDOZzACZmf%2BZmcyZmZmZmWaZmTOZmQCZZv%2BZZsyZZpmZZmaZZjOZZgCZM%2F%2BZM8yZM5mZM2aZMzOZMwCZAP%2BZAMyZAJmZAGaZADOZAABm%2F%2F9m%2F8xm%2F5lm%2F2Zm%2FzNm%2FwBmzP9mzMxmzJlmzGZmzDNmzABmmf9mmcxmmZlmmWZmmTNmmQBmZv9mZsxmZplmZmZmZjNmZgBmM%2F9mM8xmM5lmM2ZmMzNmMwBmAP9mAMxmAJlmAGZmADNmAAAz%2F%2F8z%2F8wz%2F5kz%2F2Yz%2FzMz%2FwAzzP8zzMwzzJkzzGYzzDMzzAAzmf8zmcwzmZkzmWYzmTMzmQAzZv8zZswzZpkzZmYzZjMzZgAzM%2F8zM8wzM5kzM2YzMzMzMwAzAP8zAMwzAJkzAGYzADMzAAAA%2F%2F8A%2F8wA%2F5kA%2F2YA%2FzMA%2FwAAzP8AzMwAzJkAzGYAzDMAzAAAmf8AmcwAmZkAmWYAmTMAmQAAZv8AZswAZpkAZmYAZjMAZgAAM%2F8AM8wAM5kAM2YAMzMAMwAAAP8AAMwAAJkAAGYAADMAAAD6Fxj8FRb7FBX5EhT8BQf7BQf5Bwj9Cgv8DBD7DQ%2F5DxH6EhX9ExT6ExX8FBb18ez84N3%2B6%2Br5Cgn4Dgz7Dw%2F2Ew%2F5EhH5ExH2FRH3FRL9ExP5FBT9FhX8FRX6FRX4FxX8Fhb7Fxb2Gxj5HRr2HRn3HRv%2F%2F%2F8AAAD5ITrYAAAA%2F3RSTlP%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2FwBm%2FIpZAAAA7ElEQVR42mL4d4PhHwMAAAD%2F%2F2K4cYOFSRAAAAD%2F%2F2L494zhLRPDV4a%2FAAAAAP%2F%2FYrzBwMDAwPDrGQMTw98vDEwM3xkZAAAAAP%2F%2FYvzHdIuL9SOrIhMDw39R8f%2B8DAz%2FGH78ZvjxnoHhHwMEAFiWQx0AQSgAgOeT5IjMSOb%2Fv8Zut7ARwcL124%2BQW%2BRWJbdcfMLSlyFMx3RJknoaQvd22P35qZBjFQBBKArDvxe3ahIi8P3fKZwFJZzjhmAN3qXDNxx%2Bhr0KFDgF6ErXoytbAg%2BUx1zLDFFNcDNkMW0HAeJtwjtDXk3z4Ebit28Ab35LCW4dGm8AAAAASUVORK5CYII%3D</Image>

The image url can't have any %2F etc in it, mobile breaks on those.

Also, can we get an icon with 32x32 pixes? I didn't find anything ad-hoc, but if we could, we should.

The width="16" height="16" attributes on the <Image> element should say 16 either way, though. That's another bug. The engine displays the one that claims to be 16x16, but prefers 32x32 image to be actually inside of that.
Attachment #773547 - Flags: review?(milos) → review-
Attached file 32x32 icon (base64)
You could try with this (32x32 version of your 16x16 original icon, no %)
hey!
the new image looks good but it still has %2F . Should I encode it? %2F will become %252F but that looks like double encoding...
I don't see % encodings in the 32x32 data uri.
Attached patch patch with 32x32 icon and no % (obsolete) — Splinter Review
damn it, I looked at the 16x16 icon of Francesco's attachment. the 32x32 one is correct.
Attachment #773547 - Attachment is obsolete: true
Attachment #775953 - Flags: review?(milos)
Guys, can I help you more here? Milos, maybe you review the patch in case I did something wrong?
Comment on attachment 775953 [details] [diff] [review]
patch with 32x32 icon and no %

Review of attachment 775953 [details] [diff] [review]:
-----------------------------------------------------------------

Tried on a local copy of mozilla-aurora for ca:
* The patch correctly removes google.xml and huubs.xml.
* Searchplugin DIEC2 shows the right icon and works as expected.

One doubt though: you currently search with operEntrada=0 ("Coincident"), while you could search for a partial match ("en qualsevol posició") with operEntrada=3. 
Is that wanted and expected behavior?

Unfortunately there's also another problem about wikipedia-ca.xml, not covered by this patch (sorry for not noticing it before).

This is your current xml file
http://hg.mozilla.org/releases/l10n/mozilla-aurora/ca/file/719f413d84c0/mobile/searchplugins/wikipedia-ca.xml

Compare it to the current English version
http://hg.mozilla.org/mozilla-central/file/604c8518cc50/mobile/locales/en-US/searchplugins/wikipedia.xml

1. The URL was fixed in bug 825821, your searchplugin was probably created before that and never fixed.
2. You don't need a Description on mobile

<Url type="text/html" method="GET" template="http://ca.m.wikipedia.org/wiki">
  ..	
  <Param name="sourceid" value="mozilla-search"/>

should become

<Url type="text/html" method="GET" template="http://ca.wikipedia.org/wiki/Especial:Cerca">
  ..
  <Param name="sourceid" value="Mozilla-search"/>

If you can provide a patch tomorrow I'll try to review it with feedback from pike if Milos is not available to speed things up.
Attachment #775953 - Flags: review?(milos) → review-
Comment on attachment 775953 [details] [diff] [review]
patch with 32x32 icon and no %

Review of attachment 775953 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/searchplugins/diec2.xml
@@ +7,5 @@
> +<InputEncoding>ISO-8859-1</InputEncoding>
> +<Image width="16" height="16">data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAACAAAAAgCAYAAABzenr0AAAAGXRFWHRTb2Z0d2FyZQBBZG9iZSBJbWFnZVJlYWR5ccllPAAAA2hpVFh0WE1MOmNvbS5hZG9iZS54bXAAAAAAADw/eHBhY2tldCBiZWdpbj0i77u/IiBpZD0iVzVNME1wQ2VoaUh6cmVTek5UY3prYzlkIj8+IDx4OnhtcG1ldGEgeG1sbnM6eD0iYWRvYmU6bnM6bWV0YS8iIHg6eG1wdGs9IkFkb2JlIFhNUCBDb3JlIDUuMC1jMDYxIDY0LjE0MDk0OSwgMjAxMC8xMi8wNy0xMDo1NzowMSAgICAgICAgIj4gPHJkZjpSREYgeG1sbnM6cmRmPSJodHRwOi8vd3d3LnczLm9yZy8xOTk5LzAyLzIyLXJkZi1zeW50YXgtbnMjIj4gPHJkZjpEZXNjcmlwdGlvbiByZGY6YWJvdXQ9IiIgeG1sbnM6eG1wTU09Imh0dHA6Ly9ucy5hZG9iZS5jb20veGFwLzEuMC9tbS8iIHhtbG5zOnN0UmVmPSJodHRwOi8vbnMuYWRvYmUuY29tL3hhcC8xLjAvc1R5cGUvUmVzb3VyY2VSZWYjIiB4bWxuczp4bXA9Imh0dHA6Ly9ucy5hZG9iZS5jb20veGFwLzEuMC8iIHhtcE1NOk9yaWdpbmFsRG9jdW1lbnRJRD0ieG1wLmRpZDowMTgwMTE3NDA3MjA2ODExQUUzREY0RjNBMzQ0OTZFOSIgeG1wTU06RG9jdW1lbnRJRD0ieG1wLmRpZDpEQjYyN0FGNEUyRjcxMUUyODRENEYyODI4NENBMTFENSIgeG1wTU06SW5zdGFuY2VJRD0ieG1wLmlpZDpEQjYyN0FGM0UyRjcxMUUyODRENEYyODI4NENBMTFENSIgeG1wOkNyZWF0b3JUb29sPSJBZG9iZSBQaG90b3Nob3AgQ1M1LjEgTWFjaW50b3NoIj4gPHhtcE1NOkRlcml2ZWRGcm9tIHN0UmVmOmluc3RhbmNlSUQ9InhtcC5paWQ6MDE4MDExNzQwNzIwNjgxMUFFM0RGNEYzQTM0NDk2RTkiIHN0UmVmOmRvY3VtZW50SUQ9InhtcC5kaWQ6MDE4MDExNzQwNzIwNjgxMUFFM0RGNEYzQTM0NDk2RTkiLz4gPC9yZGY6RGVzY3JpcHRpb24+IDwvcmRmOlJERj4gPC94OnhtcG1ldGE+IDw/eHBhY2tldCBlbmQ9InIiPz7EjhQeAAABDklEQVR42tSXT8+CMAzGV+uGAWI8aKLf/8Np8OBB31cY0GnoNP7BgyyRtZeOX0i251lZBzjnVL3eODVC6N0WJmrkmL6s6CeTXh2/j+Ny4Ba0XHEG4Jf2xTCe5V1us5QdLoq3ueJ0oElNl7FqgrjKWTnQ5wXE6UBLvGSkMF61tsuJ0sIcwFPFyhD5OZTn5qPaOB2YzHRv9X7PEx6AtK+gMaxIlzaQczUYImEOgGUlzgXyyjuiZ9LOgX+vSJswfq59LbADRowDtMh6u9vXfJ56lSCtGyouZ3SB3MubijsH8K/0yl6620BOaS6sG6LlzaQEwnhN/rYsrRvi8fC0l4O5LXt5vA48/rP9KkZ34CLAALApn10aoc18AAAAAElFTkSuQmCC</Image>
> +<Url type="text/html" method="GET" template="http://mdlc.iec.cat/results.asp">
> +  <Param name="txtEntrada" value="{searchTerms}"/>
> +  <Param name="OperEntrada" value="0"/>

Nitpicking: on the website the parameter is called "operEntrada", not "OperEntrada", but being asp it doesn't really make a difference.
No longer depends on: 846712
Duplicate of this bug: 846712
Sorry for the noise. 

I found an old bug opened by Pike about wikipedia-ca.xml, I marked it as a duplicate of this bug since the idea is to have a single patch here to fix both.
I wanted to fix the wikipedia-ca bug after this, but since all changes should be in a single patch, I'll submit a new version. it's basically removing the "m" subdomain and let wikipedia do the magic to detect whether to show the desktop or the mobile version.

I prefer to name the parameters as they are used in the website. I'll rename OperEntrada to operEntrada. My opinion is that we should use option "exact match".
Attached patch bug-885079-r3.patch (obsolete) — Splinter Review
patch with previous changes and wikipedia-ca updated
Attachment #775953 - Attachment is obsolete: true
Attachment #778053 - Flags: review?(milos)
Attachment #778053 - Flags: review?(francesco.lodolo)
Comment on attachment 778053 [details] [diff] [review]
bug-885079-r3.patch

Review of attachment 778053 [details] [diff] [review]:
-----------------------------------------------------------------

Wikipedia looks OK, but you went back to the wrong icon for DIEC2.
Attachment #778053 - Flags: review?(milos)
Attachment #778053 - Flags: review?(francesco.lodolo)
Attachment #778053 - Flags: review-
Attached patch bug.patch (obsolete) — Splinter Review
puts the 32x32 icon back to the patch
Attachment #778053 - Attachment is obsolete: true
Attachment #778331 - Flags: review?(milos)
Attachment #778331 - Flags: review?(francesco.lodolo)
Comment on attachment 778331 [details] [diff] [review]
bug.patch

Review of attachment 778331 [details] [diff] [review]:
-----------------------------------------------------------------

Still wrong icon, and this time the patch fails to apply on wikipedia-ca.xml

Hunk #1 FAILED at 0
1 out of 1 hunks FAILED -- saving rejects to file mobile/searchplugins/wikipedia-ca.xml.rej

Let's try the opposite approach to speed things up, if that's OK with you. I provide a patch for you to review, and then ask pike for feedback.
Attachment #778331 - Flags: review?(milos)
Attachment #778331 - Flags: review?(francesco.lodolo)
Attachment #778331 - Flags: review-
yeah, definitely this is taking too long.  thanks for helping!
Attached patch Updated patchSplinter Review
Updated patch with correct icon

Resulting searchplugins can be tested here
http://flod.org/mobiletest/
Attachment #778331 - Attachment is obsolete: true
Attachment #778337 - Flags: review?(egamonal)
Attachment #778337 - Flags: feedback?(l10n)
Important: don't commit this patch until we've got feedback from pike.

When ready, you can import it like this from within mozilla-aurora (change the path to the patch)

hg import --no-commit bug885079.patch
hg commit -m "Bug 885079 - [ca] Search engine setup for Firefox Mobile for Catalan, r=flod, f=pike"
Attachment #778337 - Flags: feedback?(l10n) → feedback+
Attachment #778337 - Flags: review?(egamonal) → review+
Patch committed to mozilla-aurora
http://hg.mozilla.org/releases/l10n/mozilla-aurora/ca/rev/db78c1a60eab
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
I've also merged mozilla-aurora to l10n-central.

I tried to do a simple merge but it didn't work (about 50 unresolved conflicts), so I kept files from Aurora as the good reference (last commit on central was over two years old) and used 

hg merge --tool internal:other 

You can check the merge changeset here
http://hg.mozilla.org/l10n-central/ca/rev/c00317880f89
Thanks Flod. We don't use central. localizing as the product is being developed would be too much for the community. we don't have the resources for that so we only work in aurora. I'd say that you don't bother merging with central. Is that ok?
(In reply to Eduard Gamonal from comment #27)
> Thanks Flod. We don't use central. localizing as the product is being
> developed would be too much for the community. we don't have the resources
> for that so we only work in aurora. I'd say that you don't bother merging
> with central. Is that ok?

Sure. But since files there were really old, I decided to fix things a little :-)

I think single locale builds are back, can you try ca and confirm me what searchplugins are in there?
http://ftp.mozilla.org/pub/mozilla.org/mobile/nightly/latest-mozilla-central-android-l10n/
(In reply to Francesco Lodolo [:flod] from comment #28)
> http://ftp.mozilla.org/pub/mozilla.org/mobile/nightly/latest-mozilla-central-
> android-l10n/

Clearly wrong link for Aurora builds. From a quick look at the apk the searchplugins seem updated
http://ftp.mozilla.org/pub/mozilla.org/mobile/nightly/latest-mozilla-aurora-android-l10n/
all search plugins work fine :)
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.