825821 - Request Desktop site doesn't work on Wikipedia

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[pjmiller2001]

User Agent: Mozilla/5.0 (Android; Mobile; rv:18.0) Gecko/18.0 Firefox/18.0
Build ID: 20121227073833

Steps to reproduce:

When using integrated search of wikipedia clicking on the suggestion that appears takes me to the mobile site rather than desktop site even though it is checked in settings. Going directly to website through web address takes me to desktop version as it should.


Actual results:

Read explanation above


Expected results:

Should have gone go desktop site rather than mobile site as selected in settings.

Comment 1

[Ioana Chiorean]

I am able to reproduce this on latest Beta. 
On nightly requesting Desktop site will lead you to main_page wikipedia

Comment 2

[Aaron Train [:aaronmt]]

Brian, is this  a dupe? Expected behaviour?

Comment 3

[Brian Nicholson (:bnicholson)]

This happens because we specify the mobile Wikipedia URL in the search template: http://mxr.mozilla.org/mozilla-central/source/mobile/locales/en-US/searchplugins/wikipedia.xml#13

We used to do the same thing for Google searches - I think it was because Google gave us a terrible WAP site for our UA. Assuming we're using the mobile Wikipedia template for the same reason, it's probably unnecessary now (since going to wikipedia.org redirects to en.m.wikipedia.org, which is what we use in the template).

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

I agree with Brian. We should stop using the hardcoded "http://en.m.wikipedia.org/wiki" and just let Wikipedia handle the redirect.

Comment 5

[Brian Nicholson (:bnicholson)]

Attachment: Use standard URL for wikipedia search template

Uses the same template as URL as desktop's wikipedia.xml, which seems to work fine.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 699508 [details] [diff] [review]
Use standard URL for wikipedia search template

Did you test a tablet too? Ideally, a tablet would show the desktop Wikipedia, but showing a mobile version would be acceptable for now. It would be up to Wikipedia to fix the tablet layout.

Comment 7

[Brian Nicholson (:bnicholson)]

(In reply to Mark Finkle (:mfinkle) from comment #6)
> Comment on attachment 699508 [details] [diff] [review]
> Use standard URL for wikipedia search template
> 
> Did you test a tablet too? Ideally, a tablet would show the desktop
> Wikipedia, but showing a mobile version would be acceptable for now. It
> would be up to Wikipedia to fix the tablet layout.

I just tested it on my ASUS Transformer tablet, and it does in fact use desktop Wikipedia.

Comment 8

[Brian Nicholson (:bnicholson)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/762d7ec784e7

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

Uplift potential?

Comment 10

[Brian Nicholson (:bnicholson)]

Comment on attachment 699508 [details] [diff] [review]
Use standard URL for wikipedia search template

[Approval Request Comment]
Bug caused by (feature/regressing bug #): none
User impact if declined: When searching Wikipedia from the AwesomeScreen, tablets show mobile Wikipedia and the "Request Desktop Site" preference is ignored.
Testing completed (on m-c, etc.): m-i
Risk to taking this patch (and alternatives if risky): low risk
String or UUID changes made by this patch: none

Comment 11

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/762d7ec784e7

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/87124242786e
https://hg.mozilla.org/releases/mozilla-beta/rev/65981ebd5646

Comment 13

[Catalin Suciu [:csuciu]]

Verified fixed on Nightly 21.0a1 (2013-01-13).

Comment 14

[Paul Feher]

Verified fixed on Aurora 20.0a2 (2013-01-23) and on Firefox 19.0b2 (2013-01-16)

Comment 15

[Axel Hecht [:Pike]]

I'll go out and file bugs on l10n for this, too.

http://mxr.mozilla.org/l10n-mozilla-aurora/search?string=.m.wiki&find=mobile/searchplugins/wikipedia- shows the affected locales, fr is already having a bug open.