885652 - B2G SMS: DOMRequest in sending SMS API does not trigger onsuccess or onerror function when the SIM card is not installed or radio is disabled.

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Evan Tseng [:evanxd]]

Send SMS with mozMobileMessage.send(), the request.onsuccess or request.onerror was never triggered in the DOMRequest.

This bug is blocking Bug 880257.
Because if the bug is not resolved, we can not remove the error handle from here https://github.com/mozilla-b2g/gaia/blob/master/apps/sms/js/thread_ui.js#L1369 in Gaia layer.

Comment 1

[Borja Salguero [:borjasalguero]]

This is blocking a leo+, and we need work here for having this functionality working as expected. Dietrich, could you help us with this? Thanks!

Comment 2

[Gene Lian (I already quit Mozilla)]

Let me help with this.

Comment 3

[Gene Lian (I already quit Mozilla)]

Attachment: Patch

It's a 5-minute patch. Will write a test case for this later.

Comment 4

[Borja Salguero [:borjasalguero]]

Thanks Gene! And see u in Taipei next week! :)

Comment 5

[Gene Lian (I already quit Mozilla)]

Attachment: Patch, V2

Comment 6

[Vicamo Yang [:vicamo][:vyang]]

Comment on attachment 766624 [details] [diff] [review]
Patch, V2

Review of attachment 766624 [details] [diff] [review]:
-----------------------------------------------------------------

Wonderful~

Comment 7

[Gene Lian (I already quit Mozilla)]

Attachment: Patch, V2.1

Ready to land.

Comment 8

[Gene Lian (I already quit Mozilla)]

https://hg.mozilla.org/projects/birch/rev/724e7177ad47

Comment 9

[Gene Lian (I already quit Mozilla)]

Ping Dietrich? We need to uplift this to b2g18 as well. Thanks!

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/724e7177ad47

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/d2e1e105d5d4

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18_v1_1_0_hd/rev/d2e1e105d5d4