886539 - [B2G][L10n][Email] Polski: account-last-synced-label text is truncated

Status: RESOLVED DUPLICATE of bug 940132

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[sarsenyev]

Attachment: screen attachment

Description:
Polish text "Last sync just now" overlaps the "Settings" icon (cogwheel)

Repro Steps:
1) Updated to Buri/Inari/Leo/Unagi Build ID: 20130621070212
2) Open the "Settings" menu from the home screen
3) Change a language to "Polski"
4) From the home screen open the "Email" app
5) Sign in to any email account
6) Open info about the account icon (top left corner "three row lines")

Actual:
The text overlaps the icon

Expected:
No overlaps

Environmental Variables
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/a34f6d62cb05
Gaia: cca61224e6df8e9f7e450d77cb6a8cf91029be64
Platform Version: 18.0

Notes:
Repro frequency: 100%
See the screen attachment

Comment 1

[Stefan Plewako [:stef]]

Right now I don't see how I could shorten this string, but…

https://github.com/mozilla-b2g/gaia/blob/v1-train/apps/email/locales/email.en-US.properties#L269

It could be even worse if l10n note is correct (second button) but it also contains "To the right of the label, a (short) relative timestamp is displayed" which clearly isn't true - the long form, "minutes-ago-long" from shared/date/date.properties is used (and not minutes-ago-short).

Comment 2

[mdaniloff]

Verified that issue is fixed on latest Leo COM RIL build. The text appears with no overlapping of the icon.


Environmental Variables
Build ID: 20130808041202
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/1433d653b701
Gaia: 5cb67ea419b0a642ea11b6c8f93c3ee50318e90a
Platform Version: 18.1
Firmware-D300f08o

Marking the bug as Verified Fixed

Comment 3

[Stefan Plewako [:stef]]

Right, now it's turncated…

Comment 4

[Stephany Wilkes]

UX (Eric Pang) and I have reviewed. The text should just be shifted to the right, to uncover the first letter (i.e. move the text out from beneath the settings icon). 

Eric can upload a mock-up if more detail is needed. Please needinfo? epang if any visual design details are needed.

Comment 5

[Andrew Sutherland [:asuth] (he/him)]

Is this something we would fix across the v1.1 board, or something we just fix for this locale using a magic localized string to set the style directive on the node in question?  Ex, in the locale properties file:

account-last-synced-label.style=css-magic: true;


Assigning to Eric to ideally provide the fix, but failing that, please provide a mock-up.

Comment 6

[Stefan Plewako [:stef]]

Why not just use short, relative timestamp? (see #c1)

Comment 7

[Andrew Sutherland [:asuth] (he/him)]

(In reply to Stefan Plewako [:stef] from comment #6)
> Why not just use short, relative timestamp? (see #c1)

This change was made in bug 883035 and was uplifted to v1-train 15 minutes before this bug was filed which is what I assumed led to comment 2 marking this fixed.  I was assuming that there is still some type of problem based on your comment 3 and Stephany's comment 4.  I'll mark the attachment obsolete so it doesn't confuse the issue.

Comment 8

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 766900 [details]
screen attachment

(screenshot pre-dates uplift of bug 883035 fix)

Comment 9

[Eric Pang [:epang] UX]

(In reply to Andrew Sutherland (:asuth) from comment #8)
> Comment on attachment 766900 [details]
> screen attachment
> 
> (screenshot pre-dates uplift of bug 883035 fix)

Hi Andrew, i'm not able to provide the fix, but I'm thinking we have 2 options.

1. Is the truncated called by margins or padding set? Extending the margin might be the fastest solution.
Or
2. The text can be broken into two lines with "4 minuty temu..." being on the second line.  (I can provide a mock up if needed for this choice)

Thanks!

Comment 10

[Andrew Sutherland [:asuth] (he/him)]

Stefan, given my comment 7 about us having already changed to using the short string, can you confirm whether you are seeing us use the short string on v1-train (V1.1) and whether we are still truncating/etc. ?  Thanks!

Comment 11

[Stefan Plewako [:stef]]

Attachment: screenshot

In the latest builds I see this changed (short time string version is used) but still we are about 2-3 characters short.

Comment 12

[Leszek Zyczkowski]

IMHO the best solution will be change "Ostatnia synchronizacja" to "Zsynchronizowano" After this change will be e.g.:

Zsynchronizowano 4 minuty temu

Zsynchronizowano w tym momencie

Comment 13

[Stefan Plewako [:stef]]

(In reply to Leszek Zyczkowski from comment #12)

There is enough space to fit current string and „Zsynchronizowano” (us synced, synchronized) may or may not be accurate translation (depending on context).

Comment 14

[Leszek Zyczkowski]

(In reply to Stefan Plewako [:stef] from comment #13)
This is Past Perfect form and is very good in Polish language. Means that sync was made and in the second part of sentence is defined when sync was made. In the Polish language  adjective "ostatnia" (in English "last") is redundant. In this place is displayed information only about last sync. In this case information "Zsynchronizowano" means that "Last synchronization was made".

Comment 15

[Francesco Lodolo [:flod]]

Attachment: Example

I'm trying to look at this with remote debug, but devtools get crazy at the width of .fld-nav-last-synced

> max-width: calc(100% - (6rem + (100% - 25rem)/4) - 2rem);

Considering we are already covering stuff in the sidebar, and its content is scrollable, why not letting .bottom-toolbar span over more than one line and position it from the top?

Not sure how feasible this is, CSS code seems extremely complex compared to other apps, so I'm probably overlooking something.

Comment 16

[Andrew Sutherland [:asuth] (he/him)]

An overhauled drawer is being landed for v1.5 in bug 940132.  With the change, "last synced" is being moved to the message list where it is centered in the bottom toolbar.  :jrburke went to some effort to address the l10n issue and in fact it does detect overflow and ends up spanning 2 lines.  Check out the screenshot at https://bug940132.bugzilla.mozilla.org/attachment.cgi?id=8379363 

And of course new l10n id's will be in use (although that might be in the final rev of the patch; there are some outstanding changes.)

Comment 17

[Francesco Lodolo [:flod]]

Thanks, that's good news :-)

I'll follow bug 940132 updates then.