886628 - Add Romanian keyboard layout support

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

As Romanian is one of the target locales for v1.0.1, it would be nice to have the associated keyboard layout.

For reference: http://en.wikipedia.org/wiki/Romanian_keyboard_layout

Comment 1

[Walter Chen[:ypwalter][:wachen]]

For reference of how to do l10n: https://wiki.mozilla.org/L10n:B2G

Comment 2

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Attachment: Pull Request #11018 - Add Romanian kb layout

Added the necessary logic and layout for the Romanian keyboard. Accented characters specific to the Romanian language are alternatives for their equivalent ASCII characters (e.g. 'î' -> 'i', ș -> 's', etc.).

Comment 3

[George Pîrlea]

I've looked at pull request #11018, but I couldn't figure out whether that layout includes the „ ” « » and – characters used in Romanian. Can you confirm that it does?

Comment 4

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Those characters are available within the alternate layout (i.e. by pressing the '?123' key and 'ALT' from the alternate layout).

Comment 5

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 776851 [details]
Pull Request #11018 - Add Romanian kb layout

Mihai,

looks good to me, r+ from me.
Thanks for working on this and sorry for putting this at my queue for so long.

This patch cannot be merged automatically, due to some conflicts in settings/index.html.
Could you please resolve it? 
Or I will do it as a follow-up.

Comment 6

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

BTW, I know nothing about Romanian, but I cannot find '„' character as Comment 3 by George.
Can someone help to check if this is needed?

Thanks.

Comment 7

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

BTW, I know nothing about Romanian, but I cannot find '„' character as Comment 3 by George.
Can someone help to check if this is needed?

Thanks.

Comment 8

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

(In reply to Rudy Lu [:rudyl] from comment #6)
> BTW, I know nothing about Romanian, but I cannot find '„' character as
> Comment 3 by George.
> Can someone help to check if this is needed?
> 
> Thanks.

Hi Rudy, thanks for checking the patch! I did forget about the specific quote characters which I now added under the alt state (i.e. long tap) of " -> „”.

Let me know if this looks good.

Comment 9

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Mihai,

Yes, we are all good to merge your patch.
Glad to have a native speaker to add this for our Firefox OS users.

Thank you so much!

Comment 10

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Thanks, Rudy! Glad to contribute on language-specific features :)

Landed on master:
https://github.com/mozilla-b2g/gaia/commit/bdbf88cfdeb54153f851797ff3ece9779ae28a43

Comment 11

[Delphine Lebédel [:delphine - Use needinfo]]

Nominating as blocker for leo since this is a v1.1 shipping language.

Comment 12

[Axel Hecht [:Pike]]

Mihai, could this patch be adapated to not require new strings on v1-train?

Adding late-l10n for now.

Comment 13

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

(In reply to Axel Hecht [:Pike] from comment #12)
> Mihai, could this patch be adapated to not require new strings on v1-train?
> 
> Adding late-l10n for now.

Yes, the keyboard layout can be included in the "other latins" group which is localized.

Comment 14

[Axel Hecht [:Pike]]

(In reply to Mihai Cirlanaru [:mihai][:mcirlanaru] from comment #13)
> (In reply to Axel Hecht [:Pike] from comment #12)
> > Mihai, could this patch be adapated to not require new strings on v1-train?
> > 
> > Adding late-l10n for now.
> 
> Yes, the keyboard layout can be included in the "other latins" group which
> is localized.

Thanks, non-late-l10n then.

Comment 15

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

The Romanian keyboard layout has been uplifted to v1-train through the patch for bug 907763.

Comment 16

[Jeni]

Verified fixed on 

Build ID: 20130827041201
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/328b3b8158ee
Gaia: 4b2f1a103d046c92d201e8fcfb1ae224f59e7cf1
Platform Version: 18.1

Necessary accented characters have now been added to the Romanian keyboard.  (i.e. „ ” « » î i ș s and – etc)