Add Romanian keyboard layout support

RESOLVED FIXED

Status

Firefox OS
Gaia::Keyboard
RESOLVED FIXED
5 years ago
3 years ago

People

(Reporter: mihai, Assigned: mihai)

Tracking

({l12y})

unspecified
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(blocking-b2g:leo+, b2g18 verified)

Details

Attachments

(1 attachment)

As Romanian is one of the target locales for v1.0.1, it would be nice to have the associated keyboard layout.

For reference: http://en.wikipedia.org/wiki/Romanian_keyboard_layout
(Assignee)

Updated

5 years ago
tracking-b2g18: --- → ?
For reference of how to do l10n: https://wiki.mozilla.org/L10n:B2G
Created attachment 776851 [details]
Pull Request #11018 - Add Romanian kb layout

Added the necessary logic and layout for the Romanian keyboard. Accented characters specific to the Romanian language are alternatives for their equivalent ASCII characters (e.g. 'î' -> 'i', ș -> 's', etc.).
Attachment #776851 - Flags: review?(rlu)

Comment 3

5 years ago
I've looked at pull request #11018, but I couldn't figure out whether that layout includes the „ ” « » and – characters used in Romanian. Can you confirm that it does?
Those characters are available within the alternate layout (i.e. by pressing the '?123' key and 'ALT' from the alternate layout).
Comment on attachment 776851 [details]
Pull Request #11018 - Add Romanian kb layout

Mihai,

looks good to me, r+ from me.
Thanks for working on this and sorry for putting this at my queue for so long.

This patch cannot be merged automatically, due to some conflicts in settings/index.html.
Could you please resolve it? 
Or I will do it as a follow-up.
Attachment #776851 - Flags: review?(rlu) → review+
BTW, I know nothing about Romanian, but I cannot find '„' character as Comment 3 by George.
Can someone help to check if this is needed?

Thanks.
Flags: needinfo?(mihai)
Flags: needinfo?(george)
BTW, I know nothing about Romanian, but I cannot find '„' character as Comment 3 by George.
Can someone help to check if this is needed?

Thanks.
(In reply to Rudy Lu [:rudyl] from comment #6)
> BTW, I know nothing about Romanian, but I cannot find '„' character as
> Comment 3 by George.
> Can someone help to check if this is needed?
> 
> Thanks.

Hi Rudy, thanks for checking the patch! I did forget about the specific quote characters which I now added under the alt state (i.e. long tap) of " -> „”.

Let me know if this looks good.
Flags: needinfo?(mihai)
Mihai,

Yes, we are all good to merge your patch.
Glad to have a native speaker to add this for our Firefox OS users.

Thank you so much!
Flags: needinfo?(george)
Thanks, Rudy! Glad to contribute on language-specific features :)

Landed on master:
https://github.com/mozilla-b2g/gaia/commit/bdbf88cfdeb54153f851797ff3ece9779ae28a43
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Nominating as blocker for leo since this is a v1.1 shipping language.
blocking-b2g: --- → leo?
Mihai, could this patch be adapated to not require new strings on v1-train?

Adding late-l10n for now.
Keywords: l12y, late-l10n
(In reply to Axel Hecht [:Pike] from comment #12)
> Mihai, could this patch be adapated to not require new strings on v1-train?
> 
> Adding late-l10n for now.

Yes, the keyboard layout can be included in the "other latins" group which is localized.
(In reply to Mihai Cirlanaru [:mihai][:mcirlanaru] from comment #13)
> (In reply to Axel Hecht [:Pike] from comment #12)
> > Mihai, could this patch be adapated to not require new strings on v1-train?
> > 
> > Adding late-l10n for now.
> 
> Yes, the keyboard layout can be included in the "other latins" group which
> is localized.

Thanks, non-late-l10n then.
Keywords: late-l10n
The Romanian keyboard layout has been uplifted to v1-train through the patch for bug 907763.
status-b2g18: --- → fixed
tracking-b2g18: ? → ---
blocking-b2g: leo? → leo+

Comment 16

5 years ago
Verified fixed on 

Build ID: 20130827041201
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/328b3b8158ee
Gaia: 4b2f1a103d046c92d201e8fcfb1ae224f59e7cf1
Platform Version: 18.1

Necessary accented characters have now been added to the Romanian keyboard.  (i.e. „ ” « » î i ș s and – etc)
status-b2g18: fixed → verified

Updated

3 years ago
See Also: → bug 1145991
You need to log in before you can comment on or make changes to this bug.