889417 - New Firefox icon on taskbar/launchpad is smaller than both old icon and the other browsers' icon

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: new firefox icon with the other browsers' icon

The new Firefox icon on the Windows taskbar is smaller than the old icon and the other browsers' icon. I'm not sure if this is intentional, though.

I think that the new icon should be a little bit larger than current Beta's icon because the color became lighter. So, the contrast between the icon and taskbar may become lower. Therefore, perhaps, larger icon might look better.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: new firefox icon and old firefox icon

Comment 2

[Justin Dolske [:Dolske]]

Steven: should we make the logo bigger?

Comment 3

[Lukas Blakk [:lsblakk] use ?needinfo]

This is not Windows specific, I see a smaller-than-our-old-logo on Mac too.

Comment 4

[Stephen Horlander [:shorlander]]

Attachment: Make the Firefox 32 x 32 icon fill more space

(In reply to Justin Dolske [:Dolske] from comment #2)
> Steven: should we make the logo bigger?

The logo should always be bigger.

Beta patch for just the Official branding.

Comment 5

[Stephen Horlander [:shorlander]]

Attachment: Make all Branding 32 x 32 icons fill more space

Comment 6

[Stephen Horlander [:shorlander]]

Comment on attachment 778663 [details] [diff] [review]
Make the Firefox 32 x 32 icon fill more space

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 884011
User impact if declined: Smaller visual target on Taskbar
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky): Low risk icon swap. Alternative is just ship a slightly smaller icon for one release.
String or IDL/UUID changes made by this patch:

Comment 7

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 778663 [details] [diff] [review]
Make the Firefox 32 x 32 icon fill more space

Approved for Beta, let's get this fixed asap.  Also need this on other branches too so please land to central and nominate for Aurora.

Comment 8

[Stephen Horlander [:shorlander]]

Comment on attachment 778664 [details] [diff] [review]
Make all Branding 32 x 32 icons fill more space

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 884011
User impact if declined: Smaller visual target on Taskbar
Risk to taking this patch (and alternatives if risky): Low risk icon swap. Alternative is just ship a slightly smaller icon for one release.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 778663 [details] [diff] [review]
Make the Firefox 32 x 32 icon fill more space

https://hg.mozilla.org/releases/mozilla-beta/rev/1db960f50d2e

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 778664 [details] [diff] [review]
Make all Branding 32 x 32 icons fill more space

https://hg.mozilla.org/integration/mozilla-inbound/rev/c2dc8dbb77ef
https://hg.mozilla.org/releases/mozilla-aurora/rev/eef8b9e2fd52

Comment 11

[Cornel Ionce [:noni]]

Verified as fixed on Firefox 23 Beta 10 (build ID: 20130729175331)

User Agents:
Mozilla/5.0 (X11; Linux i686; rv:23.0) Gecko/20100101 Firefox/23.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:23.0) Gecko/20100101 Firefox/23.0
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:23.0) Gecko/20100101 Firefox/23.0

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c2dc8dbb77ef

Comment 13

[Elbart]

The 16x16 icon is still one pixel shorter than the old icon, and you can see the difference in comparison to the other icons in the taskbar.
http://i.imgur.com/0qF6dy7.png
left 23, right 22, enlarged to 1500%

Comment 14

[Ada [:adalucinet]]

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Firefox/24.0
Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Firefox/24.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:24.0) Gecko/20100101 Firefox/24.0

As per comment 13, I also confirm that the Firefox icon is still shorter: http://oi44.tinypic.com/k00qvk.jpg. Is this intended? 
If yes, I confirm the fix on Firefox 24 beta 7 (Build ID: 20130829135643).

Comment 15

[Ada [:adalucinet]]

Can anyone please answer my question in comment 14 ?

Comment 16

[:Gavin Sharp [email: [e-mail]]]

(In reply to Alexandra Lucinet, QA Mentor [:adalucinet] from comment #15)
> Can anyone please answer my question in comment 14 ?

Needinfo requests that don't have a specific requestee will be ignored. You need to always set a requestee.

Stephen can correct me if I'm wrong, but I don't think the height difference in comment 14 matters.

Comment 17

[Ada [:adalucinet]]

(In reply to :Gavin Sharp (use [e-mail] for email) from comment #16)

> Needinfo requests that don't have a specific requestee will be ignored. You
> need to always set a requestee.
Sorry, will do.

> Stephen can correct me if I'm wrong, but I don't think the height difference
> in comment 14 matters.
Stephen, what's your opinion?

Comment 18

[Stephen Horlander [:shorlander]]

(In reply to Alexandra Lucinet, QA Mentor [:adalucinet] from comment #17)
> > Stephen can correct me if I'm wrong, but I don't think the height difference
> > in comment 14 matters.
> Stephen, what's your opinion?

I think we are currently fine here.