Closed Bug 890204 Opened 6 years ago Closed 6 years ago

When using Personas on Mac, the title bar is overlaid by the tab bar on the standalone message window

Categories

(Thunderbird :: Theme, defect)

Product:
Thunderbird
Component:
Theme
Platform:
All
macOS
Type:
defect
Priority:
Not set

Tracking

(thunderbird24+ fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 25.0
Tracking Flags:
Tracking Status
thunderbird24 + fixed

People

(Reporter: standard8, Assigned: Paenglab)

References

Details

(Keywords: regression)

Attachments

(1 file)

patch
845 bytes, patch
bwinton
: review+
bwinton
: ui-review+
standard8
: approval-comm-aurora+
Details | Diff | Splinter Review 
We missed a window...

+++ This bug was initially created as a clone of Bug #876710 +++

When runnning with Personas on Mac, the tab bar goes up and over the title bar. If you run with the default theme, then everything is as expected with the tab bar underneath the title bar.
Attached patch patch — — Splinter Review 
:( this comes from never using this window.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #771467 - Flags: ui-review?(bwinton)
Attachment #771467 - Flags: review?(bwinton)
I tried to review this today, but couldn't load the personas site in my built copy, and when I updated, I was no longer able to build.  :(
Comment on attachment 771467 [details] [diff] [review]
patch

This fixes it, so ui-r=me.
And the code seems fine, so r=me, too.

Thanks, and sorry for the delay!
Blake.
Attachment #771467 - Flags: ui-review?(bwinton)
Attachment #771467 - Flags: ui-review+
Attachment #771467 - Flags: review?(bwinton)
Attachment #771467 - Flags: review+
Keywords: checkin-needed
Comment on attachment 771467 [details] [diff] [review]
patch

[Approval Request Comment]
This bug has tracking-thunderbird24+ and it should land to not regress the next ESR build.
Attachment #771467 - Flags: approval-comm-aurora?
https://hg.mozilla.org/comm-central/rev/82ac91515ee3
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 25.0
Attachment #771467 - Flags: approval-comm-aurora? → approval-comm-aurora+
You need to log in before you can comment on or make changes to this bug.