Closed Bug 876710 Opened 7 years ago Closed 6 years ago

When using Personas on Mac, the title bar is overlaid by the tab bar (Address book & Compose windows)

Categories

(Thunderbird :: Theme, defect)

All
macOS
defect
Not set

Tracking

(thunderbird23+ fixed, thunderbird24+ fixed)

RESOLVED FIXED
Thunderbird 24.0
Tracking Status
thunderbird23 + fixed
thunderbird24 + fixed

People

(Reporter: standard8, Assigned: Paenglab)

References

Details

(Keywords: regression)

Attachments

(1 file)

We also need this on the address book and compose windows...

+++ This bug was initially created as a clone of Bug #860406 +++

When runnning with Personas on Mac, the tab bar goes up and over the title bar. If you run with the default theme, then everything is as expected with the tab bar underneath the title bar.
Attached patch proposed fixSplinter Review
Unlike in main window I needed to add the padding-top to the toolbars. Adding the padding to the window ended with not dragable windows in this padding area.

Mike, from your draw in titlebar experience on FX, do you know why this it? And do you know a other solution?
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #754880 - Flags: ui-review?(mconley)
Attachment #754880 - Flags: review?(mconley)
Comment on attachment 754880 [details] [diff] [review]
proposed fix

Review of attachment 754880 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good! Thanks Richard!
Attachment #754880 - Flags: ui-review?(mconley)
Attachment #754880 - Flags: ui-review+
Attachment #754880 - Flags: review?(mconley)
Attachment #754880 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/cf3cf361bff3
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 24.0
Comment on attachment 754880 [details] [diff] [review]
proposed fix

[Triage Comment]
Moving forward to get some testing.
Attachment #754880 - Flags: approval-comm-aurora+
Blocks: 890204
You need to log in before you can comment on or make changes to this bug.