convolver node with gain (mVolume != 1.0) uses uninitialized samples
RESOLVED
FIXED
in Firefox 24
Status
()
People
(Reporter: karlt, Assigned: Ehsan)
Tracking
Firefox Tracking Flags
(firefox23 unaffected, firefox24+ fixed, firefox25+ fixed)
Details
(Whiteboard: [blocking-webaudio+])
Attachments
(1 attachment)
|
1.30 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
http://hg.mozilla.org/mozilla-central/annotate/a0c7e9f6c6be/content/media/webaudio/ConvolverNode.cpp#l143 Looks like we want s/AudioBlockAddChannelWithScale/AudioBlockCopyChannelWithScale/
|
(Assignee) | |
Comment 1•6 years ago
|
||
Yes, embarrassing mistake! Can you please take it?
|
|
(Assignee) | |
Updated•6 years ago
|
Blocks: webaudio
status-firefox24:
--- → affected
status-firefox25:
--- → affected
tracking-firefox24:
--- → ?
tracking-firefox25:
--- → ?
Whiteboard: [blocking-webaudio+]
|
||
Updated•6 years ago
|
|
|
(Assignee) | |
Comment 2•6 years ago
|
||
Attachment #777466 -
Flags: review?(roc) → review+
|
|
(Assignee) | |
Comment 3•6 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/58848bcf82e4
Whiteboard: [blocking-webaudio+] → [blocking-webaudio+][checkin-needed-aurora]
|
||
Comment 4•6 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/cf83a645ad58
Whiteboard: [blocking-webaudio+][checkin-needed-aurora] → [blocking-webaudio+]
|
|
||
Comment 5•6 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/58848bcf82e4
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
|
(Reporter) | |
Comment 6•6 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/91197b606141
Flags: in-testsuite+
|
|
(Reporter) | |
Comment 8•6 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/a3fc5c2ad853
You need to log in
before you can comment on or make changes to this bug.
Description
•