Closed Bug 891254 Opened 7 years ago Closed 7 years ago

convolver node with gain (mVolume != 1.0) uses uninitialized samples

Categories

(Core :: Web Audio, defect)

Product:
Core
Component:
Web Audio
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla25
Tracking Flags:
Tracking Status
firefox23 --- unaffected
firefox24 + fixed
firefox25 + fixed

People

(Reporter: karlt, Assigned: ehsan)

References

Details

(Whiteboard: [blocking-webaudio+])

Attachments

(1 file)

Patch (v1)
1.30 KB, patch
roc
: review+
Details | Diff | Splinter Review 
http://hg.mozilla.org/mozilla-central/annotate/a0c7e9f6c6be/content/media/webaudio/ConvolverNode.cpp#l143

Looks like we want s/AudioBlockAddChannelWithScale/AudioBlockCopyChannelWithScale/
Yes, embarrassing mistake!

Can you please take it?
Blocks: webaudio
status-firefox24: --- → affected
status-firefox25: --- → affected
tracking-firefox24: --- → ?
tracking-firefox25: --- → ?
Whiteboard: [blocking-webaudio+]
Attached patch Patch (v1) — — Splinter Review
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #777466 - Flags: review?(roc)
https://hg.mozilla.org/integration/mozilla-inbound/rev/58848bcf82e4
Whiteboard: [blocking-webaudio+] → [blocking-webaudio+][checkin-needed-aurora]
https://hg.mozilla.org/releases/mozilla-aurora/rev/cf83a645ad58
status-firefox24: affected → fixed
status-firefox25: affected → fixed
Whiteboard: [blocking-webaudio+][checkin-needed-aurora] → [blocking-webaudio+]
https://hg.mozilla.org/mozilla-central/rev/58848bcf82e4
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
Depends on: 911777
You need to log in before you can comment on or make changes to this bug.