If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

RTL support for bedrock firefox/new page

RESOLVED FIXED

Status

www.mozilla.org
Pages & Content
RESOLVED FIXED
4 years ago
2 years ago

People

(Reporter: pascalc, Assigned: kohei)

Tracking

(Blocks: 1 bug, {rtl})

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [kb=1252411] )

Attachments

(4 attachments)

(Reporter)

Description

4 years ago
The newer firefox/new page has layout bugs in RTL preventing pushing RTL translations to prod:
https://www-dev.allizom.org/b/fa/firefox/new/

We should also have a rtl screenshot ideally
Summary: RTL support for bedrock fireofx/new page → RTL support for bedrock firefox/new page

Comment 1

4 years ago
Is this the same issue for this locale?

https://www-dev.allizom.org/b/ur/firefox/new/

Updated

4 years ago
Blocks: 868199

Comment 2

4 years ago
Pascal: Given that our devs probably can't read RTL text, how should we proceed with making layout changes to acomodate these type of languages? 

Given that we are creating locale neutral screenshots, should we only be concerned about the /new layout?
Pascal - which RTL languages do we support other than Arabic?
And Hebrew.
(Reporter)

Comment 5

4 years ago
(In reply to Jennifer Bertsch [:jbertsch] from comment #3)
> Pascal - which RTL languages do we support other than Arabic?

ar, he, fa, ur
(Reporter)

Comment 6

4 years ago
(In reply to Chris More [:cmore] from comment #2)
> Pascal: Given that our devs probably can't read RTL text, how should we
> proceed with making layout changes to acomodate these type of languages? 
> 

I don't think that our devs read ltr text either (apart from English) :)

I can take this bug and work with out community on rtl adjustments needed.

> Given that we are creating locale neutral screenshots, should we only be
> concerned about the /new layout?

we need a screenshot for ltr (done) and a screenshot for rtl. The general layout of a rtl version of Firefox is vertically reversed compared to a ltr one.
I would be happy to provide RTL specific feedback on screenshots, etc.

Comment 8

4 years ago
(In reply to :Ehsan Akhgari (needinfo? me!) from comment #7)
> I would be happy to provide RTL specific feedback on screenshots, etc.

That would be great! Thanks.

Comment 9

4 years ago
Any update here on the RTL support?

Updated

4 years ago
No longer blocks: 868199

Updated

4 years ago
Blocks: 908297

Comment 10

4 years ago
Flod: Do you think we should have this block the release of the unified page or are you fine with leaving this RTL support open for future development?
Flags: needinfo?(francesco.lodolo)
It's definitely something we want to have but I don't think it needs to block the release.
Of those 4 locales only Arabic is in good shape from a product perspective, so we can work with them to fix the issues later (new strings are still missing, page is not enabled on production).
Flags: needinfo?(francesco.lodolo)
Hi Lee-

Do you have time to work with Ehsan on a "neutral" right-to-left lanugage browser chrome screenshot for /new?

Ehsan - Would you be able to provide a high resolution PC screenshot of a Fx browser to Lee?

Thanks,
Jen
Flags: needinfo?(ltom)
Flags: needinfo?(ehsan)
(In reply to Jennifer Bertsch [:jbertsch] from comment #12)
> Ehsan - Would you be able to provide a high resolution PC screenshot of a Fx
> browser to Lee?

I'm not 100% sure what this question means...  But if you want to see how an RTL browser looks like, you can install the <https://addons.mozilla.org/en-us/firefox/addon/force-rtl/> extension which lets you change the direction of the browser UI without changing its language.
Flags: needinfo?(ehsan)
(Reporter)

Comment 14

4 years ago
FYI, most of the rtl issues were fixed by css, the only missing part would be to have rtl screenshots.
(Assignee)

Updated

4 years ago
Blocks: 795286
Keywords: rtl
(Assignee)

Comment 15

4 years ago
Created attachment 8365762 [details] [review]
Pull request on GitHub

I sent a PR to fix the RTL layout except the screenshot.
Assignee: nobody → kohei.yoshino
Status: NEW → ASSIGNED
(Assignee)

Comment 16

4 years ago
Created attachment 8365763 [details]
post-fix screenshot
(Assignee)

Updated

4 years ago
Locale: ar / Arabic, he / Hebrew, ur / Urdu
Whiteboard: [kb=1252411]

Comment 17

4 years ago
Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/49fd9dbbc6602a536acce65279e9673a901ef49b
Fix Bug 891362 - RTL support for bedrock firefox/new page

https://github.com/mozilla/bedrock/commit/5e5b93b51ab9ebc4f1db39e120faefa05d0e9a19
Merge pull request #1627 from kyoshino/bug-891362-fx-new-rtl

Fix Bug 891362 - RTL support for bedrock firefox/new page

Updated

4 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
fixed on stage https://www.allizom.org/b/fa/firefox/new/
verified fixed on prod https://www.mozilla.org/fa/firefox/new/
Status: RESOLVED → VERIFIED
(Reporter)

Comment 20

4 years ago
Reopening, this is not fixed, the pull request only fixes CSS but the rtl screenshot is still missing
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
Created attachment 8371447 [details]
Firefox-27-0.png

Here is a screenshot from Firefox 27 with Persian enabled in my Linux box. I can provide more if you want to.
(Assignee)

Comment 22

4 years ago
Thanks. I'll try to create neutral RTL screenshots with Photoshop.
Status: REOPENED → ASSIGNED
(Assignee)

Comment 23

4 years ago
Created attachment 8373925 [details] [review]
Pull request to serve locale-neutral RTL screenshots
Flags: needinfo?(ltom)
(Assignee)

Updated

4 years ago
Depends on: 997302
(Assignee)

Updated

4 years ago
No longer depends on: 997302
(Assignee)

Comment 24

4 years ago
Australis screenshots are being prepared in Bug 977465. I can later make the RTL versions on my Photoshop.
Depends on: 977465
Kohei was this bug resolved or do we still need to add the RTL srceenshots?
Flags: needinfo?(kohei.yoshino)
(Assignee)

Comment 26

3 years ago
Sorry I forgot about this bug. Will photoshop RTL screenshots this weekend!
Flags: needinfo?(kohei.yoshino)
Is this one still open?
Flags: needinfo?(kohei.yoshino)
(Assignee)

Comment 28

2 years ago
Hmm, RTL screenshots are still nice to have, but given the Firefox UI sometimes changing, it may be difficult to maintain those images. Even the current LTR screenshots are already outdated...

I think we can just close this now.
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago2 years ago
Flags: needinfo?(kohei.yoshino)
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.