891362 - RTL support for bedrock firefox/new page

Status: RESOLVED FIXED

(www.mozilla.org :: Pages & Content, defect)

Description

[Pascal Chevrel:pascalc]

The newer firefox/new page has layout bugs in RTL preventing pushing RTL translations to prod:
https://www-dev.allizom.org/b/fa/firefox/new/

We should also have a rtl screenshot ideally

Comment 1

[Chris More [:cmore]]

Is this the same issue for this locale?

https://www-dev.allizom.org/b/ur/firefox/new/

Comment 2

[Chris More [:cmore]]

Pascal: Given that our devs probably can't read RTL text, how should we proceed with making layout changes to acomodate these type of languages? 

Given that we are creating locale neutral screenshots, should we only be concerned about the /new layout?

Comment 3

[Jennifer Bertsch [:jbertsch]]

Pascal - which RTL languages do we support other than Arabic?

Comment 4

[Jennifer Bertsch [:jbertsch]]

And Hebrew.

Comment 5

[Pascal Chevrel:pascalc]

(In reply to Jennifer Bertsch [:jbertsch] from comment #3)
> Pascal - which RTL languages do we support other than Arabic?

ar, he, fa, ur

Comment 6

[Pascal Chevrel:pascalc]

(In reply to Chris More [:cmore] from comment #2)
> Pascal: Given that our devs probably can't read RTL text, how should we
> proceed with making layout changes to acomodate these type of languages? 
> 

I don't think that our devs read ltr text either (apart from English) :)

I can take this bug and work with out community on rtl adjustments needed.

> Given that we are creating locale neutral screenshots, should we only be
> concerned about the /new layout?

we need a screenshot for ltr (done) and a screenshot for rtl. The general layout of a rtl version of Firefox is vertically reversed compared to a ltr one.

Comment 7

[(no longer active)]

I would be happy to provide RTL specific feedback on screenshots, etc.

Comment 8

[Chris More [:cmore]]

(In reply to :Ehsan Akhgari (needinfo? me!) from comment #7)
> I would be happy to provide RTL specific feedback on screenshots, etc.

That would be great! Thanks.

Comment 9

[Chris More [:cmore]]

Any update here on the RTL support?

Comment 10

[Chris More [:cmore]]

Flod: Do you think we should have this block the release of the unified page or are you fine with leaving this RTL support open for future development?

Comment 11

[Francesco Lodolo [:flod]]

It's definitely something we want to have but I don't think it needs to block the release.
Of those 4 locales only Arabic is in good shape from a product perspective, so we can work with them to fix the issues later (new strings are still missing, page is not enabled on production).

Comment 12

[Jennifer Bertsch [:jbertsch]]

Hi Lee-

Do you have time to work with Ehsan on a "neutral" right-to-left lanugage browser chrome screenshot for /new?

Ehsan - Would you be able to provide a high resolution PC screenshot of a Fx browser to Lee?

Thanks,
Jen

Comment 13

[(no longer active)]

(In reply to Jennifer Bertsch [:jbertsch] from comment #12)
> Ehsan - Would you be able to provide a high resolution PC screenshot of a Fx
> browser to Lee?

I'm not 100% sure what this question means...  But if you want to see how an RTL browser looks like, you can install the <https://addons.mozilla.org/en-us/firefox/addon/force-rtl/> extension which lets you change the direction of the browser UI without changing its language.

Comment 14

[Pascal Chevrel:pascalc]

FYI, most of the rtl issues were fixed by css, the only missing part would be to have rtl screenshots.

Comment 15

[Kohei Yoshino]

Attachment: Pull request on GitHub

I sent a PR to fix the RTL layout except the screenshot.

Comment 16

[Kohei Yoshino]

Attachment: post-fix screenshot

Comment 17

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/49fd9dbbc6602a536acce65279e9673a901ef49b
Fix Bug 891362 - RTL support for bedrock firefox/new page

https://github.com/mozilla/bedrock/commit/5e5b93b51ab9ebc4f1db39e120faefa05d0e9a19
Merge pull request #1627 from kyoshino/bug-891362-fx-new-rtl

Fix Bug 891362 - RTL support for bedrock firefox/new page

Comment 18

[raymond [:retornam] (inactive)]

fixed on stage https://www.allizom.org/b/fa/firefox/new/

Comment 19

[raymond [:retornam] (inactive)]

verified fixed on prod https://www.mozilla.org/fa/firefox/new/

Comment 20

[Pascal Chevrel:pascalc]

Reopening, this is not fixed, the pull request only fixes CSS but the rtl screenshot is still missing

Comment 21

[Arash Mousavi [:Arash-M]]

Attachment: Firefox-27-0.png

Here is a screenshot from Firefox 27 with Persian enabled in my Linux box. I can provide more if you want to.

Comment 22

[Kohei Yoshino]

Thanks. I'll try to create neutral RTL screenshots with Photoshop.

Comment 23

[Kohei Yoshino]

Attachment: Pull request to serve locale-neutral RTL screenshots

Comment 24

[Kohei Yoshino]

Australis screenshots are being prepared in Bug 977465. I can later make the RTL versions on my Photoshop.

Comment 25

[Mike Alexis [:malexis]]

Kohei was this bug resolved or do we still need to add the RTL srceenshots?

Comment 26

[Kohei Yoshino]

Sorry I forgot about this bug. Will photoshop RTL screenshots this weekend!

Comment 27

[Jennifer Bertsch [:jbertsch]]

Is this one still open?

Comment 28

[Kohei Yoshino]

Hmm, RTL screenshots are still nice to have, but given the Firefox UI sometimes changing, it may be difficult to maintain those images. Even the current LTR screenshots are already outdated...

I think we can just close this now.