891631 - [Fig] Browser toolbar sometimes overlaps about:home content

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect, P1)

Description

[Chenxia Liu [:liuche]]

Attachment: Screenshot: full-scrolled up about:home

The about:home pager title strip looks like it's hidden behind the urlbar (see screenshot)

STR:
1. Open some page.
2. Swipe close page.

Expected:
about:home screen loads normally

Actual:
See screenshot: about:home pager title strip is not visible, and appears to be hidden behind the url bar.

Comment 1

[:Margaret Leibovic]

I also just saw this on a cold start after an update. I suspect this might have something to do with the dynamic toolbar, like we're creating about:home while the toolbar is hidden.

Comment 2

[:Margaret Leibovic]

Updating the summary to make it more general.

Comment 3

[Sriram Ramasubramanian [:sriram]]

This might be related to the padding fix: https://hg.mozilla.org/projects/fig/file/tip/mobile/android/base/BrowserApp.java#l512

Comment 5

[Brian Nicholson (:bnicholson)]

Attachment: Fix saving browser toolbar instance state

Since our home page is now a view and not a fragment, we can just call setPadding() on it directly.

Comment 6

[Brian Nicholson (:bnicholson)]

For reference, you can look at bug 869411 and bug 878491 if you want for why saving these states was necessary to begin with.

Comment 7

[Brian Nicholson (:bnicholson)]

http://hg.mozilla.org/projects/fig/rev/635b940aae8d

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/635b940aae8d