No Safe Mode dialog after several startup failures

NEW
Unassigned

Status

()

Toolkit
Startup and Profile System
5 years ago
5 months ago

People

(Reporter: Scoobidiver (away), Unassigned)

Tracking

({regression, regressionwindow-wanted})

25 Branch
regression, regressionwindow-wanted
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

5 years ago
STR:
1. Create a new profile
2. Open Firefox
3. Kill Firefox within 10 seconds
4. Repeat steps 2 to 3 several times => No Safe Mode dialog

Expect results: Safe Mode dialog after two startup failures.

In Release, Beta and Aurora, the Restore Session window appears instead of the Safe Mode dialog so there are two regressions there.
Mozilla/5.0 (X11; Linux i686; rv:25.0) Gecko/20130801 Firefox/25.0

Could not reproduce on latest Nightly. I started firefox from command line and closed the process immediately (CTRL+C) and after a few tries (~5-10) the Safe Mode dialog appeared.
(Reporter)

Comment 2

5 years ago
I confirm that I get the Restore Session window in Aurora after two kills and nothing in Nightly even after several consecutive kills.
Indeed, if I get successive startup crashes, the dialog doesn't appear. But it does appear for me while following the steps from bug description.
I cannot use my testcase to find the regression range because it doesn't crash older versions of firefox, and I cannot reproduce with the provided STR.
Scoobidiver, can you please work on finding a regression range?
Flags: needinfo?(scoobidiver)
(Reporter)

Comment 4

5 years ago
(In reply to Mihaela Velimiroviciu [QA] (:mihaelav) from comment #3)
> Scoobidiver, can you please work on finding a regression range?
mozregression doesn't work when Firefox need to be killed several times.
Flags: needinfo?(scoobidiver)
(In reply to Scoobidiver from comment #4)
> (In reply to Mihaela Velimiroviciu [QA] (:mihaelav) from comment #3)
> > Scoobidiver, can you please work on finding a regression range?
> mozregression doesn't work when Firefox need to be killed several times.

Yes, I know...you need to do it manually: download builds, install and try to reproduce.
Duplicate of this bug: 1095799
Duplicate of this bug: 1012715
This issue has turned up a few times from what I can see, so it would be interesting to know if people are still able to consistently reproduce.

Comment 9

2 years ago
(In reply to Ryan VanderMeulen [:RyanVM] from comment #8)
> This issue has turned up a few times from what I can see, so it would be
> interesting to know if people are still able to consistently reproduce.

I can still reproduce this with the latest build of nightly on a clean profile. 51.0a1 (2016-09-14)
I just tested the STR and I got the dialog after 3 or 4 crashes (wasn't keeping track).

One thing to keep in mind is that MAX_STARTUP_BUFFER is 10 seconds [1] so if you are crashing and restarting too quickly we won't trigger startup crash detection. Perhaps this is too long since users may experience a crash and restart in less than 10 seconds.

[1] https://dxr.mozilla.org/mozilla-central/search?q=MAX_STARTUP_BUFFER

Comment 11

2 years ago
If this MAX_STARTUP_BUFFER doesn't come into effect before 10 seconds and people are experiencing crashes before that time won't get the dialog, this surely needs to be reduced/changed so that it is shown so users can start in safe mode. Is there any downsides of having it shown after 3/4 crashes withing 10 seconds anyway?

Comment 12

5 months ago
ref bug 664057
You need to log in before you can comment on or make changes to this bug.