Closed Bug 894396 Opened 7 years ago Closed 7 years ago

Work - Extra space before the sugestion entries in the input suggestions pop-up

Categories

(Firefox for Metro Graveyard :: Input, defect, P3)

x86
Windows 8
defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 27

People

(Reporter: mihaelav, Assigned: rsilveira)

References

Details

(Whiteboard: [preview] feature=work)

Attachments

(2 files)

Mozilla/5.0 (Windows NT 6.2; rv:25.0) Gecko/20130715 Firefox/25.0

There is some blank space at the beginning of the suggestions in the input suggestions pop-up box.

Steps:
1. Go to facebook.com
2. Log in
3. Log out
4. Start typing again the same email address as in step 2

Expected result: Input suggestions pop-up box appears containing the email address from step 2. There is no extra blank space.

Actual result: There is some blank space before the email address.
See attached screenshot.

This is a regression since April the 8th:
Last good nightly: 2013-04-07
First bad nightly: 2013-04-08

Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=be3be63607b0&tochange=b0d842380959
Whiteboard: feature=defect c=tbd u=tbd p=0
There doesn't appear to be a screenshot attached? Could you attach it?
Flags: needinfo?(mihaela.velimiroviciu)
Priority: -- → P2
Attached image fb-login-bug.jpg
Here's what I see on a standard DPI screen with today's nightly build on 8.0. It looks OK to me.
Because :mihaelav tracked down a regression window, leaving open until we hear back.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Blocks: 855434
Whiteboard: feature=defect c=tbd u=tbd p=0 → feature=defect c=Content_features u=metro_firefox_user p=0
No longer blocks: metrov1defect&change
Summary: Defect - Extra space before the sugestion entries in the input suggestions pop-up → Work - Extra space before the sugestion entries in the input suggestions pop-up
Whiteboard: feature=defect c=Content_features u=metro_firefox_user p=0 → feature=work
Attached image fb_login.jpg
This is how I see it in Metro mode on latest Nightly:  Mozilla/5.0 (Windows NT 6.2; rv:25.0) Gecko/20100101 Firefox/25.0, build ID 20130804030207
Flags: needinfo?(mihaela.velimiroviciu)
Blocks: 898833
Whiteboard: feature=work → feature=work [preview-triage]
Whiteboard: feature=work [preview-triage] → [Metro Preview] feature=work
Whiteboard: [Metro Preview] feature=work → [preview] feature=work
Left margin in the popup looks fine to me, but truncation/elipsis isn't happening and the result is the suggestions go right up to the right edge with no margin and are clipped. So there's still something wrong here. Its usable not pretty though and could use tightening up. 
p=2 at a guess though could turn out to be p=1
Priority: P2 → P3
Blocks: 918225
I think the patch in bug 918225 will fix the extra space before the menu entries (which shows up only when the "left hand" option is enabled in the Tablet PC Options control panel).
No longer blocks: 918225
Depends on: 918225
The extra space to the left should now be fixed by bug 918225.
Status: REOPENED → RESOLVED
Closed: 7 years ago7 years ago
Resolution: --- → FIXED
Assignee: nobody → rsilveira
Target Milestone: --- → Firefox 27
You need to log in before you can comment on or make changes to this bug.