895284 - Defect - Three different monocles appearing at the same time

Status: VERIFIED FIXED

(Firefox for Metro Graveyard :: Input, defect, P2)

Description

[Kamil Jozwiak [:kjozwiak]]

Attachment: three monocles being displayed

When selecting text in the URL bar, you will receive three different monocles at the same time rather then either:
- The double monocles with text selected in the middle
- The single selection monocle

- Attached a screenshot to illustrate the issue

Steps to reproduce the issue:

1) Open Firefox Metro
2) Go to wikipedia.org
2) Tap on the URL bar, the OSK should also slide in
3) Tap on the text inside the URL bar and select some text using the single monocle (at this time, you should see two monocles between the selected text)
4) Tap anywhere on the word and you will notice that three monocles will bevisible at the same time

Current Behavior:

- Selecting text and then tapping on the text again once you have two monocles on the screen will produce a third monocle, making all three monocles visible

Expected Behavior:

- When tapping on the text, it should clear the two monocles and only display the single selection monocle. Once the user selects the text again, the two monocles will appear (shouldn't be three on the screen)

Comment 1

[Jim Mathies [:jimm]]

confirming, I can reproduce.

Comment 2

[Jim Mathies [:jimm]]

Attachment: fix

Comment 3

[Jim Mathies [:jimm]]

Comment on attachment 777720 [details] [diff] [review]
fix

Fix plus a test. The issue here is that we were sending the Browser:CaretAttach message directly. The method attachToCaret does the same thing while also taking care of hiding the monocles in anticipation of a mode change.

Comment 4

[Jonathan Wilde [:jwilde]]

Comment on attachment 777720 [details] [diff] [review]
fix

Review of attachment 777720 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Everything seems to work well on HiDPI, too.

Comment 5

[Jim Mathies [:jimm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d0d492aa6e63

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d0d492aa6e63

Comment 7

[Samvedana (:Samvedana)]

User Agent: Mozilla/5.0 (Windows NT 6.2; Win64; x64; rv:25.0) Gecko/20100101 Firefox/25.0
Build ID: 20130805030205

WFM
Tested on Windows 8 for iteration-11 using latest nightly built from http://hg.mozilla.org/mozilla-central/rev/482b9d04974a

I followed steps provided in comment0 and got expected result

When tapped on the text, it cleared the two monocles and only displayed the single selection monocle. When I selected text again, the two monocles appeared.

Comment 8

[Samvedana (:Samvedana)]

Mozilla/5.0 (Windows NT 6.2; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0
Build ID: 20130815030203
Built from http://hg.mozilla.org/mozilla-central/rev/a8daa428ccbc

WFM
Tested on windows 8 using latest nightly for iteration-12. Followed steps provided in comment0 and got expected result.

Comment 9

[Kamil Jozwiak [:kjozwiak]]

Went through the following "Defect" for iteration #13 without any issues. Used the following build:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-09-09-03-02-04-mozilla-central/

- Went through the original test case added in comment #0 without any issues
- Selected the URL and received two monocles, tapped on it again and ensured both where cleared and only a single monocle appeared rather then three
- Tapped on the URL under the Navigation App Bar and ensured that I received a single monocle, tapped the URL several times and ensured that only a single monocle was available for selection
- Ensured that all of the above test cases worked in both full & filled views without any issues