897015 - B2G Emulator: support switching preferred network type in console command

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Edgar Chen [:edgar]]

Currently the preferred Network Type is GSM/WCDMA, so it is failed to switch to cdma by using 'modem tech' console command.
To fix this, maybe we could consider to make 'modem tech' can also support switching preferred network type.

Comment 1

[Edgar Chen [:edgar]]

To support switching preferred network type, I extent 'modem tech' command as below:

* 'modem tech': allows you to display the current state of emulator modem.

* 'modem tech <technology>': allows you to change the technology of emulator modem.

* 'modem tech <technology> <mask>': allows you to change the technology and preferred mask of emulator modem.

Comment 2

[Edgar Chen [:edgar]]

Attachment: external/qemu pull request #42

Comment 3

[Vicamo Yang [:vicamo][:vyang]]

Commented on GitHub.

Comment 4

[Edgar Chen [:edgar]]

Comment on attachment 780160 [details]
external/qemu pull request #42

(In reply to Vicamo Yang [:vicamo][:vyang] from comment #3)
> Commented on GitHub.

Cancel review based on the review comment in github. I will request review again when the new patch is ready. thanks.

Comment 5

[Edgar Chen [:edgar]]

Comment on attachment 780160 [details]
external/qemu pull request #42

Update new patchtes in github, request review again.

Comment 6

[Vicamo Yang [:vicamo][:vyang]]

(In reply to Edgar Chen [:edgar][:echen] from comment #5)
> Comment on attachment 780160 [details]
> external/qemu pull request #42
> 
> Update new patchtes in github, request review again.

Have a unused variable 'nn'.  Mind having another minor fix?

Comment 7

[Edgar Chen [:edgar]]

(In reply to Vicamo Yang [:vicamo][:vyang] from comment #6)
> (In reply to Edgar Chen [:edgar][:echen] from comment #5)
> > Comment on attachment 780160 [details]
> > external/qemu pull request #42
> > 
> > Update new patchtes in github, request review again.
> 
> Have a unused variable 'nn'.  Mind having another minor fix?

Sure, I will fix it. Thanks

Comment 8

[Vicamo Yang [:vicamo][:vyang]]

Merged on GitHub: https://github.com/mozilla-b2g/platform_external_qemu/commit/38a125bf09a8c16847eb523e2294a41922a20c71