897600 - [User Story] Sign In To Firefox on First Run

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

Description

[Peter Dolanjski [:pdol]]

User Story:

As a user, I want to be able to set up a Firefox account or login using an existing Persona account during the First Run Experience so that I don’t need to do this when going to purchase an app in Marketplace (removes barrier to purchase). 


Acceptance Criteria:

1. During the First Run Experience, if I do not currently have a Firefox or Persona account, I can create one and I will be signed in using it which will take me to the next step in the First Run Experience.
2. During the First Run Experience, if I already have a Firefox or Persona account, I can log in using this account using my email address and password, after which I am taken me to the next step in the First Run Experience.
3. During the First Run Experience, if I already have a Firefox or Persona account, but I have forgotten the password, I am able to reset my password by having an email sent to me with a link to reset my password.  
4. Once my password is reset (using another device), I can enter my Firefox or Persona email/password and I am taken to the next step in the First Run Experience.

Comment 1

[Peter Dolanjski [:pdol]]

More acceptance criteria:
5. After completing the First Run step prior to the first account creation/sign in screen, if my device does not have data connectivity, the Sign In To Firefox is skipped, entirely, when I advance to the next screen.
6. If my device drops connectivity while in the process of creating an account/signing in, I am made aware the of the lack of connectivity and asked to sign in later through the Marketplace app or through Settings (assuming this is implemented) and am skipped to the next screen in the First Run.

Comment 2

[Francis Djabri [:djabber]]

Attachment: First_Use_Sign-in_v0.9.pdf

Wireframe attached. Note acceptance criteria 3 & 4 are not met.

Comment 3

[Peter Dolanjski [:pdol]]

(In reply to Francis Djabri [:djabber] from comment #2)
> Wireframe attached. Note acceptance criteria 3 & 4 are not met.

Please ignore acceptance criteria 3 & 4.  Password reset will not be considered during this flow at this time.

Comment 4

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

We are currently targeting this feature for v1.3

Comment 5

[Fernando Jiménez Moreno [:ferjm]]

Attachment: WIP

This WIP simple patch adds the Persona step to the FTU, with the following differences from the UX spec attached to the bug:

1- As the dev team agreed during the Oslo work week, the FTU page will be a Persona RP, which means that the Persona flow will not be completely integrated in the FTU UI and will look like a hosted flow (as it actually is). The main reasons to do this are: A. Technical issues.  B. The Persona flow is a remotely hosted one, which means that its load speed mostly depends on the network speed. If we provide an UI that looks like local content but we take several seconds to load it, we will be providing a bad UX IMHO. Instead, we need to provide feedback about the remote nature of the Persona flow. The situation is pretty similar to the Facebook authentication flow from the contacts import step, where we open an additional window to load the Facebook login flow.

2- The Persona step is placed right before the contacts import one. The reason for this change is that, in the future, contacts providers like Gmail or Facebook might be Persona RPs, so we might be able to consume the Persona login while doing the contacts import.

Comment 6

[John Gruen [:jgruen]]

Attachment: Alternate Flow Versions for FTE

Comment 7

[John Gruen [:jgruen]]

Attachment: WIP update to FTE Flow

Comment 8

[John Gruen [:jgruen]]

Attachment: WIP FxA Flow (Deprecates Previous)

Comment 9

[John Gruen [:jgruen]]

Attachment: FTE_Sign_In_2013_30_10.pdf

Flow showing sign in/create account flows + email verification.

Comment 10

[John Gruen [:jgruen]]

Attachment: FTE Sign In v.10 10-30-2013

Fixes a few minor flow errors + typos in previous

Comment 11

[John Gruen [:jgruen]]

Attachment: FTE_Sign_In_2013_13_11_ver_0.11.pdf

All changes from v.10 are marked with giant red arrows and text.

Comment 12

[Jean Gong :jgong]

updated UCID to match backlog google doc.

Comment 13

[Shane Tomlinson [:stomlinson]]

https://github.com/mozilla-b2g/gaia/pull/14618

Comment 14

[Borja Salguero [:borjasalguero]]

Attachment: Pull request

Waiting to FxA Core landed to review this!

Comment 15

[Borja Salguero [:borjasalguero]]

Shane, I've attached your PR as a patch to the bug! :). Please remember to do this when delivering your code! I've given you feedback +, and the review will wait until having FxA Module landed. THanks!

Comment 16

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Marking as a duplicate of the new 1.4 bug 949063. Sam, feel free to reopen if I'm too quick on the trigger here.

Comment 17

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Reopening to avoid having to resubmit review as mentioned by :borjasalguero[1].

[1] https://github.com/mozilla-b2g/gaia/pull/14618#issuecomment-32043616

Comment 20

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Hey Borja - What is blocking merging this patch in? Are we still waiting for a specific gecko patch to land?

Comment 21

[Borja Salguero [:borjasalguero]]

Yep. There are some pending things that Im sorting out. I'll try to upload a patch today.

Comment 23

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Sounds great. Please let me know if there's anything I can do to help (in case you're busy with other things)

Comment 24

[Borja Salguero [:borjasalguero]]

Attachment: Final patch

This final patch contains the great job done by Shane and Jared. I've merged some changes needed and udpated to pass all tests.
Now this functionality could be disabled by a setting.

Comment 25

[Borja Salguero [:borjasalguero]]

Comment on attachment 8378933 [details] [review]
Final patch

Moving the review due to Fernando is quite busy right now.

Comment 26

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8378933 [details] [review]
Final patch

Hi Borja,

Great job as always!

Despite that I like the idea of having some steps accepting settings, to enable them, don't like to refer always to the 'settings cache'.

Prefer to keep attributes with a meaning, that will increase readability a lot. i.e. for me is much more meaningful read |this.simMandatory| than |this.settingsCache['ftu.sim.mandatory']|, perhaps what we can do is keep that key on the steps, but apply a transformation, so 'ftu.sim.mandatory', end up in an attribute like |simMandatory| same for 'identity.fxaccounts.ui.enabled' could end up in |fxaccountsUiEnabled|.

WDYT?

Comment 27

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Comment on attachment 8378933 [details] [review]
Final patch

Nice work, borja! Great to see you hacking on gaia again :-)

This code is still kinda unfamiliar, thanks for the f?, read it and looks good. Looks like you're on the review, but ping me if I can help with anything in particular.

Comment 28

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 8378933 [details] [review]
Final patch

Thanks Borja! Make sure that Travis is happy with this patch before landing, please.

Comment 29

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8378933 [details] [review]
Final patch

Could you rebase?

So far I downloaded the branch by itself, tried and working for me.

r+

An amazing job guys.

Comment 30

[Borja Salguero [:borjasalguero]]

https://github.com/borjasalguero/gaia/commit/e5d343543ff5b47c7d06c9a1713956585be5651c
https://github.com/mozilla-b2g/gaia/commit/70978988d048737b1379f5452a679429dadcd35f

R+. Travis shows 2 errors *NOT* related with this patch, due to this patch _only_ modifies FTU, and errors are related with Contacts and LockScreen.

Merged.

Comment 31

[Gabriele Svelto [:gsvelto]]

(In reply to Borja Salguero [This week out of Gaia][:borjasalguero] from comment #30)
> https://github.com/borjasalguero/gaia/commit/
> e5d343543ff5b47c7d06c9a1713956585be5651c

I've noticed that this change introduces a new PNG file which doesn't appear to have been recompressed before inclusion. Please do so in a follow-up (or as part of this bug) using the png_recompress.sh script available in the gaia sources, you'll need the advancecomp and optipng packages installed on your machine. Example command from gaia's top-level directory:

./tools/png_recompress.sh -v apps/communications/ftu/css/images/fxa_logo.png

Comment 32

[No-Jun Park [:njpark]]

MozTrap location:
https://moztrap.mozilla.org/manage/case/12860/