897782 - [Bluetooth][Gecko] Support Multiple BT file transfering

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect, P1)

Description

[sync-1]

AU_LINUX_GECKO_ICS_STRAWBERRY.01.01.00.019.158
 Firefox os  v1.1
 Mozilla build ID:20130709070206
 
 Created an attachment (id=468352)
 Images
 
 DEFECT DESCRIPTION:
 Can't send files to other BT device while receiving files via bluetooth from a remote device.
 
 REPRODUCING PROCEDURES:
 1)switch on bluetooth from settings menu->receive files from a remote bluetooth device A;
 2)enter  gallery/music/video->select a file share via bluetooth;
 3)on device select screen->choose a paired device B and press OK->it prompts can't send files message;(refer to attachment pic)-->KO
 Notes:
 while receiving finished, it can send files normally without any other operations.
 
 EXPECTED BEHAVIOUR:
 KO:it should can send files to other device normally while receiving files via BT.
 
 ASSOCIATE SPECIFICATION:
 
 TEST PLAN REFERENCE:
 
 TOOLS AND PLATFORMS USED:
 
 USER IMPACT:
 Moderate
 
 REPRODUCING RATE:
 5/5
 
 For FT PR, Please list reference mobile's behavior:

Comment 1

[sync-1]

Clone from brother

Comment 2

[sync-1]

Attachment: 493700.Kernel log&logcat log

Comment 3

[sync-1]

Clone from brother

Comment 4

[sync-1]

Attachment: 493700.Kernel log& logcat log

Comment 5

[Lukas Blakk [:lsblakk] use ?needinfo]

This sounds like enhancement/feature work for BT in upcoming versions and not a blocker for v1.1 at this point.

Comment 6

[Eric Chou [:ericchou] [:echou]]

I've handed this over to Ben.

Comment 7

[Ben Tian (inactive)]

Attachment: Patch 1 ( v1): Queue SendFile requests if socket is in use.

Current gecko patch that queues SendFile requests in opp manager.

Comment 8

[Ben Tian (inactive)]

Attachment: Patch 2: Gaia calls SendFile only

A testing gaia patch that calls SendFile only to transfer files.

Comment 9

[Ben Tian (inactive)]

Attachment: Patch 1 (v2): Queue SendFile requests

Remove all BluetoothReply.

Comment 10

[Ben Tian (inactive)]

Attachment: Patch 1 (v3): Queue SendFile requests

Add OnConnectError handling that notifies gaia of failed file transfers.

Comment 11

[Joe Cheng [:jcheng] (please needinfo)]

add to backlog 905585 for BT multiple file transfer feature

Comment 12

[Ben Tian (inactive)]

Attachment: Patch 1 (v1): decouple opp mgr and profile controller

This is a follow-up patch of bug 932192's fix. This patch decouples OPP manager from profile controller.

Changes:
- Empty Connect, Disconnect, OnConnect, and OnDisconnect functions in OPP manager
- Remove OPP part in profile controller

Comment 13

[Eric Chou [:ericchou] [:echou]]

Comment on attachment 826640 [details] [diff] [review]
Patch 1 (v1): decouple opp mgr and profile controller

Review of attachment 826640 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with nits addressed.

::: dom/bluetooth/BluetoothOppManager.cpp
@@ +1541,5 @@
>  void
> +BluetoothOppManager::Connect(const nsAString& aDeviceAddress,
> +                             BluetoothProfileController* aController)
> +{
> +  // No use

Please MOZ_ASSERT(false) to detect unexpected calls.

@@ +1547,5 @@
> +
> +void
> +BluetoothOppManager::Disconnect(BluetoothProfileController* aController)
> +{
> +  // No use

Ditto.

@@ +1555,3 @@
>  BluetoothOppManager::OnConnect(const nsAString& aErrorStr)
>  {
> +  // No use

Ditto.

@@ +1559,5 @@
>  
>  void
>  BluetoothOppManager::OnDisconnect(const nsAString& aErrorStr)
>  {
> +  // No use

Ditto.

Comment 14

[Ben Tian (inactive)]

Attachment: [final] Patch 1: decouple opp mgr and profile controller, r=echou

try server link: https://tbpl.mozilla.org/?tree=Try&rev=d1fb181b9449

Comment 15

[Eric Chou [:ericchou] [:echou]]

https://hg.mozilla.org/integration/b2g-inbound/rev/e87c7a3d7de0

Comment 16

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e87c7a3d7de0