Closed
Bug 898136
Opened 8 years ago
Closed 6 years ago
Remove nsIDOMGlobalObjectConstructor
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
DUPLICATE
of bug 1089811
mozilla25
People
(Reporter: emk, Assigned: emk)
References
Details
(Keywords: addon-compat)
Attachments
(1 file)
5.55 KB,
patch
|
mrbkap
:
review+
|
Details | Diff | Splinter Review |
Not used anymore. New APIs should use JS-implemented WebIDL.
Assignee | ||
Comment 1•8 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=5fb95d77afb5
Assignee | ||
Comment 2•8 years ago
|
||
Assignee | ||
Updated•8 years ago
|
Attachment #781282 -
Flags: review?(mrbkap)
Comment 3•8 years ago
|
||
Comment on attachment 781282 [details] [diff] [review] patch r=me assuming no extensions are using this. Do we need dev-doc-needed here?
Attachment #781282 -
Flags: review?(mrbkap) → review+
Assignee | ||
Updated•8 years ago
|
Keywords: dev-doc-needed
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Comment 4•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/9c6dc3897c17
Assignee: nobody → VYV03354
Keywords: checkin-needed
Comment 5•8 years ago
|
||
(In reply to Blake Kaplan from comment #3) > r=me assuming no extensions are using this. SeaMonkey is using this. http://mxr.mozilla.org/comm-central/source/suite/feeds/src/FeedWriter.js#1072 Unless you know another way of getting the window object...
Assignee | ||
Comment 6•8 years ago
|
||
Backed out: https://hg.mozilla.org/integration/mozilla-inbound/rev/c84673c64f39
https://hg.mozilla.org/mozilla-central/rev/9c6dc3897c17
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
Assignee | ||
Comment 8•8 years ago
|
||
(In reply to neil@parkwaycc.co.uk from comment #5) > SeaMonkey is using this. > > http://mxr.mozilla.org/comm-central/source/suite/feeds/src/FeedWriter.js#1072 > > Unless you know another way of getting the window object... nsIFeedWriter::Init()? https://mxr.mozilla.org/mozilla-central/source/browser/components/feeds/src/FeedWriter.js#1126
Comment 9•8 years ago
|
||
Let me double-check but I think we ran into some funkiness because we were creating the object from chrome XBL attached to a content page.
Comment 10•8 years ago
|
||
I originally thought you were suggesting that we implement nsIFeedWriter, but do you really mean that we should be implementing nsIDOMGlobalPropertyInitializer instead (does that even work for constructors?)
Comment 11•8 years ago
|
||
Whoops, I was confusing it with nsIJSNativeInitializer.
Comment 12•8 years ago
|
||
Hmm, I guess we can convert the code to be a global property rather than a global constructor, although then it would get created when anyone looked at the property, rather than having to be explicitly created as it is now.
Assignee | ||
Comment 13•8 years ago
|
||
(In reply to neil@parkwaycc.co.uk from comment #10) > I originally thought you were suggesting that we implement nsIFeedWriter, > but do you really mean that we should be implementing > nsIDOMGlobalPropertyInitializer instead (does that even work for > constructors?) I mean that we should convert it to WebIDL bindings if WebIDL-bound objects are available on users of FeedWriter.js. If not available, we will have to wait until bug 890364. See also bug 851178.
Comment 14•8 years ago
|
||
This was backed out and apparently never commented as such in the bug... https://hg.mozilla.org/mozilla-central/rev/c84673c64f39
Comment 15•8 years ago
|
||
Missed comment 6. Anyway, better to add a [leave open] to the whiteboard when backing out prior to it even hitting m-c :-)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 16•8 years ago
|
||
(In reply to Masatoshi Kimura from comment #13) > I mean that we should convert it to WebIDL bindings Are non-libxul components even able to use WebIDL? As I understand it, all of the WebIDL bindings have to be linked into libxul in advance and the contracts hard-coded in.
Assignee | ||
Comment 17•8 years ago
|
||
(In reply to neil@parkwaycc.co.uk from comment #16) > (In reply to Masatoshi Kimura from comment #13) > > I mean that we should convert it to WebIDL bindings > Are non-libxul components even able to use WebIDL? As I understand it, all > of the WebIDL bindings have to be linked into libxul in advance and the > contracts hard-coded in. Hm, I thought the only requirement for JS-implemented WebIDL was adding FeedWriter.webidl in the Core side. Luckily Firefox and SeaMonkey share the same contract id for the ndIFeedWriter implementation.
Comment 18•8 years ago
|
||
Added: https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/25/Site_Compatibility
Assignee | ||
Comment 19•8 years ago
|
||
The interface itself has been restored (see comment #6). But "GlobalObjectConstructor" has been removed from the global anyway because of bug 898817. Add-ons and non-Firefox apps will be able to access the interface through Components.interfaces (and it is the documented way. The global "GlobalObjectConstructor" has never been documented.)
Keywords: dev-doc-complete → dev-doc-needed
Assignee | ||
Comment 20•8 years ago
|
||
Also, site cannot use this interface. Existence check will be covered by bug 898817.
Keywords: site-compat
Assignee | ||
Comment 21•6 years ago
|
||
Bug 1089811 has the latest patch. duping forward.
Status: REOPENED → RESOLVED
Closed: 8 years ago → 6 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 1089811
Updated•6 years ago
|
Keywords: dev-doc-needed
Updated•2 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•