Closed
Bug 898817
Opened 11 years ago
Closed 11 years ago
Stop exposing nsIDOM* interfaces on the global automatically
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla25
People
(Reporter: emk, Assigned: emk)
References
Details
(Keywords: dev-doc-complete, site-compat)
Attachments
(2 files, 1 obsolete file)
14.08 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
7.68 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
This will cleanup useless junks on the global.
Attachment #782221 -
Flags: review?(bugs)
Assignee | ||
Comment 1•11 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=30a286f813f0
Comment 2•11 years ago
|
||
Comment on attachment 782221 [details] [diff] [review] patch I think we should do this, but also think that peterv or bz should review this change. Could you provide a list of things this removes from global.
Attachment #782221 -
Flags: review?(bugs) → review?(peterv)
Comment 3•11 years ago
|
||
Does dom/tests/mochitest/general/test_interfaces.html need to be updated to remove the interfaces that that are no longer exposed? That would prevent regressions.
Comment 4•11 years ago
|
||
Also, at a minimum the comment in there should be update.
Comment 5•11 years ago
|
||
Yes, it should be updated.
Assignee | ||
Comment 6•11 years ago
|
||
This patch will serve a purpose of unexposed interface list.
Assignee | ||
Comment 7•11 years ago
|
||
The previous patch failed to resolve conflict with bug 898687.
Attachment #782316 -
Attachment is obsolete: true
Attachment #782316 -
Flags: review?(peterv)
Attachment #782318 -
Flags: review?(peterv)
Updated•11 years ago
|
Attachment #782221 -
Flags: review?(peterv) → review?(bzbarsky)
Updated•11 years ago
|
Attachment #782318 -
Flags: review?(peterv) → review?(bzbarsky)
Comment 8•11 years ago
|
||
I switched the review to bz because peterv is currently on vacation.
Comment 9•11 years ago
|
||
Ah, indeed. I thought he was coming back sooner.
Comment 10•11 years ago
|
||
Comment on attachment 782318 [details] [diff] [review] test_interfaces.html update Don't we want CSSUnknownRule.
Assignee | ||
Comment 11•11 years ago
|
||
(In reply to Olli Pettay [:smaug] from comment #10) > Comment on attachment 782318 [details] [diff] [review] > test_interfaces.html update > > Don't we want CSSUnknownRule. CSSOM does not define CSSUnknownRule anymore. http://dev.w3.org/csswg/cssom/ Also, neither IE11 nor Chrome define CSSUnknownRule. Web do not require the interface.
Comment 12•11 years ago
|
||
Comment on attachment 782221 [details] [diff] [review] patch r=me
Attachment #782221 -
Flags: review?(bzbarsky) → review+
Comment 13•11 years ago
|
||
Comment on attachment 782318 [details] [diff] [review] test_interfaces.html update "ParserJS" can go away too, right?
Attachment #782318 -
Flags: review?(bzbarsky) → review+
Assignee | ||
Comment 14•11 years ago
|
||
(In reply to Boris Zbarsky (:bz) from comment #13) > Comment on attachment 782318 [details] [diff] [review] > test_interfaces.html update > > "ParserJS" can go away too, right? "ParserJS" was already removed by bug 816410, but I'll remove it while I'm here.
Assignee | ||
Comment 15•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/2480ee8346d6 https://hg.mozilla.org/integration/mozilla-inbound/rev/a8762aa7ab20
Flags: in-testsuite+
Comment 16•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/2480ee8346d6 https://hg.mozilla.org/mozilla-central/rev/a8762aa7ab20
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
Comment 17•11 years ago
|
||
Added to the site compatibility doc just in case: https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/25/Site_Compatibility
Keywords: dev-doc-complete,
site-compat
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•