Stop exposing nsIDOM* interfaces on the global automatically

RESOLVED FIXED in mozilla25

Status

()

Core
DOM
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: emk, Assigned: emk)

Tracking

({dev-doc-complete, site-compat})

unspecified
mozilla25
dev-doc-complete, site-compat
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

4 years ago
Created attachment 782221 [details] [diff] [review]
patch

This will cleanup useless junks on the global.
Attachment #782221 - Flags: review?(bugs)
(Assignee)

Comment 1

4 years ago
https://tbpl.mozilla.org/?tree=Try&rev=30a286f813f0

Comment 2

4 years ago
Comment on attachment 782221 [details] [diff] [review]
patch

I think we should do this, but also think that peterv or bz should review this change.

Could you provide a list of things this removes from global.
Attachment #782221 - Flags: review?(bugs) → review?(peterv)
Does dom/tests/mochitest/general/test_interfaces.html need to be updated to remove the interfaces that that are no longer exposed?  That would prevent regressions.
Also, at a minimum the comment in there should be update.

Comment 5

4 years ago
Yes, it should be updated.
(Assignee)

Comment 6

4 years ago
Created attachment 782316 [details] [diff] [review]
test_interfaces.html updatebug898817_test

This patch will serve a purpose of unexposed interface list.
Assignee: nobody → VYV03354
Status: NEW → ASSIGNED
Attachment #782316 - Flags: review?(peterv)
(Assignee)

Comment 7

4 years ago
Created attachment 782318 [details] [diff] [review]
test_interfaces.html update

The previous patch failed to resolve conflict with bug 898687.
Attachment #782316 - Attachment is obsolete: true
Attachment #782316 - Flags: review?(peterv)
Attachment #782318 - Flags: review?(peterv)
(Assignee)

Updated

4 years ago
Blocks: 898687

Updated

4 years ago
No longer blocks: 898687

Updated

4 years ago
Blocks: 898687
Attachment #782221 - Flags: review?(peterv) → review?(bzbarsky)
Attachment #782318 - Flags: review?(peterv) → review?(bzbarsky)
I switched the review to bz because peterv is currently on vacation.

Comment 9

4 years ago
Ah, indeed. I thought he was coming back sooner.
Comment on attachment 782318 [details] [diff] [review]
test_interfaces.html update

Don't we want CSSUnknownRule.
(Assignee)

Comment 11

4 years ago
(In reply to Olli Pettay [:smaug] from comment #10)
> Comment on attachment 782318 [details] [diff] [review]
> test_interfaces.html update
> 
> Don't we want CSSUnknownRule.

CSSOM does not define CSSUnknownRule anymore.
http://dev.w3.org/csswg/cssom/
Also, neither IE11 nor Chrome define CSSUnknownRule. Web do not require the interface.
Comment on attachment 782221 [details] [diff] [review]
patch

r=me
Attachment #782221 - Flags: review?(bzbarsky) → review+
Comment on attachment 782318 [details] [diff] [review]
test_interfaces.html update

"ParserJS" can go away too, right?
Attachment #782318 - Flags: review?(bzbarsky) → review+

Updated

4 years ago
Blocks: 899388
(Assignee)

Comment 14

4 years ago
(In reply to Boris Zbarsky (:bz) from comment #13)
> Comment on attachment 782318 [details] [diff] [review]
> test_interfaces.html update
> 
> "ParserJS" can go away too, right?

"ParserJS" was already removed by bug 816410, but I'll remove it while I'm here.
(Assignee)

Comment 15

4 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/2480ee8346d6
https://hg.mozilla.org/integration/mozilla-inbound/rev/a8762aa7ab20
Flags: in-testsuite+
https://hg.mozilla.org/mozilla-central/rev/2480ee8346d6
https://hg.mozilla.org/mozilla-central/rev/a8762aa7ab20
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
Added to the site compatibility doc just in case:
https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/25/Site_Compatibility
Keywords: dev-doc-complete, site-compat
You need to log in before you can comment on or make changes to this bug.