Closed Bug 898817 Opened 11 years ago Closed 11 years ago

Stop exposing nsIDOM* interfaces on the global automatically

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla25

People

(Reporter: emk, Assigned: emk)

References

Details

(Keywords: dev-doc-complete, site-compat)

Attachments

(2 files, 1 obsolete file)

Attached patch patchSplinter Review
This will cleanup useless junks on the global.
Attachment #782221 - Flags: review?(bugs)
Comment on attachment 782221 [details] [diff] [review]
patch

I think we should do this, but also think that peterv or bz should review this change.

Could you provide a list of things this removes from global.
Attachment #782221 - Flags: review?(bugs) → review?(peterv)
Does dom/tests/mochitest/general/test_interfaces.html need to be updated to remove the interfaces that that are no longer exposed?  That would prevent regressions.
Also, at a minimum the comment in there should be update.
Yes, it should be updated.
This patch will serve a purpose of unexposed interface list.
Assignee: nobody → VYV03354
Status: NEW → ASSIGNED
Attachment #782316 - Flags: review?(peterv)
The previous patch failed to resolve conflict with bug 898687.
Attachment #782316 - Attachment is obsolete: true
Attachment #782316 - Flags: review?(peterv)
Attachment #782318 - Flags: review?(peterv)
Blocks: 898687
No longer blocks: 898687
Blocks: 898687
Attachment #782221 - Flags: review?(peterv) → review?(bzbarsky)
Attachment #782318 - Flags: review?(peterv) → review?(bzbarsky)
I switched the review to bz because peterv is currently on vacation.
Ah, indeed. I thought he was coming back sooner.
Comment on attachment 782318 [details] [diff] [review]
test_interfaces.html update

Don't we want CSSUnknownRule.
(In reply to Olli Pettay [:smaug] from comment #10)
> Comment on attachment 782318 [details] [diff] [review]
> test_interfaces.html update
> 
> Don't we want CSSUnknownRule.

CSSOM does not define CSSUnknownRule anymore.
http://dev.w3.org/csswg/cssom/
Also, neither IE11 nor Chrome define CSSUnknownRule. Web do not require the interface.
Comment on attachment 782221 [details] [diff] [review]
patch

r=me
Attachment #782221 - Flags: review?(bzbarsky) → review+
Comment on attachment 782318 [details] [diff] [review]
test_interfaces.html update

"ParserJS" can go away too, right?
Attachment #782318 - Flags: review?(bzbarsky) → review+
Blocks: 899388
(In reply to Boris Zbarsky (:bz) from comment #13)
> Comment on attachment 782318 [details] [diff] [review]
> test_interfaces.html update
> 
> "ParserJS" can go away too, right?

"ParserJS" was already removed by bug 816410, but I'll remove it while I'm here.
https://hg.mozilla.org/mozilla-central/rev/2480ee8346d6
https://hg.mozilla.org/mozilla-central/rev/a8762aa7ab20
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.