898817 - Stop exposing nsIDOM* interfaces on the global automatically

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Masatoshi Kimura [:emk]]

Attachment: patch

This will cleanup useless junks on the global.

Comment 1

[Masatoshi Kimura [:emk]]

https://tbpl.mozilla.org/?tree=Try&rev=30a286f813f0

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 782221 [details] [diff] [review]
patch

I think we should do this, but also think that peterv or bz should review this change.

Could you provide a list of things this removes from global.

Comment 3

[Andrew McCreight [:mccr8]]

Does dom/tests/mochitest/general/test_interfaces.html need to be updated to remove the interfaces that that are no longer exposed?  That would prevent regressions.

Comment 4

[Andrew McCreight [:mccr8]]

Also, at a minimum the comment in there should be update.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Yes, it should be updated.

Comment 6

[Masatoshi Kimura [:emk]]

Attachment: test_interfaces.html updatebug898817_test

This patch will serve a purpose of unexposed interface list.

Comment 7

[Masatoshi Kimura [:emk]]

Attachment: test_interfaces.html update

The previous patch failed to resolve conflict with bug 898687.

Comment 8

[Mounir Lamouri (:mounir)]

I switched the review to bz because peterv is currently on vacation.

Comment 9

[Olli Pettay [:smaug][[e-mail]]]

Ah, indeed. I thought he was coming back sooner.

Comment 10

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 782318 [details] [diff] [review]
test_interfaces.html update

Don't we want CSSUnknownRule.

Comment 11

[Masatoshi Kimura [:emk]]

(In reply to Olli Pettay [:smaug] from comment #10)
> Comment on attachment 782318 [details] [diff] [review]
> test_interfaces.html update
> 
> Don't we want CSSUnknownRule.

CSSOM does not define CSSUnknownRule anymore.
http://dev.w3.org/csswg/cssom/
Also, neither IE11 nor Chrome define CSSUnknownRule. Web do not require the interface.

Comment 12

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 782221 [details] [diff] [review]
patch

r=me

Comment 13

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 782318 [details] [diff] [review]
test_interfaces.html update

"ParserJS" can go away too, right?

Comment 14

[Masatoshi Kimura [:emk]]

(In reply to Boris Zbarsky (:bz) from comment #13)
> Comment on attachment 782318 [details] [diff] [review]
> test_interfaces.html update
> 
> "ParserJS" can go away too, right?

"ParserJS" was already removed by bug 816410, but I'll remove it while I'm here.

Comment 15

[Masatoshi Kimura [:emk]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2480ee8346d6
https://hg.mozilla.org/integration/mozilla-inbound/rev/a8762aa7ab20

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2480ee8346d6
https://hg.mozilla.org/mozilla-central/rev/a8762aa7ab20

Comment 17

[Kohei Yoshino [:kohei]]

Added to the site compatibility doc just in case:
https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/25/Site_Compatibility