[Mac HiDPI]: Account icons in the menu should be HiDPI

RESOLVED FIXED in Thunderbird 26.0

Status

Thunderbird
Theme
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: Nomis101, Assigned: Paenglab)

Tracking

(Blocks: 1 bug)

Trunk
Thunderbird 26.0
x86
Mac OS X

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments, 1 obsolete attachment)

(Reporter)

Description

5 years ago
Created attachment 781802 [details]
Schreenshot of the issue 1

The icons of the accounts in the menu are blurry on a Mac with Retina display because the icons are not HiDPI.

STR: In the menu go to "Go -> Folder" or to "File -> Get new messages for"
(Reporter)

Comment 1

5 years ago
Created attachment 781804 [details]
Screenshot of the issue 2
(Assignee)

Comment 2

4 years ago
Created attachment 782251 [details] [diff] [review]
Add HiDPI to folderMenu.css

I've also changed some LoDPI icons to match the folder pane and fixed a bug in folderPane.css.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #782251 - Flags: ui-review?(bwinton)
Attachment #782251 - Flags: review?(bwinton)
Comment on attachment 782251 [details] [diff] [review]
Add HiDPI to folderMenu.css

Redirecting to mconley, because I (still) don't have a Retina Mac…  ;)
Attachment #782251 - Flags: ui-review?(mconley)
Attachment #782251 - Flags: ui-review?(bwinton)
Attachment #782251 - Flags: review?(mconley)
Attachment #782251 - Flags: review?(bwinton)
(Reporter)

Comment 4

4 years ago
Hm, I don't know why, but thats not working for me, the icons are looking the same after this patch on my rMBP.
(Assignee)

Comment 5

4 years ago
(In reply to Nomis101 from comment #4)
> Hm, I don't know why, but thats not working for me, the icons are looking
> the same after this patch on my rMBP.

Is this again in main menu? Can you check the context- and the AppButton menu? Also in Folder Location toolbar menulist item you can check the icons.

If it's only in main menu it could be a toolkit bug (I don't know if Firefox is using HiDPI icons in main menu).
(Reporter)

Comment 6

4 years ago
(In reply to Richard Marti [:Paenglab] from comment #5)
> (In reply to Nomis101 from comment #4)
> > Hm, I don't know why, but thats not working for me, the icons are looking
> > the same after this patch on my rMBP.
> 
> Is this again in main menu? Can you check the context- and the AppButton
> menu? Also in Folder Location toolbar menulist item you can check the icons.
> 
> If it's only in main menu it could be a toolkit bug (I don't know if Firefox
> is using HiDPI icons in main menu).

Yes its again in the main menu. I've checked the context- and the AppButton menu and it looks not blurry and totaly fine there.
(Reporter)

Comment 7

4 years ago
(In reply to Richard Marti [:Paenglab] from comment #5)
> (I don't know if Firefox
> is using HiDPI icons in main menu).

Yes, they do and this icons are also affected. So I think you are right and this is a toolkit bug. I opened Bug 899334 for that.
Created attachment 801187 [details]
Screenshot with patch applied

Hey Richard,

I applied the patch, but in the OS X menus, I'm still seeing pixel-ated sprites. I can tell via DOMi that the right CSS is being applied... and the sprites look right.  What gives? Did we forget to do something that makes the hidden window pick up the changes to the menubar?

Are you able to see the pixelation still?

-Mike
Flags: needinfo?(richard.marti)
Comment on attachment 782251 [details] [diff] [review]
Add HiDPI to folderMenu.css

Dropping review requests until we can get my above concern sorted.
Attachment #782251 - Flags: ui-review?(mconley)
Attachment #782251 - Flags: review?(mconley)
(Assignee)

Comment 10

4 years ago
Comment on attachment 782251 [details] [diff] [review]
Add HiDPI to folderMenu.css

Yes, like in comment 4 to 7 written, it looks like a toolkit bug (bug 899334). The exactly same rules applied on context, AppMenu and button-getMsgPopup are looking correct. I have no Retina Mac to test this and find a solution for the OS X menus.

Re-adding the reviews as this can't fixed by this bug and the icons are looking correct in all other menus.
Attachment #782251 - Flags: ui-review?(mconley)
Attachment #782251 - Flags: review?(mconley)
(Assignee)

Comment 11

4 years ago
Clearing the needinfo with the answer in comment 10.
Flags: needinfo?(richard.marti)
Comment on attachment 782251 [details] [diff] [review]
Add HiDPI to folderMenu.css

Review of attachment 782251 [details] [diff] [review]:
-----------------------------------------------------------------

Just a suggestion below - no biggie if there's something that restricts you from doing it successfully. If it can't be done, land away. Thanks!

::: mail/themes/osx/mail/folderMenus.css
@@ +185,5 @@
> +  /* ..... servers ..... */
> +
> +  /* IMAP servers */
> +  .folderMenuItem[IsServer="true"][ServerType="imap"][IsSecure="true"] {
> +    list-style-image: url("chrome://messenger/skin/icons/server@2x.png");

Is it possible to not repeat the list-style-image property each time, and have it applied to any .folderMenuItem where IsServer="true"?

And the same for folder-pane@2x.png - can we do that for .folderMenuItems where SpecialFolder != ""?

No biggie if there's a good reason not to, it just looks repetitive here.
Attachment #782251 - Flags: ui-review?(mconley)
Attachment #782251 - Flags: ui-review+
Attachment #782251 - Flags: review?(mconley)
Attachment #782251 - Flags: review+
(Assignee)

Comment 13

4 years ago
Created attachment 801654 [details] [diff] [review]
Patch for check-in

Removed the repeated list-style-images in folderMenus.css. I checked the new file locally and every icon is shown correctly.
Attachment #782251 - Attachment is obsolete: true
Attachment #801654 - Flags: ui-review+
Attachment #801654 - Flags: review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/1bcb7cfc8e9c
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 26.0
You need to log in before you can comment on or make changes to this bug.