899388 - Remove XUL-related interfaces and ChromeWindow from content

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[David Bruant]

Follow-up from https://bugzilla.mozilla.org/show_bug.cgi?id=898687#c12
At the bottom of [1] are listed a bunch of XUL-related interfaces (+ ChromeWindow) which are currently reflected in web content while have no reason to and should be removed from there.


[1] http://mxr.mozilla.org/mozilla-central/source/dom/tests/mochitest/general/test_interfaces.html?force=1

Comment 1

[Masatoshi Kimura [:emk]]

Attachment: Remove XUL-related interfaces and ChromeWindow from content

https://tbpl.mozilla.org/?tree=Try&rev=a59ab2c54b74

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 784408 [details] [diff] [review]
Remove XUL-related interfaces and ChromeWindow from content

Does the XULCommandDispatcher stuff still work in content XBL?  What about the other XUL interfaces here?

Comment 3

[Masatoshi Kimura [:emk]]

Attachment: Remove XUL-related interfaces and ChromeWindow from content, v1.1

Forgot to remove XULControlElement and XULLabeledControlElement.
https://tbpl.mozilla.org/?tree=Try&rev=13c0d678f5d3
But let me consider about content XBL.

Comment 4

[Masatoshi Kimura [:emk]]

Attachment: Part 1: Enable WebIDL XUL interfaces on Chrome or content XBL

Apply this patch on top of bun 900994.

Comment 5

[Masatoshi Kimura [:emk]]

Attachment: Part 2: Implement allowXBL option for xpc bindings

Comment 6

[Masatoshi Kimura [:emk]]

Attachment: Remove XUL-related interfaces and ChromeWindow from content

except content XBL.

Comment 7

[Masatoshi Kimura [:emk]]

Attachment: Part 4: Test to make sure that XUL interfaces are not exposed on content, modulo content XBL

I was unable to remove XULElement from content because wrapping XUL elements will end up with calling XULElementBinding::GetProto().

Comment 8

[Masatoshi Kimura [:emk]]

Green on try except for one known orange:
https://tbpl.mozilla.org/?tree=Try&rev=3d9d6614f958

Comment 9

[Masatoshi Kimura [:emk]]

Attachment: Part 3: Remove XUL-related interfaces and ChromeWindow from content

Rebased

Comment 10

[Boris Zbarsky [:bzbarsky]]

Hmm.  Does the IsChromeOrXBL check work correctly?   Specifically, don't we enter the content compartment before calling that method for interface objects, so we're not calling it for interface ctors on the XBL compartment?

Comment 11

[Masatoshi Kimura [:emk]]

Comment on attachment 785545 [details] [diff] [review]
Part 1: Enable WebIDL XUL interfaces on Chrome or content XBL

Hrm, indeed it didn't work.

Comment 12

[Masatoshi Kimura [:emk]]

Comment on attachment 785548 [details] [diff] [review]
Part 4: Test to make sure that XUL interfaces are not exposed on content, modulo content XBL

I somehow missed a test for WebIDL interface objects...

Comment 13

[Boris Zbarsky [:bzbarsky]]

I suspect the infrastructure I'm adding in bug 897913 might help, actually.

Comment 14

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 785546 [details] [diff] [review]
Part 2: Implement allowXBL option for xpc bindings

r=me

Comment 15

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 785737 [details] [diff] [review]
Part 3: Remove XUL-related interfaces and ChromeWindow from content

r=me

Comment 16

[Masatoshi Kimura [:emk]]

Comment on attachment 785545 [details] [diff] [review]
Part 1: Enable WebIDL XUL interfaces on Chrome or content XBL

Yeah, bug 897913 helped.

Comment 17

[Masatoshi Kimura [:emk]]

Attachment: Part 4: Test to make sure that XUL interfaces are not exposed on content, modulo content XBL

Added WebIDL interfaces to the test.

Comment 18

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 785545 [details] [diff] [review]
Part 1: Enable WebIDL XUL interfaces on Chrome or content XBL

r=me

Comment 19

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 786471 [details] [diff] [review]
Part 4: Test to make sure that XUL interfaces are not exposed on content, modulo content XBL

>+      ok(interfaceNamesInGlobalScope.indexOf(name) >= 0 ||
>+         isXBLScope && interfaceNamesInXBLScope.indexOf(name) >= 0,

I'd prefer:

      ok(interfaceNamesInGlobalScope.indexOf(name) >= 0 ||
         (isXBLScope && interfaceNamesInXBLScope.indexOf(name) >= 0),

and r=me with that

Comment 20

[Masatoshi Kimura [:emk]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/126e61a4b75d
https://hg.mozilla.org/integration/mozilla-inbound/rev/0bfb71d08d59
https://hg.mozilla.org/integration/mozilla-inbound/rev/48073e420747
https://hg.mozilla.org/integration/mozilla-inbound/rev/1f6d2b57730c

Comment 21

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/126e61a4b75d
https://hg.mozilla.org/mozilla-central/rev/0bfb71d08d59
https://hg.mozilla.org/mozilla-central/rev/48073e420747
https://hg.mozilla.org/mozilla-central/rev/1f6d2b57730c

Comment 22

[Kohei Yoshino [:kohei]]

https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/26/Site_Compatibility